Re: [PATCH v5 7/7] arm64: dts: allwinner: h616: Add thermal sensor and zones

From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: Vasily Khoruzhick <anarsoul@gmail.com>,
	Yangtao Li <tiny.windzz@gmail.com>, Chen-Yu Tsai <wens@csie.org>,
	Samuel Holland <samuel@sholland.org>,
	Andre Przywara <andre.przywara@arm.com>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Zhang Rui <rui.zhang@intel.com>,
	Lukasz Luba <lukasz.luba@arm.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Martin Botka <martin.botka@somainline.org>,
	Maksim Kiselev <bigunclemax@gmail.com>,
	Bob McChesney <bob@electricworry.net>,
	linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev
Subject: Re: [PATCH v5 7/7] arm64: dts: allwinner: h616: Add thermal sensor and zones
Date: Fri, 23 Feb 2024 21:41:34 +0100	[thread overview]
Message-ID: <4545502.LvFx2qVVIh@jernej-laptop> (raw)
In-Reply-To: <6017645.lOV4Wx5bFT@jernej-laptop>

Dne petek, 23. februar 2024 ob 20:59:08 CET je Jernej Škrabec napisal(a):
> Dne ponedeljek, 19. februar 2024 ob 16:36:39 CET je Andre Przywara napisal(a):
> > From: Martin Botka <martin.botka@somainline.org>
> > 
> > There are four thermal sensors:
> > - CPU
> > - GPU
> > - VE
> > - DRAM
> > 
> > Add the thermal sensor configuration and the thermal zones.
> > 
> > Signed-off-by: Martin Botka <martin.botka@somainline.org>
> > Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> 
> I can't cleanly apply patch on top of sunxi/dt-for-6.9. Can you please rebase?

I rebased and applied. Thanks!

Best regards,
Jernej

> > ---
> >  .../arm64/boot/dts/allwinner/sun50i-h616.dtsi | 88 +++++++++++++++++++
> >  1 file changed, 88 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
> > index 12ffabc79bcde..7c7d7c285505c 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
> > @@ -9,6 +9,7 @@
> >  #include <dt-bindings/clock/sun6i-rtc.h>
> >  #include <dt-bindings/reset/sun50i-h616-ccu.h>
> >  #include <dt-bindings/reset/sun50i-h6-r-ccu.h>
> > +#include <dt-bindings/thermal/thermal.h>
> >  
> >  / {
> >  	interrupt-parent = <&gic>;
> > @@ -138,6 +139,10 @@ sid: efuse@3006000 {
> >  			reg = <0x03006000 0x1000>;
> >  			#address-cells = <1>;
> >  			#size-cells = <1>;
> > +
> > +			ths_calibration: thermal-sensor-calibration@14 {
> > +				reg = <0x14 0x8>;
> > +			};
> >  		};
> >  
> >  		watchdog: watchdog@30090a0 {
> > @@ -517,6 +522,19 @@ mdio0: mdio {
> >  			};
> >  		};
> >  
> > +		ths: thermal-sensor@5070400 {
> > +			compatible = "allwinner,sun50i-h616-ths";
> > +			reg = <0x05070400 0x400>;
> > +			interrupts = <GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>;
> > +			clocks = <&ccu CLK_BUS_THS>;
> > +			clock-names = "bus";
> > +			resets = <&ccu RST_BUS_THS>;
> > +			nvmem-cells = <&ths_calibration>;
> > +			nvmem-cell-names = "calibration";
> > +			allwinner,sram = <&syscon>;
> > +			#thermal-sensor-cells = <1>;
> > +		};
> > +
> >  		usbotg: usb@5100000 {
> >  			compatible = "allwinner,sun50i-h616-musb",
> >  				     "allwinner,sun8i-h3-musb";
> > @@ -761,4 +779,74 @@ r_rsb: rsb@7083000 {
> >  			#size-cells = <0>;
> >  		};
> >  	};
> > +
> > +	thermal-zones {
> > +		cpu-thermal {
> > +			polling-delay-passive = <500>;
> > +			polling-delay = <1000>;
> > +			thermal-sensors = <&ths 2>;
> > +			sustainable-power = <1000>;
> > +
> > +			trips {
> > +				cpu_threshold: cpu-trip-0 {
> > +					temperature = <60000>;
> > +					type = "passive";
> > +					hysteresis = <0>;
> > +				};
> > +				cpu_target: cpu-trip-1 {
> > +					temperature = <70000>;
> > +					type = "passive";
> > +					hysteresis = <0>;
> > +				};
> > +				cpu_critical: cpu-trip-2 {
> > +					temperature = <110000>;
> > +					type = "critical";
> > +					hysteresis = <0>;
> > +				};
> > +			};
> > +		};
> > +
> > +		gpu-thermal {
> > +			polling-delay-passive = <500>;
> > +			polling-delay = <1000>;
> > +			thermal-sensors = <&ths 0>;
> > +			sustainable-power = <1100>;
> > +
> > +			trips {
> > +				gpu_temp_critical: gpu-trip-0 {
> > +					temperature = <110000>;
> > +					type = "critical";
> > +					hysteresis = <0>;
> > +				};
> > +			};
> > +		};
> > +
> > +		ve-thermal {
> > +			polling-delay-passive = <0>;
> > +			polling-delay = <0>;
> > +			thermal-sensors = <&ths 1>;
> > +
> > +			trips {
> > +				ve_temp_critical: ve-trip-0 {
> > +					temperature = <110000>;
> > +					type = "critical";
> > +					hysteresis = <0>;
> > +				};
> > +			};
> > +		};
> > +
> > +		ddr-thermal {
> > +			polling-delay-passive = <0>;
> > +			polling-delay = <0>;
> > +			thermal-sensors = <&ths 3>;
> > +
> > +			trips {
> > +				ddr_temp_critical: ddr-trip-0 {
> > +					temperature = <110000>;
> > +					type = "critical";
> > +					hysteresis = <0>;
> > +				};
> > +			};
> > +		};
> > +	};
> >  };
> > 
> 
> 
> 
> 
> 