[Bluez-devel] PATCH for dund : correct --dialup behavior (Tomtom GPS)

[Bluez-devel] PATCH for dund : correct --dialup behavior (Tomtom GPS)

[Valentin SURREL]

Hello,

I've found a little problem when trying to connect my Tomtom One GPS to 
the Intenet via my computer.

Tomtom GPS expect to find a GSM Phone with DUN. I changed the class in 
/etc/bluetooth/hcid.conf to 0x520204.
Then I started dund with the correct options (--dialup particularly).

It did'nt work, Tomtom claiming that my 'phone' have not DUN.

I made this very little modification to dund/sdp.c :

./bluez-utils-3.7/dund$ diff sdp_original.c sdp.c
173a174,176
 >       case DIALUP:
 >               sdp_uuid16_create(&svclass, DIALUP_NET_SVCLASS_ID);
 >               break;

After that, it works perfectly. Maybe this patch should be integrated 
into the official Bluez utils...

Valentin SURREL


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] PATCH for dund : correct --dialup behavior (Tomtom GPS)

[Marcel Holtmann]

Hi Valentin,

> I've found a little problem when trying to connect my Tomtom One GPS to 
> the Intenet via my computer.
> 
> Tomtom GPS expect to find a GSM Phone with DUN. I changed the class in 
> /etc/bluetooth/hcid.conf to 0x520204.
> Then I started dund with the correct options (--dialup particularly).
> 
> It did'nt work, Tomtom claiming that my 'phone' have not DUN.
> 
> I made this very little modification to dund/sdp.c :
> 
> ./bluez-utils-3.7/dund$ diff sdp_original.c sdp.c
> 173a174,176
>  >       case DIALUP:
>  >               sdp_uuid16_create(&svclass, DIALUP_NET_SVCLASS_ID);
>  >               break;
> 
> After that, it works perfectly. Maybe this patch should be integrated 
> into the official Bluez utils...

please create a unified diff, because I can't read these context diffs.

Regards

Marcel



-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] PATCH for dund : correct --dialup behavior (Tomtom GPS)

[Valentin SURREL]

Marcel Holtmann a =E9crit :
> Hi Valentin,
>
> please create a unified diff, because I can't read these context diffs.
>
> Regards
>
> Marcel
>
>   =

Hi,

It's my really first contribution to the GPL world, and I'm not familiar =

with the developpment tools. :-)

This one might be better... (it works for me with "patch < mypatch" in =

the correct directory)

--- sdp.c       2006-05-23 14:48:37.000000000 +0200
+++ sdp.c       2006-11-19 11:37:10.000000000 +0100
@@ -171,6 +171,9 @@ int dun_sdp_search(bdaddr_t *src, bdaddr
        case ACTIVESYNC:
                sdp_uuid128_create(&svclass, (void *) async_uuid);
                break;
+       case DIALUP:
+               sdp_uuid16_create(&svclass, DIALUP_NET_SVCLASS_ID);
+               break;
        default:
                sdp_uuid16_create(&svclass, LAN_ACCESS_SVCLASS_ID);
                break;

Valentin

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=3Djoin.php&p=3Dsourceforge&CID=3DDE=
VDEV
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] PATCH for dund : correct --dialup behavior (Tomtom GPS)

[Marcel Holtmann]

Hi Valentin,

> It's my really first contribution to the GPL world, and I'm not familiar 
> with the developpment tools. :-)

don't worry. We tell you, but I think the difference between a context
diff and unified diff is quite clear. I simply can't review any diff
that is not in unified format. Actually this should be default, but it
isn't.

> This one might be better... (it works for me with "patch < mypatch" in 
> the correct directory)
> 
> --- sdp.c       2006-05-23 14:48:37.000000000 +0200
> +++ sdp.c       2006-11-19 11:37:10.000000000 +0100
> @@ -171,6 +171,9 @@ int dun_sdp_search(bdaddr_t *src, bdaddr
>         case ACTIVESYNC:
>                 sdp_uuid128_create(&svclass, (void *) async_uuid);
>                 break;
> +       case DIALUP:
> +               sdp_uuid16_create(&svclass, DIALUP_NET_SVCLASS_ID);
> +               break;
>         default:
>                 sdp_uuid16_create(&svclass, LAN_ACCESS_SVCLASS_ID);
>                 break;

Patch has been committed to the CVS. Thanks.

Regards

Marcel



-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] PATCH for dund : correct --dialup behavior (Tomtom GPS)

[Arjan van de Ven]

On Sun, 2006-11-19 at 05:12 -0800,
bluez-devel-request@lists.sourceforge.net wrote:
> Re: PATCH for dund : correct --dialup     behavior        (Tomtom GPS)


> I've found a little problem when trying to connect my Tomtom One GPS
> to the Intenet via my computer.


Have you seen my webpage about this topic? I made all of this work quite
some time ago ;)

http://www.fenrus.org/tomtom/



-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] PATCH for dund : correct --dialup behavior (Tomtom GPS)

[Marcel Holtmann]

Hi Arjan,

> bluez-devel-request@lists.sourceforge.net wrote:
> > Re: PATCH for dund : correct --dialup     behavior        (Tomtom GPS)
> 
> 
> > I've found a little problem when trying to connect my Tomtom One GPS
> > to the Intenet via my computer.
> 
> 
> Have you seen my webpage about this topic? I made all of this work quite
> some time ago ;)
> 
> http://www.fenrus.org/tomtom/

actually your patch has been applied a long time ago.

Regards

Marcel



-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel