Re: Multiple small fixes to policycoreutils

[Karl MacMillan <kmacmillan@mentalrootkit.com>]

Daniel J Walsh wrote:
> Karl MacMillan wrote:
>> Joshua Brindle wrote:
>>>> From: Karl MacMillan [mailto:kmacmillan@mentalrootkit.com]
>>>> Daniel J Walsh wrote:
>>>>> Joshua Brindle wrote:
>>>>>> Karl MacMillan wrote:
>>>> <snip>
>>>>
>>>>>>> What about a top-level USE_PIE makefile variable that directs all 
>>>>>>> sub-Makefiles to set PIE flags if appropriate for that module? By 
>>>>>>> default it would be off. This gets the behavior you want without 
>>>>>>> having to carry a patch and keeps the current behavior.
>>>>>>>
>>>>>> No patch necessary, like Chris said make CFLAGS="-fPIE -02 -Werror 
>>>>>> -Wall" LDFLAGS="-pie"
>>>>>>
>>>>>> done and done.
>>>>>>
>>>>> No, because then all compiled apps become -pie.  We only 
>>>> want this on
>>>>> the daemons.
>>>>>
>>>> What about this instead?
>>>
>>> Why doesn't make CFLAGS="-fPIE -02 -Werror -Wall" LDFLAGS="-pie" 
>>> work? Why does itmatter if everything is built pie?
>>>
>>
>> There are performance costs associated with pie, particularly at 
>> startup. Talking to Dan though, he doesn't think it is enough to not 
>> just build everything as pie.
>>
>> Resend below that I will apply unless there are other objections.
>>

Committed as policycoreutils 1.33.2.


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.