Re: More small fixes to policycoreutils

[Daniel J Walsh <dwalsh@redhat.com>]

Joshua Brindle wrote:
> Daniel J Walsh wrote:
>> run_init patch for call pam_acct_mgmt
>>
>>
>> ------------------------------------------------------------------------
>>
>> diff --exclude-from=exclude --exclude='*.po' --exclude='*.pot' -N -u 
>> -r nsapolicycoreutils/run_init/run_init.c 
>> policycoreutils-1.33.4/run_init/run_init.c
>> --- nsapolicycoreutils/run_init/run_init.c    2006-11-16 
>> 17:14:27.000000000 -0500
>> +++ policycoreutils-1.33.4/run_init/run_init.c    2006-11-22 
>> 14:11:25.000000000 -0500
>> @@ -132,6 +132,14 @@
>>          result = 1;    /* user authenticated OK! */
>>      }
>>  
>> +    /* If we were successful, call pam_acct_mgmt() to reset the
>> +         * pam_tally failcount.
>> +         */
>> +    if (result && (PAM_SUCCESS != pam_acct_mgmt(pam_handle, 0)) ) {
>> +        fprintf(stderr, _("failed to get account information\n"));
>> +        exit(-1);
>> +    }   
>> +
>>      /* We're done with PAM.  Free `pam_handle'. */
>>      pam_end(pam_handle, PAM_SUCCESS);
>>  
>
> I thought the previous thread noted that this was unnecessary, or am I 
> confused?
>
The pam_tally might not be required anymore.  But best practices says 
put it in there.

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.