All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Alan <alan@lxorguk.ukuu.org.uk>
Cc: Segher Boessenkool <segher@kernel.crashing.org>,
	Olaf Hering <olaf@aepfle.de>,
	linux-ide@vger.kernel.org, linuxppc-dev@ozlabs.org,
	greg@kroah.com, linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: What is the correct way to indicate an unassigned PCI resource ?
Date: Mon, 04 Dec 2006 18:40:09 +0300	[thread overview]
Message-ID: <45744159.8040301@ru.mvista.com> (raw)
In-Reply-To: <20061204144411.246f3700@localhost.localdomain>

Hello.

Alan wrote:

>>    When Linus remaps IRQ0 on x86, I'll follow that code as a testament. Until 
>>this happens, I consider is just an opinion. Forcing every arch but x86 to 
>>remap IRQ0 is an example of the double standards.

> Yawn.. x86 does not expose IRQ 0 outside of arch specific code.

    Can you believe, some non-x86 platofrms also don't -- for example, IRQ0 
may be internal to SOC, not shareable or routable outside of it, BUT the SOC 
device is driven by the standard driver (I'm minding 8250.c here). Yet we're 
told that we should remap it, period...

>>>The checks need pushing upwards and removing from their current place -
>>>the pci layer should check the resource length, the isa pnp should I
>>>believe check for zero address etc.

>>    So, it's OK to remove the base *address* check in ide_hwif_confiure() 
>>altogether?

> IFF you move all the other checks, verify their correctness and then get
> them tested for a while yes

    All other checks aren't hindering (at least me ATM).  What's probably 
worth doing is to check the result of ide_pci_check_iomem() some lines above 
the discussed check (it's ignored now).

WBR, Sergei

WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Alan <alan@lxorguk.ukuu.org.uk>
Cc: Olaf Hering <olaf@aepfle.de>,
	linuxppc-dev@ozlabs.org, greg@kroah.com,
	linux-ide@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: What is the correct way to indicate an unassigned PCI resource ?
Date: Mon, 04 Dec 2006 18:40:09 +0300	[thread overview]
Message-ID: <45744159.8040301@ru.mvista.com> (raw)
In-Reply-To: <20061204144411.246f3700@localhost.localdomain>

Hello.

Alan wrote:

>>    When Linus remaps IRQ0 on x86, I'll follow that code as a testament. Until 
>>this happens, I consider is just an opinion. Forcing every arch but x86 to 
>>remap IRQ0 is an example of the double standards.

> Yawn.. x86 does not expose IRQ 0 outside of arch specific code.

    Can you believe, some non-x86 platofrms also don't -- for example, IRQ0 
may be internal to SOC, not shareable or routable outside of it, BUT the SOC 
device is driven by the standard driver (I'm minding 8250.c here). Yet we're 
told that we should remap it, period...

>>>The checks need pushing upwards and removing from their current place -
>>>the pci layer should check the resource length, the isa pnp should I
>>>believe check for zero address etc.

>>    So, it's OK to remove the base *address* check in ide_hwif_confiure() 
>>altogether?

> IFF you move all the other checks, verify their correctness and then get
> them tested for a while yes

    All other checks aren't hindering (at least me ATM).  What's probably 
worth doing is to check the result of ide_pci_check_iomem() some lines above 
the discussed check (it's ignored now).

WBR, Sergei

  reply	other threads:[~2006-12-04 15:38 UTC|newest]

Thread overview: 90+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-30 16:52 pata_sl82c105 can not reserve IO region Olaf Hering
2006-11-30 17:10 ` Alan
2006-11-30 18:47   ` Olaf Hering
2006-12-01 18:34     ` Olaf Hering
2006-12-01 18:58       ` Alan
2006-12-01 19:05       ` Sergei Shtylyov
2006-12-01 19:05         ` Sergei Shtylyov
2006-12-01 21:53         ` Benjamin Herrenschmidt
2006-12-01 21:53           ` Benjamin Herrenschmidt
2006-12-01 22:15           ` Alan
2006-12-01 22:15             ` Alan
2006-12-01 22:19             ` Benjamin Herrenschmidt
2006-12-01 22:19               ` Benjamin Herrenschmidt
2006-12-02 14:36               ` U-Boot allocating PCI I/O space from 0 (Was: pata_sl82c105 can not reserve IO region) Sergei Shtylyov
2006-12-02 16:33                 ` Sergei Shtylyov
2006-12-26 20:53                   ` [U-Boot-Users] " Sergei Shtylyov
2006-12-03 23:39               ` pata_sl82c105 can not reserve IO region Alan
2006-12-03 23:39                 ` Alan
2006-12-03 17:12 ` Olaf Hering
2006-12-03 22:24   ` Olaf Hering
2006-12-03 23:23     ` Alan
2006-12-04  0:30       ` Olaf Hering
2006-12-04  9:21         ` Olaf Hering
2006-12-03 23:07   ` Alan
2006-12-04 12:38 ` [PATCH] mark PCI resource with start 0 as unassigned Olaf Hering
2006-12-04 12:44   ` Segher Boessenkool
2006-12-04 12:50     ` Sergei Shtylyov
2006-12-04 12:50       ` Sergei Shtylyov
2006-12-04 12:54       ` Segher Boessenkool
2006-12-04 12:54         ` Segher Boessenkool
2006-12-04 13:08         ` Sergei Shtylyov
2006-12-04 13:08           ` Sergei Shtylyov
2006-12-04 13:21           ` Alan
2006-12-04 13:25             ` Segher Boessenkool
2006-12-04 13:25               ` Segher Boessenkool
2006-12-04 14:15               ` Alan
2007-08-01 14:22               ` Sergei Shtylyov
2007-08-01 14:22                 ` Sergei Shtylyov
2007-08-01 15:51                 ` Alan Cox
2007-08-01 15:51                   ` Alan Cox
2007-08-06 18:04                   ` Segher Boessenkool
2007-08-06 18:04                     ` Segher Boessenkool
2007-08-06 19:52                     ` Alan Cox
2007-08-06 19:52                       ` Alan Cox
2007-08-06 22:14                     ` Benjamin Herrenschmidt
2007-08-06 22:14                       ` Benjamin Herrenschmidt
2006-12-04 13:27             ` Sergei Shtylyov
2006-12-04 13:27               ` Sergei Shtylyov
2006-12-04 14:22               ` What is the correct way to indicate an unassigned PCI resource ? Alan
2006-12-04 14:34                 ` Sergei Shtylyov
2006-12-04 14:34                   ` Sergei Shtylyov
2006-12-04 14:44                   ` Alan
2006-12-04 15:40                     ` Sergei Shtylyov [this message]
2006-12-04 15:40                       ` Sergei Shtylyov
2006-12-04 15:55                       ` Sergei Shtylyov
2006-12-04 15:55                         ` Sergei Shtylyov
2006-12-04 20:53                         ` Guennadi Liakhovetski
2006-12-04 20:53                           ` Guennadi Liakhovetski
2006-12-05  4:43                           ` Benjamin Herrenschmidt
2006-12-05  4:43                             ` Benjamin Herrenschmidt
2006-12-05  4:41                 ` Benjamin Herrenschmidt
2006-12-05  4:41                   ` Benjamin Herrenschmidt
2006-12-05  8:15                   ` Olaf Hering
2006-12-05  8:15                     ` Olaf Hering
2006-12-05 20:19                     ` Benjamin Herrenschmidt
2006-12-05 20:19                       ` Benjamin Herrenschmidt
2006-12-05 21:26                       ` Sergei Shtylyov
2006-12-05 21:26                         ` Sergei Shtylyov
2007-01-04 17:49                       ` Olaf Hering
2007-01-04 21:30                         ` Benjamin Herrenschmidt
2007-01-05 10:26                           ` Olaf Hering
2007-01-05 10:26                             ` Olaf Hering
2007-01-05 12:05                             ` Benjamin Herrenschmidt
2007-01-05 12:05                               ` Benjamin Herrenschmidt
2006-12-05 10:51                   ` Gabriel Paubert
2006-12-05 10:51                     ` Gabriel Paubert
2006-12-05 12:38                     ` Sergei Shtylyov
2006-12-05 12:38                       ` Sergei Shtylyov
2006-12-05 17:37                       ` Grant Grundler
2006-12-05 17:37                         ` Grant Grundler
2006-12-05 19:22                         ` Sergei Shtylyov
2006-12-05 19:22                           ` Sergei Shtylyov
2006-12-04 12:56     ` [PATCH] mark PCI resource with start 0 as unassigned Olaf Hering
2006-12-04 13:05       ` Segher Boessenkool
2006-12-04 12:47   ` Sergei Shtylyov
2006-12-04 12:40 ` [PATCH] add delay around sl82c105_reset_engine calls Olaf Hering
2006-12-04 13:02   ` Alan
2006-12-04 13:12     ` Olaf Hering
2007-01-04  6:42     ` Olaf Hering
2007-01-04 10:53       ` Alan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45744159.8040301@ru.mvista.com \
    --to=sshtylyov@ru.mvista.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=greg@kroah.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=olaf@aepfle.de \
    --cc=segher@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.