* [2.6 patch] drivers/net/bnx2.c: add an error check
@ 2006-12-07 11:34 Adrian Bunk
2006-12-07 11:47 ` Jeff Garzik
2006-12-07 17:31 ` Michael Chan
0 siblings, 2 replies; 4+ messages in thread
From: Adrian Bunk @ 2006-12-07 11:34 UTC (permalink / raw)
To: Michael Chan; +Cc: davem, jgarzik, linux-kernel
This patch adds a missing error check spotted by the Coverity checker.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.19-rc6-mm2/drivers/net/bnx2.c.old 2006-12-06 13:32:51.000000000 +0100
+++ linux-2.6.19-rc6-mm2/drivers/net/bnx2.c 2006-12-06 13:33:34.000000000 +0100
@@ -2510,7 +2510,7 @@
if (CHIP_NUM(bp) == CHIP_NUM_5709) {
fw = &bnx2_cp_fw_09;
- load_cpu_fw(bp, &cpu_reg, fw);
+ rc = load_cpu_fw(bp, &cpu_reg, fw);
if (rc)
goto init_cpu_err;
}
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [2.6 patch] drivers/net/bnx2.c: add an error check
2006-12-07 11:34 [2.6 patch] drivers/net/bnx2.c: add an error check Adrian Bunk
@ 2006-12-07 11:47 ` Jeff Garzik
2006-12-07 17:31 ` Michael Chan
1 sibling, 0 replies; 4+ messages in thread
From: Jeff Garzik @ 2006-12-07 11:47 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Michael Chan, davem, linux-kernel
Adrian Bunk wrote:
> This patch adds a missing error check spotted by the Coverity checker.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
ACK
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [2.6 patch] drivers/net/bnx2.c: add an error check
2006-12-07 11:34 [2.6 patch] drivers/net/bnx2.c: add an error check Adrian Bunk
2006-12-07 11:47 ` Jeff Garzik
@ 2006-12-07 17:31 ` Michael Chan
2006-12-07 23:10 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Michael Chan @ 2006-12-07 17:31 UTC (permalink / raw)
To: Adrian Bunk; +Cc: davem, jgarzik, linux-kernel
Adrian Bunk wrote:
> This patch adds a missing error check spotted by the Coverity checker.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
Acked-by: Michael Chan <mchan@broadcom.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [2.6 patch] drivers/net/bnx2.c: add an error check
2006-12-07 17:31 ` Michael Chan
@ 2006-12-07 23:10 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2006-12-07 23:10 UTC (permalink / raw)
To: mchan; +Cc: bunk, jgarzik, linux-kernel
From: "Michael Chan" <mchan@broadcom.com>
Date: Thu, 7 Dec 2006 09:31:40 -0800
>
> Adrian Bunk wrote:
> > This patch adds a missing error check spotted by the Coverity checker.
> >
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> >
> Acked-by: Michael Chan <mchan@broadcom.com>
Applied, thanks everyone.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-12-07 23:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-07 11:34 [2.6 patch] drivers/net/bnx2.c: add an error check Adrian Bunk
2006-12-07 11:47 ` Jeff Garzik
2006-12-07 17:31 ` Michael Chan
2006-12-07 23:10 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.