All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: Arnd Bergmann <arnd.bergmann@de.ibm.com>
Cc: jgarzik@pobox.com, linux-ide@vger.kernel.org,
	linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] libata: don't initialize sg in ata_exec_internal() if DMA_NONE
Date: Mon, 11 Dec 2006 23:23:35 +0900	[thread overview]
Message-ID: <457D69E7.9040708@gmail.com> (raw)
In-Reply-To: <20061211140258.GB18947@htj.dyndns.org>

Tejun Heo wrote:
> I'll follow up with conversion to ata_do_simple_cmd().

The current situation is...

ata_exec_internal_sg()	: no user except for ata_exec_internal() yet
ata_exec_internal()	: one data transferring user. other are non-data
ata_do_simple_cmd()	: three users

So, adding another exec_internal variant doesn't look so hot.  It seems
we already have enough variants considering the small number of users.
I think it's best to leave it alone for now.

Thanks.

-- 
tejun

WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <htejun@gmail.com>
To: Arnd Bergmann <arnd.bergmann@de.ibm.com>
Cc: linux-ide@vger.kernel.org, jgarzik@pobox.com,
	linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] libata: don't initialize sg in ata_exec_internal() if DMA_NONE
Date: Mon, 11 Dec 2006 23:23:35 +0900	[thread overview]
Message-ID: <457D69E7.9040708@gmail.com> (raw)
In-Reply-To: <20061211140258.GB18947@htj.dyndns.org>

Tejun Heo wrote:
> I'll follow up with conversion to ata_do_simple_cmd().

The current situation is...

ata_exec_internal_sg()	: no user except for ata_exec_internal() yet
ata_exec_internal()	: one data transferring user. other are non-data
ata_do_simple_cmd()	: three users

So, adding another exec_internal variant doesn't look so hot.  It seems
we already have enough variants considering the small number of users.
I think it's best to leave it alone for now.

Thanks.

-- 
tejun

  parent reply	other threads:[~2006-12-11 14:23 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-08 18:14 [PATCH] libata: fix oops with sparsemem Arnd Bergmann
2006-12-08 18:14 ` Arnd Bergmann
2006-12-11 14:02 ` [PATCH] libata: don't initialize sg in ata_exec_internal() if DMA_NONE Tejun Heo
2006-12-11 14:02   ` Tejun Heo
2006-12-11 14:18   ` Arnd Bergmann
2006-12-11 14:18     ` Arnd Bergmann
2006-12-11 14:33     ` Jeff Garzik
2006-12-11 14:33       ` Jeff Garzik
2006-12-11 14:23   ` Tejun Heo [this message]
2006-12-11 14:23     ` Tejun Heo
2006-12-11 15:55   ` Jeff Garzik
2006-12-11 15:55     ` Jeff Garzik
2006-12-11 17:15     ` [PATCH] libata: don't initialize sg in ata_exec_internal() if DMA_NONE (take #2) Tejun Heo
2006-12-11 17:15       ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=457D69E7.9040708@gmail.com \
    --to=htejun@gmail.com \
    --cc=arnd.bergmann@de.ibm.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.