From: Jeff Garzik <jgarzik@pobox.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linuxppc-dev@ozlabs.org, Tejun Heo <htejun@gmail.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] libata: don't initialize sg in ata_exec_internal() if DMA_NONE
Date: Mon, 11 Dec 2006 09:33:51 -0500 [thread overview]
Message-ID: <457D6C4F.6090303@pobox.com> (raw)
In-Reply-To: <200612111518.46887.arnd@arndb.de>
Arnd Bergmann wrote:
> On Monday 11 December 2006 15:02, Tejun Heo wrote:
>> {
>> struct scatterlist sg;
>> + unsigned int n_elem = 0;
>>
>> - sg_init_one(&sg, buf, buflen);
>> + if (dma_dir != DMA_NONE) {
>> + WARN_ON(!buf);
>> + sg_init_one(&sg, buf, buflen);
>> + n_elem++;
>> + }
>>
> Ok, looks good as well. I still think we should have the WARN_ON()
> in sg_set_buf(), but I can send a separate patch for that to linux-mm.
Please CC me and linux-ide on all libata patches (certainly akpm as
well). Andrew picks up most of the libata changes automatically via git
from my libata-dev.git#ALL.
Jeff
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Garzik <jgarzik@pobox.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linuxppc-dev@ozlabs.org, Tejun Heo <htejun@gmail.com>,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: don't initialize sg in ata_exec_internal() if DMA_NONE
Date: Mon, 11 Dec 2006 09:33:51 -0500 [thread overview]
Message-ID: <457D6C4F.6090303@pobox.com> (raw)
In-Reply-To: <200612111518.46887.arnd@arndb.de>
Arnd Bergmann wrote:
> On Monday 11 December 2006 15:02, Tejun Heo wrote:
>> {
>> struct scatterlist sg;
>> + unsigned int n_elem = 0;
>>
>> - sg_init_one(&sg, buf, buflen);
>> + if (dma_dir != DMA_NONE) {
>> + WARN_ON(!buf);
>> + sg_init_one(&sg, buf, buflen);
>> + n_elem++;
>> + }
>>
> Ok, looks good as well. I still think we should have the WARN_ON()
> in sg_set_buf(), but I can send a separate patch for that to linux-mm.
Please CC me and linux-ide on all libata patches (certainly akpm as
well). Andrew picks up most of the libata changes automatically via git
from my libata-dev.git#ALL.
Jeff
next prev parent reply other threads:[~2006-12-11 14:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-08 18:14 [PATCH] libata: fix oops with sparsemem Arnd Bergmann
2006-12-08 18:14 ` Arnd Bergmann
2006-12-11 14:02 ` [PATCH] libata: don't initialize sg in ata_exec_internal() if DMA_NONE Tejun Heo
2006-12-11 14:02 ` Tejun Heo
2006-12-11 14:18 ` Arnd Bergmann
2006-12-11 14:18 ` Arnd Bergmann
2006-12-11 14:33 ` Jeff Garzik [this message]
2006-12-11 14:33 ` Jeff Garzik
2006-12-11 14:23 ` Tejun Heo
2006-12-11 14:23 ` Tejun Heo
2006-12-11 15:55 ` Jeff Garzik
2006-12-11 15:55 ` Jeff Garzik
2006-12-11 17:15 ` [PATCH] libata: don't initialize sg in ata_exec_internal() if DMA_NONE (take #2) Tejun Heo
2006-12-11 17:15 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=457D6C4F.6090303@pobox.com \
--to=jgarzik@pobox.com \
--cc=arnd@arndb.de \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.