All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@qumranet.com>
To: caglar@pardus.org.tr
Cc: lkml <linux-kernel@vger.kernel.org>, kvm-devel@lists.sourceforge.net
Subject: Re: [PATCH] KVM: 'asm' operand has impossible constraints
Date: Sun, 28 Jan 2007 11:45:09 +0200	[thread overview]
Message-ID: <45BC70A5.7030707@qumranet.com> (raw)
In-Reply-To: <200701272328.31532.caglar@pardus.org.tr>

S.Çağlar Onur wrote:
> 27 Oca 2007 Cts tarihinde, Avi Kivity şunları yazmıştı: 
>   
>> The patch looks correct, but I don't understand the gcc error message.
>> Are we sure this isn't a gcc 4.2 bug?
>>
>> "g" appears to be equivalent to "rmi", if "i" is impossible, gcc is free
>> to use "r" or "m", no?
>>     
>
> Accorgind to GCC devs. its not a bug 
> (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29808), on comment #5 the 
> problem described like;
>
> "g" means "r"+"i" so the register allocator in the -O0 case is selecting "r" 
> while in the optimize case is selecting "i"
>
>   

That's a different bug. The gcc PR has an assembler error message, as 
expected, whereas the kvm miscompile has a compiler error, which I don't 
understand.

Anyhow, your patch is correct (because selecting "i" is indeed 
erroneous) so I'll apply it, but I'm worried that there's a gcc bug in 
there that we ought to report.


-- 
error compiling committee.c: too many arguments to function


WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: caglar-caicS1wCkhO6A22drWdTBw@public.gmane.org
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	lkml <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] KVM: 'asm' operand has impossible constraints
Date: Sun, 28 Jan 2007 11:45:09 +0200	[thread overview]
Message-ID: <45BC70A5.7030707@qumranet.com> (raw)
In-Reply-To: <200701272328.31532.caglar-caicS1wCkhO6A22drWdTBw@public.gmane.org>

S.Çağlar Onur wrote:
> 27 Oca 2007 Cts tarihinde, Avi Kivity şunları yazmıştı: 
>   
>> The patch looks correct, but I don't understand the gcc error message.
>> Are we sure this isn't a gcc 4.2 bug?
>>
>> "g" appears to be equivalent to "rmi", if "i" is impossible, gcc is free
>> to use "r" or "m", no?
>>     
>
> Accorgind to GCC devs. its not a bug 
> (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29808), on comment #5 the 
> problem described like;
>
> "g" means "r"+"i" so the register allocator in the -O0 case is selecting "r" 
> while in the optimize case is selecting "i"
>
>   

That's a different bug. The gcc PR has an assembler error message, as 
expected, whereas the kvm miscompile has a compiler error, which I don't 
understand.

Anyhow, your patch is correct (because selecting "i" is indeed 
erroneous) so I'll apply it, but I'm worried that there's a gcc bug in 
there that we ought to report.


-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel

  parent reply	other threads:[~2007-01-28  9:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-25 23:40 [PATCH] KVM: 'asm' operand has impossible constraints S.Çağlar Onur
2007-01-27  9:05 ` Avi Kivity
2007-01-27  9:05   ` Avi Kivity
2007-01-27 16:36   ` Paweł Sikora
2007-01-28  9:41     ` Avi Kivity
2007-01-28  9:41       ` Avi Kivity
2007-01-27 21:28   ` S.Çağlar Onur
2007-01-27 21:46     ` D. Hazelton
2007-01-28  7:55     ` H. Peter Anvin
2007-01-28  9:45     ` Avi Kivity [this message]
2007-01-28  9:45       ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45BC70A5.7030707@qumranet.com \
    --to=avi@qumranet.com \
    --cc=caglar@pardus.org.tr \
    --cc=kvm-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.