From: Avi Kivity <avi@qumranet.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: nigel@nigel.suspend2.net, kvm-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, akpm@osdl.org, mingo@elte.hu
Subject: Re: [PATCH 5/5] KVM: Host suspend/resume support
Date: Wed, 31 Jan 2007 11:07:01 +0200 [thread overview]
Message-ID: <45C05C35.9040107@qumranet.com> (raw)
In-Reply-To: <200701302319.10369.rjw@sisk.pl>
Rafael J. Wysocki wrote:
> On Tuesday, 30 January 2007 22:20, Nigel Cunningham wrote:
>
>> Hi.
>>
>> On Tue, 2007-01-30 at 14:57 +0000, Avi Kivity wrote:
>>
>>> Add the necessary callbacks to suspend and resume a host running kvm. This
>>> is just a repeat of the cpu hotplug/unplug work.
>>>
>>> Signed-off-by: Avi Kivity <avi@qumranet.com>
>>>
>> Maybe it's just a lack of understanding, but I'm wondering if this patch
>> is necessary - we already hot-unplug secondary cpus prior to suspending
>> devices.
>>
>
>
The on_each_cpu() in the patch really means on_this_cpu().
> Not with the reoredering patches that are in -mm, though. With these patches,
> the nonboot CPUs are disabled after "regular" devices.
>
After that, it means on_each_cpu() again, and the hotplug patch becomes
unnecessary (except to support hotplug, of course).
Assuming I understand things correctly, which if not at all certain.
--
error compiling committee.c: too many arguments to function
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: "Rafael J. Wysocki" <rjw-KKrjLPT3xs0@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
akpm-3NddpPZAyC0@public.gmane.org,
nigel-MhVfhJ0qHmuWn91e4EydUaxOck334EZe@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 5/5] KVM: Host suspend/resume support
Date: Wed, 31 Jan 2007 11:07:01 +0200 [thread overview]
Message-ID: <45C05C35.9040107@qumranet.com> (raw)
In-Reply-To: <200701302319.10369.rjw-KKrjLPT3xs0@public.gmane.org>
Rafael J. Wysocki wrote:
> On Tuesday, 30 January 2007 22:20, Nigel Cunningham wrote:
>
>> Hi.
>>
>> On Tue, 2007-01-30 at 14:57 +0000, Avi Kivity wrote:
>>
>>> Add the necessary callbacks to suspend and resume a host running kvm. This
>>> is just a repeat of the cpu hotplug/unplug work.
>>>
>>> Signed-off-by: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
>>>
>> Maybe it's just a lack of understanding, but I'm wondering if this patch
>> is necessary - we already hot-unplug secondary cpus prior to suspending
>> devices.
>>
>
>
The on_each_cpu() in the patch really means on_this_cpu().
> Not with the reoredering patches that are in -mm, though. With these patches,
> the nonboot CPUs are disabled after "regular" devices.
>
After that, it means on_each_cpu() again, and the hotplug patch becomes
unnecessary (except to support hotplug, of course).
Assuming I understand things correctly, which if not at all certain.
--
error compiling committee.c: too many arguments to function
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
next prev parent reply other threads:[~2007-01-31 9:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-30 14:52 [PATCH 0/5] KVM: suspend/resume support Avi Kivity
2007-01-30 14:52 ` Avi Kivity
2007-01-30 14:53 ` [PATCH 1/5] hotplug: Allow modules to use the cpu hotplug notifiers even if !CONFIG_HOTPLUG_CPU Avi Kivity
2007-01-30 14:54 ` [PATCH 2/5] KVM: Add a global list of all virtual machines Avi Kivity
2007-01-30 14:55 ` [PATCH 3/5] KVM: VMX: add vcpu_clear() Avi Kivity
2007-01-30 14:56 ` [PATCH 4/5] KVM: cpu hotplug support Avi Kivity
2007-01-31 0:48 ` Andrew Morton
2007-01-31 0:48 ` Andrew Morton
2007-01-31 8:50 ` Ingo Molnar
2007-01-31 8:50 ` Ingo Molnar
2007-01-31 11:04 ` Avi Kivity
2007-01-30 14:57 ` [PATCH 5/5] KVM: Host suspend/resume support Avi Kivity
2007-01-30 14:57 ` Avi Kivity
2007-01-30 21:20 ` Nigel Cunningham
2007-01-30 22:19 ` Rafael J. Wysocki
2007-01-30 22:19 ` Rafael J. Wysocki
2007-01-31 0:42 ` Nigel Cunningham
2007-01-31 0:42 ` Nigel Cunningham
2007-01-31 9:07 ` Avi Kivity [this message]
2007-01-31 9:07 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45C05C35.9040107@qumranet.com \
--to=avi@qumranet.com \
--cc=akpm@osdl.org \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nigel@nigel.suspend2.net \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.