From: Larry Finger <larry.finger@lwfinger.net>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Michael Buesch <mb@bu3sch.de>,
netdev@vger.kernel.org, Bcm43xx-dev@lists.berlios.de,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] bcm43xx: Fix for oops on resume
Date: Wed, 07 Feb 2007 07:50:40 -0600 [thread overview]
Message-ID: <45C9D930.5010307@lwfinger.net> (raw)
In-Reply-To: <1170855150.6798.38.camel@johannes.berg>
Johannes Berg wrote:
> On Wed, 2007-02-07 at 07:23 -0600, Larry Finger wrote:
>
>> As you suggested earlier, a slow clock setting in the bcm43xx device may be the cause of this
>> difficulty. If my laptop would suspend/resume correctly, then I could test various fixes based on
>> that hypothesis.
>
> Mine does suspend, but I don't see the problem...
Could you please apply this patch and tell me what gets printed after you resume, and whether you
did a suspend to RAM or disk?
I welcome the results of this test from anyone whose system will suspend/resume. Please also note if
any further action is needed to get wireless communication re-established.
Thanks,
Larry
==========
Index: linux-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c
===================================================================
--- linux-2.6.orig/drivers/net/wireless/bcm43xx/bcm43xx_main.c
+++ linux-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c
@@ -2401,6 +2401,7 @@ static int bcm43xx_chip_init(struct bcm4
}
udelay(10);
}
+ dprintk(KERN_INFO PFX "It took %d tries to set IRQ_READY\n", i);
bcm43xx_read32(bcm, BCM43xx_MMIO_GEN_IRQ_REASON); /* dummy read */
value16 = bcm43xx_shm_read16(bcm, BCM43xx_SHM_SHARED,
WARNING: multiple messages have this Message-ID (diff)
From: Larry Finger <larry.finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
To: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
Cc: Michael Buesch <mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Bcm43xx-dev-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] bcm43xx: Fix for oops on resume
Date: Wed, 07 Feb 2007 07:50:40 -0600 [thread overview]
Message-ID: <45C9D930.5010307@lwfinger.net> (raw)
In-Reply-To: <1170855150.6798.38.camel-YfaajirXv214zXjbi5bjpg@public.gmane.org>
Johannes Berg wrote:
> On Wed, 2007-02-07 at 07:23 -0600, Larry Finger wrote:
>
>> As you suggested earlier, a slow clock setting in the bcm43xx device may be the cause of this
>> difficulty. If my laptop would suspend/resume correctly, then I could test various fixes based on
>> that hypothesis.
>
> Mine does suspend, but I don't see the problem...
Could you please apply this patch and tell me what gets printed after you resume, and whether you
did a suspend to RAM or disk?
I welcome the results of this test from anyone whose system will suspend/resume. Please also note if
any further action is needed to get wireless communication re-established.
Thanks,
Larry
==========
Index: linux-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c
===================================================================
--- linux-2.6.orig/drivers/net/wireless/bcm43xx/bcm43xx_main.c
+++ linux-2.6/drivers/net/wireless/bcm43xx/bcm43xx_main.c
@@ -2401,6 +2401,7 @@ static int bcm43xx_chip_init(struct bcm4
}
udelay(10);
}
+ dprintk(KERN_INFO PFX "It took %d tries to set IRQ_READY\n", i);
bcm43xx_read32(bcm, BCM43xx_MMIO_GEN_IRQ_REASON); /* dummy read */
value16 = bcm43xx_shm_read16(bcm, BCM43xx_SHM_SHARED,
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2007-02-07 13:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-06 17:39 [PATCH] bcm43xx: Fix for oops on resume Larry Finger
2007-02-06 17:39 ` Larry Finger
2007-02-07 12:15 ` Johannes Berg
2007-02-07 12:15 ` Johannes Berg
2007-02-07 13:23 ` Larry Finger
2007-02-07 13:32 ` Johannes Berg
2007-02-07 13:32 ` Johannes Berg
2007-02-07 13:50 ` Larry Finger [this message]
2007-02-07 13:50 ` Larry Finger
2007-02-07 13:54 ` Johannes Berg
2007-02-07 13:54 ` Johannes Berg
2007-02-07 13:56 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45C9D930.5010307@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=Bcm43xx-dev@lists.berlios.de \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.