From: walter harms <wharms@bfs.de>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] BIT macro cleanup
Date: Thu, 08 Feb 2007 08:19:21 +0000 [thread overview]
Message-ID: <45CADD09.70809@bfs.de> (raw)
Milind Choudhary wrote:
> Hi all
>
> I would like to take up the BIT macro cleanup.
> http://www.fsdev.net/wiki/index.php?title=BIT
>
> I think include/linux/bitops.h would be the best place to add the BIT macro.
> Let me know if this is fine.
>
sounds obvious
> There are different variants of BIT using (long|unsigned
> long|unsigned|unsigned char) etc.
> Do we need to create different macros for each type
> Or a single one which takes type as input?
bit operations make only sense on integer, so why not stay with long
and cast it down if needed ? so you have only one function doing so.
please what ever you do do not forget to document that and write some
examples. the linux kernal is large and imho the bigest problem is that
the programmers do not know what nice supportfunctions are available.
my 2 cents,
walter
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
next reply other threads:[~2007-02-08 8:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-08 8:19 walter harms [this message]
2007-02-09 17:45 ` [KJ] BIT macro cleanup Milind Choudhary
2007-02-09 17:55 ` Jaco Kroon
2007-02-20 18:28 ` Milind Choudhary
2007-02-20 19:33 ` Richard Knutsson
2007-02-20 20:30 ` Milind Choudhary
2007-02-21 5:56 ` Richard Knutsson
2007-02-21 9:24 ` Milind Choudhary
2007-02-21 9:39 ` Richard Knutsson
2007-02-21 10:46 ` Milind Choudhary
2007-02-21 11:28 ` Richard Knutsson
2007-02-21 11:59 ` Richard Knutsson
2007-02-21 12:02 ` Darren Jenkins
2007-02-21 12:04 ` Darren Jenkins
2007-02-21 13:26 ` Milind Choudhary
2007-02-21 14:02 ` Milind Choudhary
2007-02-21 14:45 ` Håkon Løvdal
2007-02-21 16:07 ` Richard Knutsson
-- strict thread matches above, loose matches on Subject: below --
2007-02-07 15:30 Milind Choudhary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45CADD09.70809@bfs.de \
--to=wharms@bfs.de \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.