All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Knutsson <ricknu-0@student.ltu.se>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] BIT macro cleanup
Date: Tue, 20 Feb 2007 19:33:12 +0000	[thread overview]
Message-ID: <45DB4CF8.5060409@student.ltu.se> (raw)
In-Reply-To: <45CADD09.70809@bfs.de>

Milind Choudhary wrote:
> ./drivers/net/s2io.h:17:
> #define BIT(loc)                (0x8000000000000000ULL >> (loc))
>   
[snip]
> third one is close to our BIT...but defines the bit position in reverse order
> thought of moving it to bitops.h with name BITREV..
> wouldn't it be mistaken for bit reversal?
> suggest a name plz.
>   
What about just delete that definition and fix those who uses it to"our" 
BIT? (since it is always 64 bits it should be BIT(63 - x), right?)

Richard Knutsson

PS
BTW, how is BIT() supposed to be defined? Is it:

#define BIT(x)	(1ULL << (x))


_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

  parent reply	other threads:[~2007-02-20 19:33 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-08  8:19 [KJ] BIT macro cleanup walter harms
2007-02-09 17:45 ` Milind Choudhary
2007-02-09 17:55 ` Jaco Kroon
2007-02-20 18:28 ` Milind Choudhary
2007-02-20 19:33 ` Richard Knutsson [this message]
2007-02-20 20:30 ` Milind Choudhary
2007-02-21  5:56 ` Richard Knutsson
2007-02-21  9:24 ` Milind Choudhary
2007-02-21  9:39 ` Richard Knutsson
2007-02-21 10:46 ` Milind Choudhary
2007-02-21 11:28 ` Richard Knutsson
2007-02-21 11:59 ` Richard Knutsson
2007-02-21 12:02 ` Darren Jenkins
2007-02-21 12:04 ` Darren Jenkins
2007-02-21 13:26 ` Milind Choudhary
2007-02-21 14:02 ` Milind Choudhary
2007-02-21 14:45 ` Håkon Løvdal
2007-02-21 16:07 ` Richard Knutsson
  -- strict thread matches above, loose matches on Subject: below --
2007-02-07 15:30 Milind Choudhary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45DB4CF8.5060409@student.ltu.se \
    --to=ricknu-0@student.ltu.se \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.