Re: [KJ] BIT macro cleanup

[Richard Knutsson <ricknu-0@student.ltu.se>]

Milind Choudhary wrote:
> there are some setbit & resetbit macros scattered here n there
> e.g.
> ./drivers/net/irda/Via-ircc.h
>
> #define SetBit(val,bit)  val= (unsigned char ) (val | (0x1 << bit))
> // Sets bit to 1
> #define ResetBit(val,bit) val= (unsigned char ) (val & ~(0x1 << bit))
> // Sets bit to 0
>
> if we move these somewhere near BIT
>
> #define SETBIT(data,mask)    (data |= mask)
> #define RESETBIT(data,mask)    (data &= ~mask)
Sounds good! But I think Håkon got a point, both on RESET -> CLEAR and 
that mask can be more then one bit.
>
> usually the mask would be generated with BIT
>
> we can use the new ones to get rid of above code
> by using "cr" as data &  "uartbit" as mask
>
> what say
Mmm, so what about this?
(This I actually compile-tested ;) (after removing <asm/sizes.h> and 
defining SZ_4K))

	(mctrl & TIOCM_RTS)  ?
		SETBITS(cr, UART011_CR_DTR)  : CLRBITS(cr, UART011_CR_DTR);
	(mctrl & TIOCM_DTR)  ?
		SETBITS(cr, UART011_CR_DTR)  : CLRBITS(cr, UART011_CR_DTR);
	(mctrl & TIOCM_OUT1) ?
		SETBITS(cr, UART011_CR_OUT1) : CLRBITS(cr, UART011_CR_OUT1);
	(mctrl & TIOCM_OUT2) ?
		SETBITS(cr, UART011_CR_OUT2) : CLRBITS(cr, UART011_CR_OUT2);
	(mctrl & TIOCM_LOOP) ?
		SETBITS(cr, UART011_CR_LBE)  : CLRBITS(cr, UART011_CR_LBE);


(I just set them to SETBITS and CLRBITS 'cause I think it looks alright)

Richard Knutsson

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors