From: "Jan Beulich" <jbeulich@novell.com>
To: Mark Langsdorf <mark.langsdorf@amd.com>
Cc: xen-devel@lists.xensource.com, Keir Fraser <keir@xensource.com>
Subject: RE: [PATCH] Make x86_64 swiotlb code to support dma_ops [2/2]
Date: Thu, 01 Mar 2007 08:05:01 +0000 [thread overview]
Message-ID: <45E6973D.76E4.0078.0@novell.com> (raw)
In-Reply-To: <1449F58C868D8D4E9C72945771150BDFD9668F@SAUSEXMB1.amd.com>
>> I'm not sure how far we'll need to deviate -- I
>> suspect we'll end up with a file that look much like the
>> i386/pci-dma-xen.c
>> but with calls to swiotlb_xxx() replaced with dma_ops->xxx.
>> Maybe we could
>> even stick with just i386/pci-dma-xen.c and macro up the uses of
>> swiotlb_xxx() (so that they can be replaced with uses of
>> dma_ops->xxx for x86/64 by cpp).
>
>Given that pci-dma-xen for x86_64 is always going to have
>most of the functions replaced by either SWIOTLB or an
>IOMMU, would it be sufficient to copy the (known good)
>implementations of dma_alloc_coherent() from the i386
>version?
That is what I would have preferred from the beginning. I just didn't
complain because native lib/swiotlb.c also has these, and I think
they're not very difficult to fix (and also because I was afraid I
already complained about too many other things).
Jan
prev parent reply other threads:[~2007-03-01 8:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-28 20:17 [PATCH] Make x86_64 swiotlb code to support dma_ops [2/2] Langsdorf, Mark
2007-02-28 21:23 ` Keir Fraser
2007-02-28 21:35 ` Langsdorf, Mark
2007-02-28 21:43 ` Keir Fraser
2007-02-28 22:19 ` Langsdorf, Mark
2007-03-01 8:05 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45E6973D.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=keir@xensource.com \
--cc=mark.langsdorf@amd.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.