From: Keir Fraser <keir@xensource.com>
To: "Langsdorf, Mark" <mark.langsdorf@amd.com>,
xen-devel@lists.xensource.com
Subject: Re: [PATCH] Make x86_64 swiotlb code to support dma_ops [2/2]
Date: Wed, 28 Feb 2007 21:23:40 +0000 [thread overview]
Message-ID: <C20BA35C.3094%keir@xensource.com> (raw)
In-Reply-To: <1449F58C868D8D4E9C72945771150BDFD96682@SAUSEXMB1.amd.com>
On 28/2/07 20:17, "Langsdorf, Mark" <mark.langsdorf@amd.com> wrote:
> The first patch creates the arch/x86_64/kernel/pci-dma-xen.c
> file based on the standard pci-dma.c, and creates
> arch/x86_64/kernel/swiotlb-xen.c based on
> arch/i386/kernel/swiotlb.c.
Do we really need to duplicate the swiotlb code? Did you need to make big
changes?
Other points that I can see from a quick browse include the fact that
alloc_coherent() still looks broken afaics and the one-liner in
io_apic-xen.c is a bit random (since none of the other use-iommu-or-not
decision points are changed, and the GART stuff which is presumably what is
being kludged around is not even included in Xen builds yet).
-- Keir
next prev parent reply other threads:[~2007-02-28 21:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-28 20:17 [PATCH] Make x86_64 swiotlb code to support dma_ops [2/2] Langsdorf, Mark
2007-02-28 21:23 ` Keir Fraser [this message]
2007-02-28 21:35 ` Langsdorf, Mark
2007-02-28 21:43 ` Keir Fraser
2007-02-28 22:19 ` Langsdorf, Mark
2007-03-01 8:05 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C20BA35C.3094%keir@xensource.com \
--to=keir@xensource.com \
--cc=mark.langsdorf@amd.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.