From: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>
To: Shane <ibm-main@tpg.com.au>
Cc: riel@redhat.com, vatsa@in.ibm.com,
ckrm-tech@lists.sourceforge.net, balbir@in.ibm.com,
linux-kernel@vger.kernel.org, xemul@sw.ru, linux-mm@kvack.org,
menage@google.com, devel@openvz.org, clameter@sgi.com
Subject: Re: [ckrm-tech] [PATCH 3/3][RFC] Containers: Pagecache controller reclaim
Date: Wed, 07 Mar 2007 17:28:18 +0530 [thread overview]
Message-ID: <45EEA8DA.6060006@linux.vnet.ibm.com> (raw)
In-Reply-To: <1173258239.4998.79.camel@localhost.localdomain>
Shane wrote:
> On Tue, 2007-03-06 at 16:43 +0530, Vaidyanathan Srinivasan wrote:
>> Please let me know if so see any problem running the patch. The
>> patches are against 2.6.20 only since dependent patches are at that level.
>
> My problem - a bad copy of the patch. It patches o.k.
> However, it fails to compile vmscan. This looks a bit dodgy;
>
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>
> @@ -1470,11 +1494,13 @@ unsigned long shrink_all_memory(unsigned
> int pass;
> struct reclaim_state reclaim_state;
> struct scan_control sc = {
> - .gfp_mask = GFP_KERNEL,
> + .gfp_mask = GFdefined(CONFIG_CONTAINER_PAGECACHE_ACCT)
> +P_KERNEL,
>
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>
> I deleted what looks like an over-enthusiastic "copy-and-paste", and it
> compiled o.k.
> Testing continues.
OOPS!! How did it get there! That is certainly some random mouse
click. Thanks for pointing that out.
--Vaidy
WARNING: multiple messages have this Message-ID (diff)
From: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>
To: Shane <ibm-main@tpg.com.au>
Cc: riel@redhat.com, vatsa@in.ibm.com,
ckrm-tech@lists.sourceforge.net, balbir@in.ibm.com,
linux-kernel@vger.kernel.org, xemul@sw.ru, linux-mm@kvack.org,
menage@google.com, devel@openvz.org, clameter@sgi.com
Subject: Re: [ckrm-tech] [PATCH 3/3][RFC] Containers: Pagecache controller reclaim
Date: Wed, 07 Mar 2007 17:28:18 +0530 [thread overview]
Message-ID: <45EEA8DA.6060006@linux.vnet.ibm.com> (raw)
In-Reply-To: <1173258239.4998.79.camel@localhost.localdomain>
Shane wrote:
> On Tue, 2007-03-06 at 16:43 +0530, Vaidyanathan Srinivasan wrote:
>> Please let me know if so see any problem running the patch. The
>> patches are against 2.6.20 only since dependent patches are at that level.
>
> My problem - a bad copy of the patch. It patches o.k.
> However, it fails to compile vmscan. This looks a bit dodgy;
>
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>
> @@ -1470,11 +1494,13 @@ unsigned long shrink_all_memory(unsigned
> int pass;
> struct reclaim_state reclaim_state;
> struct scan_control sc = {
> - .gfp_mask = GFP_KERNEL,
> + .gfp_mask = GFdefined(CONFIG_CONTAINER_PAGECACHE_ACCT)
> +P_KERNEL,
>
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>
> I deleted what looks like an over-enthusiastic "copy-and-paste", and it
> compiled o.k.
> Testing continues.
OOPS!! How did it get there! That is certainly some random mouse
click. Thanks for pointing that out.
--Vaidy
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-03-07 11:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-05 14:52 [PATCH 0/3][RFC] Containers: Pagecache accounting and control subsystem (v1) Vaidyanathan Srinivasan
2007-03-05 14:52 ` [PATCH 1/3][RFC] Containers: Pagecache controller setup Vaidyanathan Srinivasan
2007-03-05 14:52 ` [PATCH 2/3][RFC] Containers: Pagecache controller accounting Vaidyanathan Srinivasan
2007-03-05 14:52 ` [PATCH 3/3][RFC] Containers: Pagecache controller reclaim Vaidyanathan Srinivasan
2007-03-06 10:50 ` [ckrm-tech] " Shane
2007-03-06 10:50 ` Shane
2007-03-06 11:13 ` Vaidyanathan Srinivasan
2007-03-06 11:13 ` Vaidyanathan Srinivasan
2007-03-07 9:03 ` Shane
2007-03-07 9:03 ` Shane
2007-03-07 11:58 ` Vaidyanathan Srinivasan [this message]
2007-03-07 11:58 ` Vaidyanathan Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45EEA8DA.6060006@linux.vnet.ibm.com \
--to=svaidy@linux.vnet.ibm.com \
--cc=balbir@in.ibm.com \
--cc=ckrm-tech@lists.sourceforge.net \
--cc=clameter@sgi.com \
--cc=devel@openvz.org \
--cc=ibm-main@tpg.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=menage@google.com \
--cc=riel@redhat.com \
--cc=vatsa@in.ibm.com \
--cc=xemul@sw.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.