[patch 00/11] Autotool support for IBM RT Cases

[patch 00/11] Autotool support for IBM RT Cases

[Robert Schwebel]

Darren,

Here is a first raw cut for autotool support for your rt testcases. It
is against the version on your website. The series survives a basic
distcheck.

Known issues & discussion points:

- test programs which use pthread_mutexattr_setprotocol and
  pthread_mutexattr_setrobust_np could not be tested (debian unstable
  does not have a recent enough glibc)

- due to the above, I assume the tests in question will have a similar
  quantity of warnings, so I see if I can get access to a box which is
  recent enough to do the rest of the fixes.

- a sane version number and contact mail address should be added to
  configure.ac; I've just taken our template here, please adjust
  according to your needs.

Robert
--
 Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de
 Pengutronix - Linux Solutions for Science and Industry
   Handelsregister:  Amtsgericht Hildesheim, HRA 2686
     Hannoversche Str. 2, 31134 Hildesheim, Germany
   Phone: +49-5121-206917-0 |  Fax: +49-5121-206917-9

[patch 01/11] add autotool build files

[Robert Schwebel]

[-- Attachment #1: autotoolize.diff --]
[-- Type: text/plain, Size: 17533 bytes --]

This patch adds the infrastructure for autotoolization.

Signed-off-by: Robert Schwebel <r.schwebel@pengutronix.de>

 GNUmakefile.am                               |   32 +++++++++
 autogen.sh                                   |   23 ++++++
 config/GNUmakefile.am                        |    3
 config/m4/.secret-world-domination-project   |    2
 configure.ac                                 |   95 +++++++++++++++++++++++++++
 examples/GNUmakefile.am                      |   15 ++++
 examples/Makefile                            |    8 --
 func/GNUmakefile.am                          |   13 +++
 func/measurement/GNUmakefile.am              |   30 ++++++++
 func/measurement/gtod_latency/GNUmakefile.am |   23 ++++++
 func/pi-tests/GNUmakefile.am                 |   48 +++++++++++++
 func/prio-preempt/GNUmakefile.am             |   18 +++++
 func/prio-wake/GNUmakefile.am                |   18 +++++
 func/pthread_kill_latency/GNUmakefile.am     |   19 +++++
 func/sched_football/GNUmakefile.am           |   18 +++++
 func/sched_latency/GNUmakefile.am            |   18 +++++
 func/thread_clock/GNUmakefile.am             |   16 ++++
 func/winc/GNUmakefile.am                     |   22 ++++++
 include/GNUmakefile.am                       |    8 ++
 include/rttests_config.h.in                  |   94 ++++++++++++++++++++++++++
 logs/GNUmakefile.am                          |    3
 perf/GNUmakefile.am                          |    5 +
 perf/latency/GNUmakefile.am                  |   20 +++++
 scripts/GNUmakefile.am                       |    3
 stress/GNUmakefile.am                        |    6 +
 stress/pi-tests/GNUmakefile.am               |   23 ++++++
 26 files changed, 575 insertions(+), 8 deletions(-)

Index: autogen.sh
===================================================================
--- /dev/null
+++ autogen.sh
@@ -0,0 +1,23 @@
+#!/bin/bash
+
+#
+# usage:
+#
+# banner <target name>
+#
+banner() {
+	echo
+	TG=`echo $1 | sed -e "s,/.*/,,g"`
+	LINE=`echo $TG |sed -e "s/./-/g"`
+	echo $LINE
+	echo $TG
+	echo $LINE
+	echo
+}
+
+banner "autoreconf"
+
+autoreconf --force --install --symlink -Wall || exit $?
+rm -f include/rttests_config.h.in~
+
+banner "Finished"
Index: config/GNUmakefile.am
===================================================================
--- /dev/null
+++ config/GNUmakefile.am
@@ -0,0 +1,3 @@
+MAINTAINERCLEANFILES = \
+	GNUmakefile.in
+
Index: configure.ac
===================================================================
--- /dev/null
+++ configure.ac
@@ -0,0 +1,95 @@
+# -*- Autoconf -*-
+# Process this file with autoconf to produce a configure script.
+AC_PREREQ(2.59)
+
+AC_INIT([rttests], [0.0.0], [bugs@pengutronix.de])
+AC_CONFIG_HEADERS([include/rttests_config.h])
+AC_CONFIG_SRCDIR([examples/libstats_test.c])
+AC_CONFIG_MACRO_DIR([config/m4])
+AC_CONFIG_AUX_DIR([config/autoconf])
+AC_CANONICAL_BUILD
+AC_CANONICAL_HOST
+
+AM_MAINTAINER_MODE
+
+CFLAGS="${CFLAGS} -Wall"
+
+AM_INIT_AUTOMAKE([foreign no-exeext dist-bzip2])
+
+#
+# Checks for header files.
+#
+AC_HEADER_DIRENT
+AC_HEADER_STDC
+AC_HEADER_SYS_WAIT
+dnl AC_CHECK_HEADERS([limits.h])
+
+
+#
+# Checks for typedefs, structures, and compiler characteristics.
+#
+AC_C_CONST
+AC_C_INLINE
+AC_TYPE_SIZE_T
+AC_HEADER_TIME
+
+
+#
+# Checks for library functions.
+#
+
+AC_CHECK_FUNCS([pthread_mutexattr_setprotocol])
+AM_CONDITIONAL(
+    [HAVE_PTHREAD_MUTEXATTR_SETPROTOCOL],
+    [test "$ac_cv_func_pthread_mutexattr_setprotocol" = "yes"])
+
+AC_CHECK_FUNCS([pthread_mutexattr_setrobust_np])
+AM_CONDITIONAL(
+    [HAVE_PTHREAD_MUTEXATTR_SETROBUST_NP],
+    [test "$ac_cv_func_pthread_mutexattr_setrobust_np" = "yes"])
+
+#
+# Debugging
+#
+AC_MSG_CHECKING([whether to enable debugging])
+AC_ARG_ENABLE(debug,
+    AS_HELP_STRING([--enable-debug], [enable debugging @<:@default=yes@:>@]),
+	[case "$enableval" in
+	y | yes) CONFIG_DEBUG=yes ;;
+        *) CONFIG_DEBUG=no ;;
+    esac],
+    [CONFIG_DEBUG=yes])
+AC_MSG_RESULT([${CONFIG_DEBUG}])
+if test "${CONFIG_DEBUG}" = "yes"; then
+    CFLAGS="${CFLAGS} -Werror -Wsign-compare -Wfloat-equal -Wformat-security -g -O1"
+    AC_DEFINE(DEBUG, 1, [debugging])
+else
+    CFLAGS="${CFLAGS} -O2"
+fi
+
+
+AC_CONFIG_FILES([
+	GNUmakefile
+	config/GNUmakefile
+	include/GNUmakefile
+	examples/GNUmakefile
+	func/GNUmakefile
+	func/measurement/GNUmakefile
+	func/measurement/gtod_latency/GNUmakefile
+	func/pi-tests/GNUmakefile
+	func/prio-preempt/GNUmakefile
+	func/prio-wake/GNUmakefile
+	func/pthread_kill_latency/GNUmakefile
+	func/sched_football/GNUmakefile
+	func/sched_latency/GNUmakefile
+	func/thread_clock/GNUmakefile
+	func/winc/GNUmakefile
+	logs/GNUmakefile
+	perf/GNUmakefile
+	perf/latency/GNUmakefile
+	scripts/GNUmakefile
+	stress/GNUmakefile
+	stress/pi-tests/GNUmakefile
+	])
+AC_OUTPUT
+
Index: examples/GNUmakefile.am
===================================================================
--- /dev/null
+++ examples/GNUmakefile.am
@@ -0,0 +1,15 @@
+bin_PROGRAMS = libstats_test
+
+AM_CPPFLAGS = \
+	-I$(top_srcdir)/include \
+	-I$(top_builddir)/include
+
+libstats_test_CFLAGS = \
+	-O3
+
+libstats_test_LDADD = \
+	-lm
+
+MAINTAINERCLEANFILES = \
+	GNUmakefile.in
+
Index: func/GNUmakefile.am
===================================================================
--- /dev/null
+++ func/GNUmakefile.am
@@ -0,0 +1,13 @@
+SUBDIRS = \
+	measurement \
+	pi-tests \
+	prio-preempt \
+	prio-wake \
+	pthread_kill_latency \
+	sched_football \
+	sched_latency \
+	thread_clock \
+	winc
+
+MAINTAINERCLEANFILES = \
+	GNUmakefile.in
Index: func/measurement/GNUmakefile.am
===================================================================
--- /dev/null
+++ func/measurement/GNUmakefile.am
@@ -0,0 +1,30 @@
+SUBDIRS = \
+	gtod_latency
+
+bin_PROGRAMS = \
+	preempt_timing \
+	rdtsc-latency
+
+AM_CPPFLAGS = \
+	-I$(top_srcdir)/include \
+	-I$(top_builddir)/include \
+	-I$(DESTDIR)/usr/include/nptl
+
+preempt_timing_CFLAGS = \
+	-O2 \
+	-D_GNU_SOURCE
+
+# preempt_timing_LDADD = \
+#	-L$(DESTDIR)/usr/lib/nptl \
+#	-lpthread -lrt -lm
+
+rdtsc_latency_CFLAGS = \
+	-O2
+
+#rdtsc_latency_LDADD = \
+#	-L$(DESTDIR)/usr/lib/nptl \
+#	-lpthread -lrt -lm
+
+MAINTAINERCLEANFILES = \
+	GNUmakefile.in
+
Index: func/measurement/gtod_latency/GNUmakefile.am
===================================================================
--- /dev/null
+++ func/measurement/gtod_latency/GNUmakefile.am
@@ -0,0 +1,23 @@
+bin_PROGRAMS = \
+	gtod_latency \
+	gtod_infinite
+
+AM_CPPFLAGS = \
+	-I$(top_srcdir)/include \
+	-I$(top_builddir)/include
+
+gtod_latency_CFLAGS = \
+	-O2
+
+gtod_latency_LDADD = \
+	-lm
+
+gtod_infinite_CFLAGS = \
+	-O2
+
+gtod_infinite_LDADD = \
+	-lrt
+
+MAINTAINERCLEANFILES = \
+	GNUmakefile.in
+
Index: func/pi-tests/GNUmakefile.am
===================================================================
--- /dev/null
+++ func/pi-tests/GNUmakefile.am
@@ -0,0 +1,48 @@
+bin_PROGRAMS = \
+	testpi-0
+
+if HAVE_PTHREAD_MUTEXATTR_SETPROTOCOL
+bin_PROGRAMS += \
+	testpi-1 \
+	testpi-2 \
+	testpi-4 \
+	testpi-5 \
+	testpi-7
+endif
+
+if HAVE_PTHREAD_MUTEXATTR_SETROBUST_NP
+bin_PROGRAMS += \
+	testpi-6 \
+	sbrk_mutex
+endif
+
+AM_CPPFLAGS = \
+	-I$(top_srcdir)/include \
+	-I$(top_builddir)/include \
+	-I$(DESTDIR)/usr/include/nptl
+
+AM_CFLAGS = \
+	-O2
+
+AM_LDFLAGS = \
+	-L$(DESTDIR)/usr/lib/nptl
+
+testpi_0_CPPFLAGS = \
+	-D_GNU_SOURCE
+
+testpi_1_CPPFLAGS = \
+	-D_GNU_SOURCE
+
+testpi_2_CPPFLAGS = \
+	-D_GNU_SOURCE
+
+testpi_4_CPPFLAGS = \
+	-D_GNU_SOURCE
+
+MAINTAINERCLEANFILES = \
+	GNUmakefile.in
+
+
+# CFLAGS=-O2 -g -Wall -D_GNU_SOURCE -I/usr/include/nptl -I ../../include
+# LDFLAGS=-L/usr/lib/nptl -lpthread -lrt -lm
+
Index: func/prio-preempt/GNUmakefile.am
===================================================================
--- /dev/null
+++ func/prio-preempt/GNUmakefile.am
@@ -0,0 +1,18 @@
+if HAVE_PTHREAD_MUTEXATTR_SETPROTOCOL
+bin_PROGRAMS = prio-preempt
+endif
+
+AM_CPPFLAGS = \
+	-I$(top_srcdir)/include \
+	-I$(top_builddir)/include \
+	-I$(DESTDIR)/usr/include/nptl
+
+prio_preempt_CFLAGS = \
+	-O2
+
+#prio_preempt_LDADD = \
+#	-lpthread -lrt -lm
+
+MAINTAINERCLEANFILES = \
+	GNUmakefile.in
+
Index: func/prio-wake/GNUmakefile.am
===================================================================
--- /dev/null
+++ func/prio-wake/GNUmakefile.am
@@ -0,0 +1,18 @@
+if HAVE_PTHREAD_MUTEXATTR_SETPROTOCOL
+bin_PROGRAMS = prio-wake
+endif
+
+AM_CPPFLAGS = \
+	-I$(top_srcdir)/include \
+	-I$(top_builddir)/include \
+	-I$(DESTDIR)/usr/include/nptl
+
+prio_wake_CFLAGS = \
+	-O2
+
+prio_wake_LDADD = \
+	-lpthread -lrt -lm
+
+MAINTAINERCLEANFILES = \
+	GNUmakefile.in
+
Index: func/pthread_kill_latency/GNUmakefile.am
===================================================================
--- /dev/null
+++ func/pthread_kill_latency/GNUmakefile.am
@@ -0,0 +1,19 @@
+if HAVE_PTHREAD_MUTEXATTR_SETPROTOCOL
+bin_PROGRAMS = pthread_kill_latency
+endif
+
+AM_CPPFLAGS = \
+	-I$(top_srcdir)/include \
+	-I$(top_builddir)/include \
+	-I$(DESTDIR)/usr/include/nptl
+
+pthread_kill_latency_CFLAGS = \
+	-O2 \
+	-D_GNU_SOURCE
+
+#pthread_kill_latency_LDADD = \
+#	-lpthread -lrt -lm
+
+MAINTAINERCLEANFILES = \
+	GNUmakefile.in
+
Index: func/sched_football/GNUmakefile.am
===================================================================
--- /dev/null
+++ func/sched_football/GNUmakefile.am
@@ -0,0 +1,18 @@
+#if HAVE_PTHREAD_MUTEXATTR_SETPROTOCOL
+bin_PROGRAMS = sched_football
+#endif
+
+AM_CPPFLAGS = \
+	-I$(top_srcdir)/include \
+	-I$(top_builddir)/include \
+	-I$(DESTDIR)/usr/include/nptl
+
+sched_football_CFLAGS = \
+	-O3
+
+sched_football_LDADD = \
+	-lpthread
+
+MAINTAINERCLEANFILES = \
+	GNUmakefile.in
+
Index: func/sched_latency/GNUmakefile.am
===================================================================
--- /dev/null
+++ func/sched_latency/GNUmakefile.am
@@ -0,0 +1,18 @@
+if HAVE_PTHREAD_MUTEXATTR_SETPROTOCOL
+bin_PROGRAMS = sched_latency
+endif
+
+AM_CPPFLAGS = \
+	-I$(top_srcdir)/include \
+	-I$(top_builddir)/include \
+	-I$(DESTDIR)/usr/include/nptl
+
+sched_latency_CFLAGS = \
+	-O2
+
+#sched_latency_LDADD = \
+#	-lpthread
+
+MAINTAINERCLEANFILES = \
+	GNUmakefile.in
+
Index: func/thread_clock/GNUmakefile.am
===================================================================
--- /dev/null
+++ func/thread_clock/GNUmakefile.am
@@ -0,0 +1,16 @@
+bin_PROGRAMS = tc-1
+
+AM_CPPFLAGS = \
+	-I$(top_srcdir)/include \
+	-I$(top_builddir)/include \
+	-I$(DESTDIR)/usr/include/nptl
+
+tc_1_CFLAGS = \
+	-O2
+
+tc_1_LDADD = \
+	-lpthread -lrt
+
+MAINTAINERCLEANFILES = \
+	GNUmakefile.in
+
Index: func/winc/GNUmakefile.am
===================================================================
--- /dev/null
+++ func/winc/GNUmakefile.am
@@ -0,0 +1,22 @@
+if HAVE_PTHREAD_MUTEXATTR_SETPROTOCOL
+bin_PROGRAMS = \
+	async_handler
+endif
+
+# async_handler_jk
+
+AM_CPPFLAGS = \
+	-I$(top_srcdir)/include \
+	-I$(top_builddir)/include \
+	-I$(DESTDIR)/usr/include/nptl
+
+async_handler_CFLAGS = \
+	-O2 \
+	-D_GNU_SOURCE
+
+#async_handler_LDADD = \
+#	-lpthread -lrt -lm
+
+MAINTAINERCLEANFILES = \
+	GNUmakefile.in
+
Index: GNUmakefile.am
===================================================================
--- /dev/null
+++ GNUmakefile.am
@@ -0,0 +1,32 @@
+SUBDIRS = \
+	config \
+	examples \
+	func \
+	include \
+	logs \
+	perf \
+	scripts \
+	stress
+
+EXTRA_DIST = \
+	autogen.sh \
+	config/m4/.secret-world-domination-project
+
+MAINTAINERCLEANFILES = \
+	configure \
+	GNUmakefile.in \
+	aclocal.m4 \
+	config/autoconf/compile \
+	config/autoconf/config.guess \
+	config/autoconf/config.sub \
+	config/autoconf/depcomp \
+	config/autoconf/install-sh \
+	config/autoconf/ltmain.sh \
+	config/autoconf/mdate-sh \
+	config/autoconf/missing \
+	config/autoconf/texinfo.tex \
+	config/m4/acx_pthread.m4 \
+	config/m4/libtool.m4 \
+	config/m4/ltoptions.m4 \
+	config/m4/ltsugar.m4 \
+	config/m4/ltversion.m4
Index: include/GNUmakefile.am
===================================================================
--- /dev/null
+++ include/GNUmakefile.am
@@ -0,0 +1,8 @@
+noinst_HEADERS = \
+	libjvmsim.h \
+	librt.h \
+	libstats.h
+
+MAINTAINERCLEANFILES = \
+	GNUmakefile.in
+
Index: include/rttests_config.h.in
===================================================================
--- /dev/null
+++ include/rttests_config.h.in
@@ -0,0 +1,94 @@
+/* include/rttests_config.h.in.  Generated from configure.ac by autoheader.  */
+
+/* debugging */
+#undef DEBUG
+
+/* Define to 1 if you have the <dirent.h> header file, and it defines `DIR'.
+   */
+#undef HAVE_DIRENT_H
+
+/* Define to 1 if you have the <inttypes.h> header file. */
+#undef HAVE_INTTYPES_H
+
+/* Define to 1 if you have the <memory.h> header file. */
+#undef HAVE_MEMORY_H
+
+/* Define to 1 if you have the <ndir.h> header file, and it defines `DIR'. */
+#undef HAVE_NDIR_H
+
+/* Define to 1 if you have the `pthread_mutexattr_setprotocol' function. */
+#undef HAVE_PTHREAD_MUTEXATTR_SETPROTOCOL
+
+/* Define to 1 if you have the `pthread_mutexattr_setrobust_np' function. */
+#undef HAVE_PTHREAD_MUTEXATTR_SETROBUST_NP
+
+/* Define to 1 if you have the <stdint.h> header file. */
+#undef HAVE_STDINT_H
+
+/* Define to 1 if you have the <stdlib.h> header file. */
+#undef HAVE_STDLIB_H
+
+/* Define to 1 if you have the <strings.h> header file. */
+#undef HAVE_STRINGS_H
+
+/* Define to 1 if you have the <string.h> header file. */
+#undef HAVE_STRING_H
+
+/* Define to 1 if you have the <sys/dir.h> header file, and it defines `DIR'.
+   */
+#undef HAVE_SYS_DIR_H
+
+/* Define to 1 if you have the <sys/ndir.h> header file, and it defines `DIR'.
+   */
+#undef HAVE_SYS_NDIR_H
+
+/* Define to 1 if you have the <sys/stat.h> header file. */
+#undef HAVE_SYS_STAT_H
+
+/* Define to 1 if you have the <sys/types.h> header file. */
+#undef HAVE_SYS_TYPES_H
+
+/* Define to 1 if you have <sys/wait.h> that is POSIX.1 compatible. */
+#undef HAVE_SYS_WAIT_H
+
+/* Define to 1 if you have the <unistd.h> header file. */
+#undef HAVE_UNISTD_H
+
+/* Name of package */
+#undef PACKAGE
+
+/* Define to the address where bug reports for this package should be sent. */
+#undef PACKAGE_BUGREPORT
+
+/* Define to the full name of this package. */
+#undef PACKAGE_NAME
+
+/* Define to the full name and version of this package. */
+#undef PACKAGE_STRING
+
+/* Define to the one symbol short name of this package. */
+#undef PACKAGE_TARNAME
+
+/* Define to the version of this package. */
+#undef PACKAGE_VERSION
+
+/* Define to 1 if you have the ANSI C header files. */
+#undef STDC_HEADERS
+
+/* Define to 1 if you can safely include both <sys/time.h> and <time.h>. */
+#undef TIME_WITH_SYS_TIME
+
+/* Version number of package */
+#undef VERSION
+
+/* Define to empty if `const' does not conform to ANSI C. */
+#undef const
+
+/* Define to `__inline__' or `__inline' if that's what the C compiler
+   calls it, or to nothing if 'inline' is not supported under any name.  */
+#ifndef __cplusplus
+#undef inline
+#endif
+
+/* Define to `unsigned int' if <sys/types.h> does not define. */
+#undef size_t
Index: logs/GNUmakefile.am
===================================================================
--- /dev/null
+++ logs/GNUmakefile.am
@@ -0,0 +1,3 @@
+MAINTAINERCLEANFILES = \
+	GNUmakefile.in
+
Index: perf/GNUmakefile.am
===================================================================
--- /dev/null
+++ perf/GNUmakefile.am
@@ -0,0 +1,5 @@
+SUBDIRS = \
+	latency
+
+MAINTAINERCLEANFILES = \
+	GNUmakefile.in
Index: perf/latency/GNUmakefile.am
===================================================================
--- /dev/null
+++ perf/latency/GNUmakefile.am
@@ -0,0 +1,20 @@
+bin_PROGRAMS = \
+	pthread_cond_latency \
+	pthread_cond_many
+
+AM_CPPFLAGS = \
+	-I$(top_srcdir)/include \
+	-I$(top_builddir)/include
+
+AM_CFLAGS = \
+	-O2
+
+pthread_cond_latency_LDADD = \
+	-lpthread
+
+pthread_cond_many_LDADD = \
+	-lpthread
+
+MAINTAINERCLEANFILES = \
+	GNUmakefile.in
+
Index: scripts/GNUmakefile.am
===================================================================
--- /dev/null
+++ scripts/GNUmakefile.am
@@ -0,0 +1,3 @@
+MAINTAINERCLEANFILES = \
+	GNUmakefile.in
+
Index: stress/GNUmakefile.am
===================================================================
--- /dev/null
+++ stress/GNUmakefile.am
@@ -0,0 +1,6 @@
+SUBDIRS = \
+	pi-tests
+
+MAINTAINERCLEANFILES = \
+	GNUmakefile.in
+
Index: stress/pi-tests/GNUmakefile.am
===================================================================
--- /dev/null
+++ stress/pi-tests/GNUmakefile.am
@@ -0,0 +1,23 @@
+if HAVE_PTHREAD_MUTEXATTR_SETPROTOCOL
+bin_PROGRAMS = lookup_pi_state
+endif
+
+#	testpi-3
+
+AM_CPPFLAGS = \
+	-I$(top_srcdir)/include \
+	-I$(top_builddir)/include \
+	-I$(DESTDIR)/usr/include/nptl
+
+AM_CFLAGS = \
+	-O2
+
+#testpi_3_CFLAGS = \
+#	-D_GNU_SOURCE
+
+#testpi_3_LDADD = \
+#	-lpthread -lrt -lm
+
+MAINTAINERCLEANFILES = \
+	GNUmakefile.in
+
Index: config/m4/.secret-world-domination-project
===================================================================
--- /dev/null
+++ config/m4/.secret-world-domination-project
@@ -0,0 +1,2 @@
+
+
Index: examples/Makefile
===================================================================
--- examples/Makefile
+++ /dev/null
@@ -1,8 +0,0 @@
-CFLAGS += -O3 -lm -I../include
-CXXFLAGS += -lm -I../include
-bins = libstats_test
-
-all: ${bins}
-
-clean:
-	rm -f ${bins}

--
 Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de
 Pengutronix - Linux Solutions for Science and Industry
   Handelsregister:  Amtsgericht Hildesheim, HRA 2686
     Hannoversche Str. 2, 31134 Hildesheim, Germany
   Phone: +49-5121-206917-0 |  Fax: +49-5121-206917-9

[patch 02/11] unused variables

[Robert Schwebel]

[-- Attachment #1: libstats-unused-x.diff --]
[-- Type: text/plain, Size: 1096 bytes --]

This fixes an unused variable.

In file included from libstats_test.c:1:
../include/libstats.h:161: warning: unused variable 'x'

Signed-off-by: Robert Schwebel <r.schwebel@pengutronix.de>

 include/libstats.h |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: include/libstats.h
===================================================================
--- include/libstats.h.orig
+++ include/libstats.h
@@ -158,7 +158,7 @@ int stats_hist(stats_container_t *hist, 
 	int i;
 	int ret;
 	long min, max, width;
-	long x, y, b;
+	long /* x, */ y, b;
 	
 	ret = 0;
 
@@ -199,7 +199,7 @@ int stats_hist(stats_container_t *hist, 
 
 void stats_hist_print(stats_container_t *hist)
 {
-	long i, x, x1;
+	long i, x /* , x1 */;
 	for (i = 0; i < hist->size; i++) {
 		x = hist->records[i].x;
 		if (i < hist->size-1)

--
 Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de
 Pengutronix - Linux Solutions for Science and Industry
   Handelsregister:  Amtsgericht Hildesheim, HRA 2686
     Hannoversche Str. 2, 31134 Hildesheim, Germany
   Phone: +49-5121-206917-0 |  Fax: +49-5121-206917-9

[patch 03/11] fix format to use correct types

[Robert Schwebel]

[-- Attachment #1: libstats-format-errors.diff --]
[-- Type: text/plain, Size: 2279 bytes --]

This patch fixes

In file included from libstats_test.c:1:
../include/libstats.h: In function 'stats_hist_print':
../include/libstats.h:207: warning: format '%d' expects type 'int', but argument 2 has type 'long int'
../include/libstats.h:207: warning: format '%d' expects type 'int', but argument 3 has type 'long int'
../include/libstats.h:207: warning: format '%d' expects type 'int', but argument 4 has type 'long int'
../include/libstats.h:209: warning: format '%d' expects type 'int', but argument 2 has type 'long int'
../include/libstats.h:209: warning: format '%d' expects type 'int', but argument 3 has type 'long int'
../include/libstats.h: In function 'stats_container_save':
../include/libstats.h:245: warning: format '%d' expects type 'int', but argument 3 has type 'long int'
../include/libstats.h:245: warning: format '%d' expects type 'int', but argument 4 has type 'long int'
make[1]: *** [libstats_test-libstats_test.o] Error 1

Signed-off-by: Robert Schwebel <r.schwebel@pengutronix.de>

 include/libstats.h |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Index: include/libstats.h
===================================================================
--- include/libstats.h.orig
+++ include/libstats.h
@@ -203,10 +203,10 @@ void stats_hist_print(stats_container_t 
 	for (i = 0; i < hist->size; i++) {
 		x = hist->records[i].x;
 		if (i < hist->size-1)
-			printf("[%d,%d) = %d\n", x, 
+			printf("[%ld,%ld) = %ld\n", x, 
 				hist->records[i+1].x, hist->records[i].y);
 		else
-			printf("[%d,-) = %d\n", x, hist->records[i].y);
+			printf("[%ld,-) = %ld\n", x, hist->records[i].y);
 	}
 }
 
@@ -242,7 +242,7 @@ int stats_container_save(char *filename,
             maxx = MAX(maxx, rec->x);            
             miny = MIN(miny, rec->y);            
             maxy = MAX(maxy, rec->y);            
-            fprintf(dat_fd, "%d %d\n", rec->x, rec->y);
+            fprintf(dat_fd, "%ld %ld\n", rec->x, rec->y);
         }
         fclose(dat_fd);
     } 

--
 Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de
 Pengutronix - Linux Solutions for Science and Industry
   Handelsregister:  Amtsgericht Hildesheim, HRA 2686
     Hannoversche Str. 2, 31134 Hildesheim, Germany
   Phone: +49-5121-206917-0 |  Fax: +49-5121-206917-9

[patch 04/11] Autotool support for IBM RT Cases

[Robert Schwebel]

[-- Attachment #1: libstat-nonvoid-function.diff --]
[-- Type: text/plain, Size: 1253 bytes --]

Subject return something in non-void functions
This fixes

libstats_test.c: In function 'stats_container_free':
../include/libstats.h:107: warning: control reaches end of non-void function
libstats_test.c: In function 'stats_container_init':
../include/libstats.h:102: warning: control reaches end of non-void function

Signed-off-by: Robert Schwebel <r.schwebel@pengutronix.de>

 include/libstats.h |    4 ++++
 1 file changed, 4 insertions(+)

Index: include/libstats.h
===================================================================
--- include/libstats.h.orig
+++ include/libstats.h
@@ -99,11 +99,15 @@ int stats_container_init(stats_container
 	data->size = size;
 	data->records = (stats_record_t *)malloc(size*sizeof(stats_record_t));
 	memset(data->records, 0, size*sizeof(stats_record_t));
+
+        return 0;
 }
 
 int stats_container_free(stats_container_t *data)
 {
 	free(data->records);
+
+        return 0;
 }
 
 float stats_stddev(stats_container_t *data)

--
 Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de
 Pengutronix - Linux Solutions for Science and Industry
   Handelsregister:  Amtsgericht Hildesheim, HRA 2686
     Hannoversche Str. 2, 31134 Hildesheim, Germany
   Phone: +49-5121-206917-0 |  Fax: +49-5121-206917-9

[patch 05/11] ret may be used uninitialized

[Robert Schwebel]

[-- Attachment #1: libstat-maybe-uninitialized.diff --]
[-- Type: text/plain, Size: 1709 bytes --]

This patch fixes a "may be used uninitialized" warning.

Signed-off-by: Robert Schwebel <r.schwebel@pengutronix.de>

 include/libstats.h |    7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

Index: include/libstats.h
===================================================================
--- include/libstats.h.orig
+++ include/libstats.h
@@ -216,7 +216,6 @@ void stats_hist_print(stats_container_t 
 
 int stats_container_save(char *filename, char *title, char *xlabel, char *ylabel, stats_container_t *data, char *mode)
 {
-    int ret;
     int i;
     int minx, maxx, miny, maxy;
     FILE *dat_fd;
@@ -236,7 +235,7 @@ int stats_container_save(char *filename,
     /* generate the data file */
     if (!(dat_fd = fopen(datfile, "w"))) {
         perror("Failed to open dat file");
-        ret = -1;
+        return -1;
     } else {
         minx = maxx = data->records[0].x;
         miny = maxy = data->records[0].y;
@@ -254,7 +253,7 @@ int stats_container_save(char *filename,
     /* generate the plt file */
     if (!(plt_fd = fopen(pltfile, "w"))) {
         perror("Failed to open plt file");
-        ret = -1;
+        return -1;
     } else {
         fprintf(plt_fd, "set terminal png\n");
         fprintf(plt_fd, "set output \"%s.png\"\n", pltfile);
@@ -272,6 +271,6 @@ int stats_container_save(char *filename,
         fclose(plt_fd);
     } 
 
-    return ret;
+    return 0;
 }
 #endif /* LIBSTAT_H */

--
 Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de
 Pengutronix - Linux Solutions for Science and Industry
   Handelsregister:  Amtsgericht Hildesheim, HRA 2686
     Hannoversche Str. 2, 31134 Hildesheim, Germany
   Phone: +49-5121-206917-0 |  Fax: +49-5121-206917-9

[patch 06/11] int main void

[Robert Schwebel]

[-- Attachment #1: func-measurement-gtod-latency-warnings.diff --]
[-- Type: text/plain, Size: 902 bytes --]

Recent compilers barf about incorrect main functions when run with full
warnings switched on.

Signed-off-by: Robert Schwebel <r.schwebel@pengutronix.de>

 func/measurement/gtod_latency/gtod_infinite.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: func/measurement/gtod_latency/gtod_infinite.c
===================================================================
--- func/measurement/gtod_latency/gtod_infinite.c.orig
+++ func/measurement/gtod_latency/gtod_infinite.c
@@ -26,7 +26,7 @@
 #define START_MAX	3000
 #define REPORT_MIN	1000000
 
-main()
+int main(void)
 {
 	int i, rc;
 	struct timespec ts, p_ts;

--
 Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de
 Pengutronix - Linux Solutions for Science and Industry
   Handelsregister:  Amtsgericht Hildesheim, HRA 2686
     Hannoversche Str. 2, 31134 Hildesheim, Germany
   Phone: +49-5121-206917-0 |  Fax: +49-5121-206917-9

[patch 07/11] unused variables

[Robert Schwebel]

[-- Attachment #1: func-measurement-gtod-infinite-warnings.diff --]
[-- Type: text/plain, Size: 986 bytes --]

Comment out unused variables for now (we use -Werror).

Signed-off-by: Robert Schwebel <r.schwebel@pengutronix.de>

 func/measurement/gtod_latency/gtod_infinite.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: func/measurement/gtod_latency/gtod_infinite.c
===================================================================
--- func/measurement/gtod_latency/gtod_infinite.c.orig
+++ func/measurement/gtod_latency/gtod_infinite.c
@@ -28,11 +28,11 @@
 
 int main(void)
 {
-	int i, rc;
+	int /* i, */ rc;
 	struct timespec ts, p_ts;
 	long long s_time, e_time, diff_time;
 	long long max_time = START_MAX;
-	cpu_set_t mask;
+	/* cpu_set_t mask; */
 	struct sched_param param;
 	time_t tt;
 

--
 Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de
 Pengutronix - Linux Solutions for Science and Industry
   Handelsregister:  Amtsgericht Hildesheim, HRA 2686
     Hannoversche Str. 2, 31134 Hildesheim, Germany
   Phone: +49-5121-206917-0 |  Fax: +49-5121-206917-9

[patch 08/11] implicit declarations

[Robert Schwebel]

[-- Attachment #1: perf-latency-pthread-cond-latency-implicit-declarations.diff --]
[-- Type: text/plain, Size: 967 bytes --]

Add some header files to avoid implicit declaration warnings.

Signed-off-by: Robert Schwebel <r.schwebel@pengutronix.de>

 perf/latency/pthread_cond_latency.c |    4 ++++
 1 file changed, 4 insertions(+)

Index: perf/latency/pthread_cond_latency.c
===================================================================
--- perf/latency/pthread_cond_latency.c.orig
+++ perf/latency/pthread_cond_latency.c
@@ -21,9 +21,13 @@
  */
 
 #include <stdio.h>
+#include <stdlib.h>
+#include <poll.h>
 #include <pthread.h>
 #include <sys/time.h>
+#include <sys/types.h>
 #include <sched.h>
+#include <unistd.h>
 
 pthread_mutex_t child_mutex = PTHREAD_MUTEX_INITIALIZER;
 volatile int child_waiting = 0;

--
 Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de
 Pengutronix - Linux Solutions for Science and Industry
   Handelsregister:  Amtsgericht Hildesheim, HRA 2686
     Hannoversche Str. 2, 31134 Hildesheim, Germany
   Phone: +49-5121-206917-0 |  Fax: +49-5121-206917-9

[patch 09/11] return something in non-void functions

[Robert Schwebel]

[-- Attachment #1: perf-latency-pthread-cond-latency-void.diff --]
[-- Type: text/plain, Size: 775 bytes --]

Subject says it all ...

Signed-off-by: Robert Schwebel <r.schwebel@pengutronix.de>

 perf/latency/pthread_cond_latency.c |    2 ++
 1 file changed, 2 insertions(+)

Index: perf/latency/pthread_cond_latency.c
===================================================================
--- perf/latency/pthread_cond_latency.c.orig
+++ perf/latency/pthread_cond_latency.c
@@ -178,4 +178,6 @@ main(int argc, char *argv[])
 	}
 	iter = strtol(argv[1], NULL, 0);
 	test_signal(argc == 2, iter);
+
+	return 0;
 }

--
 Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de
 Pengutronix - Linux Solutions for Science and Industry
   Handelsregister:  Amtsgericht Hildesheim, HRA 2686
     Hannoversche Str. 2, 31134 Hildesheim, Germany
   Phone: +49-5121-206917-0 |  Fax: +49-5121-206917-9

[patch 10/11] return something in non-void functions

[Robert Schwebel]

[-- Attachment #1: perf-latency-pthread-cond-many-void.diff --]
[-- Type: text/plain, Size: 729 bytes --]

Subject says it all ...

Signed-off-by: Robert Schwebel <r.schwebel@pengutronix.de>

 perf/latency/pthread_cond_many.c |    2 ++
 1 file changed, 2 insertions(+)

Index: perf/latency/pthread_cond_many.c
===================================================================
--- perf/latency/pthread_cond_many.c.orig
+++ perf/latency/pthread_cond_many.c
@@ -248,4 +248,6 @@ main(int argc, char *argv[])
 	}
 
 	test_signal(iter, nthreads);
+
+	return 0;
 }

--
 Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de
 Pengutronix - Linux Solutions for Science and Industry
   Handelsregister:  Amtsgericht Hildesheim, HRA 2686
     Hannoversche Str. 2, 31134 Hildesheim, Germany
   Phone: +49-5121-206917-0 |  Fax: +49-5121-206917-9

[patch 11/11] implicit declarations

[Robert Schwebel]

[-- Attachment #1: perf-latency-pthread-cond-many-implicit-declarations.diff --]
[-- Type: text/plain, Size: 947 bytes --]

Avoid implicit declaration warnings.

Signed-off-by: Robert Schwebel <r.schwebel@pengutronix.de>

 perf/latency/pthread_cond_many.c |    4 ++++
 1 file changed, 4 insertions(+)

Index: perf/latency/pthread_cond_many.c
===================================================================
--- perf/latency/pthread_cond_many.c.orig
+++ perf/latency/pthread_cond_many.c
@@ -23,9 +23,13 @@
 
 #include <stdio.h>
 #include <stdlib.h>
+#include <poll.h>
 #include <pthread.h>
 #include <sys/time.h>
+#include <sys/types.h>
 #include <sched.h>
+#include <string.h>
+#include <unistd.h>
 
 pthread_mutex_t child_mutex = PTHREAD_MUTEX_INITIALIZER;
 volatile int *child_waiting = 0;

--
 Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de
 Pengutronix - Linux Solutions for Science and Industry
   Handelsregister:  Amtsgericht Hildesheim, HRA 2686
     Hannoversche Str. 2, 31134 Hildesheim, Germany
   Phone: +49-5121-206917-0 |  Fax: +49-5121-206917-9

Re: [patch 00/11] Autotool support for IBM RT Cases

[Nivedita Singhvi]

Robert Schwebel wrote:
> Darren,
> 
> Here is a first raw cut for autotool support for your rt testcases. It
> is against the version on your website. The series survives a basic
> distcheck.
> 
> Known issues & discussion points:
> 
> - test programs which use pthread_mutexattr_setprotocol and
>   pthread_mutexattr_setrobust_np could not be tested (debian unstable
>   does not have a recent enough glibc)
> 
> - due to the above, I assume the tests in question will have a similar
>   quantity of warnings, so I see if I can get access to a box which is
>   recent enough to do the rest of the fixes.
> 
> - a sane version number and contact mail address should be added to
>   configure.ac; I've just taken our template here, please adjust
>   according to your needs.
> 
> Robert

Hey Robert!

Thanks a lot for the patches. I believe Chirag Jog who's
working on cleaning up some of the tests responded to you
offline already. I thought I'd let everyone know we'll
be rolling out an updated tarball once we have that
working.

What we'd like to do, however, is integrate these tests
into the LTP project. I'm hoping people will still find
it as convenient to use. Anyone foresee any issues with
that move?

thanks,
Nivedita

Re: [patch 00/11] Autotool support for IBM RT Cases

[Robert Schwebel]

Hi Nivedita,

On Wed, Mar 28, 2007 at 07:57:57PM -0700, Nivedita Singhvi wrote:
> Thanks a lot for the patches. I believe Chirag Jog who's
> working on cleaning up some of the tests responded to you
> offline already. 

Nope, not yet...

> I thought I'd let everyone know we'll be rolling out an updated
> tarball once we have that working.

Great!

> What we'd like to do, however, is integrate these tests into the LTP
> project. I'm hoping people will still find it as convenient to use.
> Anyone foresee any issues with that move?

However that might end - I think it is important to have cross compiling
support in LTP; last time I looked it was really difficult to achieve,
because you more or less had to care about every single piece of
sourcecode.

Robert
-- 
 Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de
 Pengutronix - Linux Solutions for Science and Industry
   Handelsregister:  Amtsgericht Hildesheim, HRA 2686
     Hannoversche Str. 2, 31134 Hildesheim, Germany
   Phone: +49-5121-206917-0 |  Fax: +49-5121-206917-9

Re: [patch 00/11] Autotool support for IBM RT Cases

[Nivedita Singhvi]

Robert Schwebel wrote:

>> What we'd like to do, however, is integrate these tests into the LTP
>> project. I'm hoping people will still find it as convenient to use.
>> Anyone foresee any issues with that move?
> 
> However that might end - I think it is important to have cross compiling
> support in LTP; last time I looked it was really difficult to achieve,
> because you more or less had to care about every single piece of
> sourcecode.

Yes, we're looking into all those issues now :(. It's probably
a bit more than we wanted to chew off at the moment. I agree
with wanting to have cross-compiling support, we might keep
some interim solution around perhaps.

Thanks a lot for your input! We'll discuss with the list
in greater detail next week.

thanks,
Nivedita