patch: shasum vs. sha256sum

patch: shasum vs. sha256sum

[Tom Walsh]

[-- Attachment #1: Type: text/plain, Size: 683 bytes --]

Just noticed that the sha256sum has been added to the 
classes/sanity.bbclass and bitbake balked at running.   This morning I 
had installed perl-Digest::SHA to satisfy the need for 'shasum'.

I haven't found any package on Mandriva that provides 'sha256sum',  
however, adding '-a 256' sets the sha256 algorithm for shasum?  With 
these two changes, bitbake seems to build the project ok, or, am I 
missing something here?

Regards,

TomW

-- 
Tom Walsh - WN3L - Embedded Systems Consultant
http://openhardware.net http://cyberiansoftware.com http://openzipit.org
"Windows? No thanks, I have work to do..."
----------------------------------------------------



[-- Attachment #2: base.bbclass.patch --]
[-- Type: text/x-patch, Size: 443 bytes --]

--- classes/base.bbclass~	2007-04-02 01:30:14.000000000 -0400
+++ classes/base.bbclass	2007-04-02 01:32:34.000000000 -0400
@@ -54,7 +54,7 @@
         raise Exception("Executing md5sum failed")
 
     try:
-        shapipe = os.popen('shasum -a 2 -b ' + localpath)
+        shapipe = os.popen('shasum -a 256 -b ' + localpath)
         shadata = (shapipe.readline().split() or [ "" ])[0]
         shapipe.close()
     except OSError:

[-- Attachment #3: sanity.bbclass.patch --]
[-- Type: text/x-patch, Size: 576 bytes --]

--- classes/sanity.bbclass~	2007-04-02 01:38:59.000000000 -0400
+++ classes/sanity.bbclass	2007-04-02 01:39:27.000000000 -0400
@@ -86,7 +86,7 @@
 	if not check_app_exists('${BUILD_PREFIX}g++', e.data):
 		missing = missing + "C++ Compiler (${BUILD_PREFIX}g++),"
 
-	required_utilities = "patch diffstat texi2html makeinfo cvs svn git bzip2 tar gzip gawk sha256sum md5sum"
+	required_utilities = "patch diffstat texi2html makeinfo cvs svn git bzip2 tar gzip gawk shasum md5sum"
 
 	for util in required_utilities.split():
 		if not check_app_exists( util, e.data ):

Re: patch: shasum vs. sha256sum

[pHilipp Zabel]

On 4/2/07, Tom Walsh <tom@openhardware.net> wrote:
> Just noticed that the sha256sum has been added to the
> classes/sanity.bbclass and bitbake balked at running.   This morning I
> had installed perl-Digest::SHA to satisfy the need for 'shasum'.
>
> I haven't found any package on Mandriva that provides 'sha256sum',
> however, adding '-a 256' sets the sha256 algorithm for shasum?  With
> these two changes, bitbake seems to build the project ok, or, am I
> missing something here?

sha256sum is a part of coreutils (in debian).
I assumed it to be more common than the perl shasum utility that is
hidden in perl-Digest::SHA.

regards
Philipp

Re: patch: shasum vs. sha256sum

[Holger Freyther]

Am 02.04.2007 um 11:12 schrieb Tom Walsh:

> Just noticed that the sha256sum has been added to the classes/ 
> sanity.bbclass and bitbake balked at running.   This morning I had  
> installed perl-Digest::SHA to satisfy the need for 'shasum'.
>
> I haven't found any package on Mandriva that provides 'sha256sum',   
> however, adding '-a 256' sets the sha256 algorithm for shasum?   
> With these two changes, bitbake seems to build the project ok, or,  
> am I missing something here?

Philipp changed this line from shasum to sha256sum as he/we thought  
sha256sum is more commonly available. If that is not the case I would  
propose to disapprove the change as it is more easy to get the  
required binary from cpan than to recompile coreutils-native.
As a last resort we could add sha256sum code to base.bbclass...


z.

>
> Regards,
>
>
> -        shapipe = os.popen('shasum -a 2 -b ' + localpath)
> +        shapipe = os.popen('shasum -a 256 -b ' + localpath)

Where is shasum -a2 coming from? This must be a local change at your  
side.

Re: patch: shasum vs. sha256sum

[Florian Boor]

Hi,

Holger Freyther schrieb:

> Philipp changed this line from shasum to sha256sum as he/we thought  
> sha256sum is more commonly available. If that is not the case I would  
> propose to disapprove the change as it is more easy to get the  
> required binary from cpan than to recompile coreutils-native.
> As a last resort we could add sha256sum code to base.bbclass...

sounds like a good idea, I just ran into the same problem with Ubuntu.

Greetings

Florian

-- 
The dream of yesterday                  Florian Boor
is the hope of today                    Tel: +49 271-771091-15
and the reality of tomorrow.            Fax: +49 271-771091-19
[Robert Hutchings Goddard, 1904]        florian.boor@kernelconcepts.de

1D78 2D4D 6C53 1CA4 5588  D07B A8E7 940C 25B7 9A76

Re: patch: shasum vs. sha256sum

[Holger Freyther]

Hi,

I think this issue is almost resolved:

	-OE now has a oe_sha256sum binary which is used to verify checksums
	-quilt-native and all other packages depend on this version
	-oe-shasum has no dependencies itself
	-This works with BitBake-1.6
	-Currently it works with BitBake-1.8 but quilt-native fetches before  
the utility is staged and this needs fixing. This will break once  
auto* or quilt* start to use md5/sha sums. We need to look into  
bitbake-1.8 why this dependency is not correctly handled.



kind regards
	holger

Re: patch: shasum vs. sha256sum

[Erik Hovland]

On Mon, Apr 02, 2007 at 05:12:33AM -0400, Tom Walsh wrote:
> Just noticed that the sha256sum has been added to the 
> classes/sanity.bbclass and bitbake balked at running.   This morning I 
> had installed perl-Digest::SHA to satisfy the need for 'shasum'.
> 
> I haven't found any package on Mandriva that provides 'sha256sum',  
> however, adding '-a 256' sets the sha256 algorithm for shasum?  With 
> these two changes, bitbake seems to build the project ok, or, am I 
> missing something here?

It should be part of the coreutils package. But I don't think it was in
the coreutils 5.x series which is the verions that mandriva 2007.0 and
older have in their release. If you are feeling brave, try Spring. If
not, just get the latest coreutils from your local GNU mirror and build
it yourself.

E

-- 
Erik Hovland
mail: erik@hovland.org
web: http://hovland.org/
PGP/GPG public key available on request

Re: patch: shasum vs. sha256sum

[Marcin Juszkiewicz]

Dnia poniedziałek, 2 kwietnia 2007, Erik Hovland napisał:

> It should be part of the coreutils package. But I don't think it was in
> the coreutils 5.x series which is the verions that mandriva 2007.0 and
> older have in their release.

Debian has sha256sum since coreutils 5.97.

> If not, just get the latest coreutils from your local GNU mirror and
> build it yourself.

Or "bitbake coreutils-native-6.0" to get it.

-- 
JID: hrw-jabber.org
OpenEmbedded developer/consultant

           You have dialed a purely imaginary number. 
           Please rotate your phone ninety degrees and try again