All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Schoenebeck <qemu_oss@crudebyte.com>
To: qemu-devel@nongnu.org
Cc: "cdupontd@redhat.com" <cdupontd@redhat.com>,
	"Venegas Munoz,
	Jose Carlos" <jose.carlos.venegas.munoz@intel.com>,
	Greg Kurz <groug@kaod.org>, virtio-fs-list <virtio-fs@redhat.com>,
	"Shinde, Archana M" <archana.m.shinde@intel.com>,
	Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [Virtio-fs] virtiofs vs 9p performance
Date: Fri, 25 Sep 2020 17:47:21 +0200	[thread overview]
Message-ID: <4615316.mGufCYyPMH@silver> (raw)
In-Reply-To: <20200925131356.GD132653@redhat.com>

On Freitag, 25. September 2020 15:13:56 CEST Vivek Goyal wrote:
> On Fri, Sep 25, 2020 at 10:06:41AM +0200, Christian Schoenebeck wrote:
> > On Freitag, 25. September 2020 00:10:23 CEST Vivek Goyal wrote:
> > > In my testing, with cache=none, virtiofs performed better than 9p in
> > > all the fio jobs I was running. For the case of cache=auto  for virtiofs
> > > (with xattr enabled), 9p performed better in certain write workloads. I
> > > have identified root cause of that problem and working on
> > > HANDLE_KILLPRIV_V2 patches to improve WRITE performance of virtiofs
> > > with cache=auto and xattr enabled.
> > 
> > Please note, when it comes to performance aspects, you should set a
> > reasonable high value for 'msize' on 9p client side:
> > https://wiki.qemu.org/Documentation/9psetup#msize
> 
> Interesting. I will try that. What does "msize" do?

Simple: it's the "maximum message size" ever to be used for communication 
between host and guest, in both directions that is.

So if that 'msize' value is too small, a potential large 9p message would be 
split into several smaller 9p messages, and each message adds latency which is 
the main problem.

Keep in mind: The default value with Linux clients for msize is still only 
8kB!

Think of doing 'dd bs=8192 if=/src.dat of=/dst.dat count=...' as analogy, 
which probably makes its impact on performance clear.

However the negative impact of a small 'msize' value is not just limited to 
raw file I/O like that; calling readdir() for instance on a guest directory 
with several hundred files or more, will likewise slow down in the same way 
tremendously as both sides have to transmit a large amount of 9p messages back 
and forth instead of just 2 messages (Treaddir and Rreaddir).

> > I'm also working on performance optimizations for 9p BTW. There is plenty
> > of headroom to put it mildly. For QEMU 5.2 I started by addressing
> > readdir requests:
> > https://wiki.qemu.org/ChangeLog/5.2#9pfs
> 
> Nice. I guess this performance comparison between 9p and virtiofs is good.
> Both the projects can try to identify weak points and improve performance.

Yes, that's indeed handy being able to make comparisons.

Best regards,
Christian Schoenebeck



WARNING: multiple messages have this Message-ID (diff)
From: Christian Schoenebeck <qemu_oss@crudebyte.com>
To: qemu-devel@nongnu.org
Cc: Vivek Goyal <vgoyal@redhat.com>,
	"Shinde, Archana M" <archana.m.shinde@intel.com>,
	"Venegas Munoz,
	Jose Carlos" <jose.carlos.venegas.munoz@intel.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	virtio-fs-list <virtio-fs@redhat.com>, Greg Kurz <groug@kaod.org>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	"cdupontd@redhat.com" <cdupontd@redhat.com>
Subject: Re: virtiofs vs 9p performance
Date: Fri, 25 Sep 2020 17:47:21 +0200	[thread overview]
Message-ID: <4615316.mGufCYyPMH@silver> (raw)
In-Reply-To: <20200925131356.GD132653@redhat.com>

On Freitag, 25. September 2020 15:13:56 CEST Vivek Goyal wrote:
> On Fri, Sep 25, 2020 at 10:06:41AM +0200, Christian Schoenebeck wrote:
> > On Freitag, 25. September 2020 00:10:23 CEST Vivek Goyal wrote:
> > > In my testing, with cache=none, virtiofs performed better than 9p in
> > > all the fio jobs I was running. For the case of cache=auto  for virtiofs
> > > (with xattr enabled), 9p performed better in certain write workloads. I
> > > have identified root cause of that problem and working on
> > > HANDLE_KILLPRIV_V2 patches to improve WRITE performance of virtiofs
> > > with cache=auto and xattr enabled.
> > 
> > Please note, when it comes to performance aspects, you should set a
> > reasonable high value for 'msize' on 9p client side:
> > https://wiki.qemu.org/Documentation/9psetup#msize
> 
> Interesting. I will try that. What does "msize" do?

Simple: it's the "maximum message size" ever to be used for communication 
between host and guest, in both directions that is.

So if that 'msize' value is too small, a potential large 9p message would be 
split into several smaller 9p messages, and each message adds latency which is 
the main problem.

Keep in mind: The default value with Linux clients for msize is still only 
8kB!

Think of doing 'dd bs=8192 if=/src.dat of=/dst.dat count=...' as analogy, 
which probably makes its impact on performance clear.

However the negative impact of a small 'msize' value is not just limited to 
raw file I/O like that; calling readdir() for instance on a guest directory 
with several hundred files or more, will likewise slow down in the same way 
tremendously as both sides have to transmit a large amount of 9p messages back 
and forth instead of just 2 messages (Treaddir and Rreaddir).

> > I'm also working on performance optimizations for 9p BTW. There is plenty
> > of headroom to put it mildly. For QEMU 5.2 I started by addressing
> > readdir requests:
> > https://wiki.qemu.org/ChangeLog/5.2#9pfs
> 
> Nice. I guess this performance comparison between 9p and virtiofs is good.
> Both the projects can try to identify weak points and improve performance.

Yes, that's indeed handy being able to make comparisons.

Best regards,
Christian Schoenebeck




  reply	other threads:[~2020-09-25 15:47 UTC|newest]

Thread overview: 107+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-18 21:34 [Virtio-fs] tools/virtiofs: Multi threading seems to hurt performance Vivek Goyal
2020-09-18 21:34 ` Vivek Goyal
2020-09-21  8:39 ` [Virtio-fs] " Stefan Hajnoczi
2020-09-21  8:39   ` Stefan Hajnoczi
2020-09-21 13:39   ` [Virtio-fs] " Vivek Goyal
2020-09-21 13:39     ` Vivek Goyal
2020-09-21 16:57     ` [Virtio-fs] " Stefan Hajnoczi
2020-09-21 16:57       ` Stefan Hajnoczi
2020-09-21  8:50 ` [Virtio-fs] " Dr. David Alan Gilbert
2020-09-21  8:50   ` Dr. David Alan Gilbert
2020-09-21 13:35   ` [Virtio-fs] " Vivek Goyal
2020-09-21 13:35     ` Vivek Goyal
2020-09-21 14:08     ` [Virtio-fs] " Daniel P. Berrangé
2020-09-21 14:08       ` Daniel P. Berrangé
2020-09-21 15:32 ` [Virtio-fs] " Dr. David Alan Gilbert
2020-09-21 15:32   ` Dr. David Alan Gilbert
2020-09-22 10:25   ` [Virtio-fs] " Dr. David Alan Gilbert
2020-09-22 10:25     ` Dr. David Alan Gilbert
2020-09-22 17:47     ` [Virtio-fs] " Vivek Goyal
2020-09-22 17:47       ` Vivek Goyal
2020-09-24 21:33       ` [Virtio-fs] " Venegas Munoz, Jose Carlos
2020-09-24 21:33         ` Venegas Munoz, Jose Carlos
2020-09-24 22:10         ` [Virtio-fs] virtiofs vs 9p performance(Re: tools/virtiofs: Multi threading seems to hurt performance) Vivek Goyal
2020-09-24 22:10           ` Vivek Goyal
2020-09-25  8:06           ` [Virtio-fs] virtiofs vs 9p performance Christian Schoenebeck
2020-09-25  8:06             ` Christian Schoenebeck
2020-09-25 13:13             ` [Virtio-fs] " Vivek Goyal
2020-09-25 13:13               ` Vivek Goyal
2020-09-25 15:47               ` Christian Schoenebeck [this message]
2020-09-25 15:47                 ` Christian Schoenebeck
2021-02-19 16:08             ` [Virtio-fs] Can not set high msize with virtio-9p (Was: Re: virtiofs vs 9p performance) Vivek Goyal
2021-02-19 16:08               ` Vivek Goyal
2021-02-19 17:33               ` [Virtio-fs] " Christian Schoenebeck
2021-02-19 17:33                 ` Christian Schoenebeck
2021-02-19 19:01                 ` [Virtio-fs] " Vivek Goyal
2021-02-19 19:01                   ` Vivek Goyal
2021-02-20 15:38                   ` [Virtio-fs] " Christian Schoenebeck
2021-02-20 15:38                     ` Christian Schoenebeck
2021-02-22 12:18                     ` [Virtio-fs] " Greg Kurz
2021-02-22 12:18                       ` Greg Kurz
2021-02-22 15:08                       ` [Virtio-fs] " Christian Schoenebeck
2021-02-22 15:08                         ` Christian Schoenebeck
2021-02-22 17:11                         ` [Virtio-fs] " Greg Kurz
2021-02-22 17:11                           ` Greg Kurz
2021-02-23 13:39                           ` [Virtio-fs] " Christian Schoenebeck
2021-02-23 13:39                             ` Christian Schoenebeck
2021-02-23 14:07                             ` [Virtio-fs] " Michael S. Tsirkin
2021-02-23 14:07                               ` Michael S. Tsirkin
2021-02-24 15:16                               ` [Virtio-fs] " Christian Schoenebeck
2021-02-24 15:16                                 ` Christian Schoenebeck
2021-02-24 15:43                                 ` [Virtio-fs] " Dominique Martinet
2021-02-24 15:43                                   ` Dominique Martinet
2021-02-26 13:49                                   ` [Virtio-fs] " Christian Schoenebeck
2021-02-26 13:49                                     ` Christian Schoenebeck
2021-02-27  0:03                                     ` [Virtio-fs] " Dominique Martinet
2021-02-27  0:03                                       ` Dominique Martinet
2021-03-03 14:04                                       ` [Virtio-fs] " Christian Schoenebeck
2021-03-03 14:04                                         ` Christian Schoenebeck
2021-03-03 14:50                                         ` [Virtio-fs] " Dominique Martinet
2021-03-03 14:50                                           ` Dominique Martinet
2021-03-05 14:57                                           ` [Virtio-fs] " Christian Schoenebeck
2021-03-05 14:57                                             ` Christian Schoenebeck
2020-09-25 12:41           ` [Virtio-fs] virtiofs vs 9p performance(Re: tools/virtiofs: Multi threading seems to hurt performance) Dr. David Alan Gilbert
2020-09-25 12:41             ` Dr. David Alan Gilbert
2020-09-25 13:04             ` [Virtio-fs] " Christian Schoenebeck
2020-09-25 13:04               ` Christian Schoenebeck
2020-09-25 13:05               ` [Virtio-fs] " Dr. David Alan Gilbert
2020-09-25 13:05                 ` Dr. David Alan Gilbert
2020-09-25 16:05                 ` [Virtio-fs] " Christian Schoenebeck
2020-09-25 16:05                   ` Christian Schoenebeck
2020-09-25 16:33                   ` [Virtio-fs] " Christian Schoenebeck
2020-09-25 16:33                     ` Christian Schoenebeck
2020-09-25 18:51                   ` [Virtio-fs] " Dr. David Alan Gilbert
2020-09-25 18:51                     ` Dr. David Alan Gilbert
2020-09-27 12:14                     ` [Virtio-fs] " Christian Schoenebeck
2020-09-27 12:14                       ` Christian Schoenebeck
2020-09-29 13:03                       ` [Virtio-fs] " Vivek Goyal
2020-09-29 13:03                         ` Vivek Goyal
2020-09-29 13:28                         ` [Virtio-fs] " Christian Schoenebeck
2020-09-29 13:28                           ` Christian Schoenebeck
2020-09-29 13:49                           ` [Virtio-fs] " Vivek Goyal
2020-09-29 13:49                             ` Vivek Goyal
2020-09-29 13:59                             ` [Virtio-fs] " Christian Schoenebeck
2020-09-29 13:59                               ` Christian Schoenebeck
2020-09-29 13:17             ` [Virtio-fs] " Vivek Goyal
2020-09-29 13:17               ` Vivek Goyal
2020-09-29 13:49               ` [Virtio-fs] " Miklos Szeredi
2020-09-29 13:49                 ` Miklos Szeredi
2020-09-29 14:01                 ` Vivek Goyal
2020-09-29 14:01                   ` Vivek Goyal
2020-09-29 14:54                   ` Miklos Szeredi
2020-09-29 14:54                     ` Miklos Szeredi
2020-09-29 15:28                 ` Vivek Goyal
2020-09-29 15:28                   ` Vivek Goyal
2020-09-25 12:11       ` [Virtio-fs] tools/virtiofs: Multi threading seems to hurt performance Dr. David Alan Gilbert
2020-09-25 12:11         ` Dr. David Alan Gilbert
2020-09-25 13:11         ` [Virtio-fs] " Vivek Goyal
2020-09-25 13:11           ` Vivek Goyal
2020-09-21 20:16 ` [Virtio-fs] " Vivek Goyal
2020-09-21 20:16   ` Vivek Goyal
2020-09-22 11:09   ` [Virtio-fs] " Dr. David Alan Gilbert
2020-09-22 11:09     ` Dr. David Alan Gilbert
2020-09-22 22:56     ` [Virtio-fs] " Vivek Goyal
2020-09-22 22:56       ` Vivek Goyal
2020-09-23 12:50 ` [Virtio-fs] " Chirantan Ekbote
2020-09-23 12:59   ` Vivek Goyal
2020-09-25 11:35   ` Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4615316.mGufCYyPMH@silver \
    --to=qemu_oss@crudebyte.com \
    --cc=archana.m.shinde@intel.com \
    --cc=cdupontd@redhat.com \
    --cc=groug@kaod.org \
    --cc=jose.carlos.venegas.munoz@intel.com \
    --cc=qemu-devel@nongnu.org \
    --cc=vgoyal@redhat.com \
    --cc=virtio-fs@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.