From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 1/2] ARM: shmobile: r8a7790: add internal PCI bridge nodes
Date: Fri, 20 Jun 2014 20:51:45 +0000 [thread overview]
Message-ID: <4637423.jWRbL1GbCK@wuerfel> (raw)
In-Reply-To: <201406210036.59693.sergei.shtylyov@cogentembedded.com>
On Saturday 21 June 2014 00:36:58 Sergei Shtylyov wrote:
> + pci0: pci@ee090000 {
> + compatible = "renesas,pci-r8a7790";
> + clocks = <&mstp7_clks R8A7790_CLK_EHCI>;
> + reg = <0x0 0xee090000 0x0 0xc00>,
> + <0x0 0xee080000 0x0 0x1100>;
> + interrupts = <0 108 IRQ_TYPE_LEVEL_HIGH>;
> + status = "disabled";
> +
> + bus-range = <0 0>;
> + #address-cells = >;
> + #size-cells = <2>;
> + #interrupt-cells = <1>;
> + interrupt-map-mask = <0xff00 0 0 0x7>;
> + interrupt-map = <0x0000 0 0 1 &gic 0 108 IRQ_TYPE_LEVEL_HIGH
> + 0x0800 0 0 1 &gic 0 108 IRQ_TYPE_LEVEL_HIGH
> + 0x1000 0 0 2 &gic 0 108 IRQ_TYPE_LEVEL_HIGH>;
> + };
Hmm, this device node is not actually compliant to the PCI binding,
it needs a "ranges" property that can be used to look up the memory
and I/O space windows. It also needs a device_type property.
I realize that the driver doesn't currently use them, but you should
adhere to the binding anyway, so we can fix the driver at some point.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/2] ARM: shmobile: r8a7790: add internal PCI bridge nodes
Date: Fri, 20 Jun 2014 22:51:45 +0200 [thread overview]
Message-ID: <4637423.jWRbL1GbCK@wuerfel> (raw)
In-Reply-To: <201406210036.59693.sergei.shtylyov@cogentembedded.com>
On Saturday 21 June 2014 00:36:58 Sergei Shtylyov wrote:
> + pci0: pci at ee090000 {
> + compatible = "renesas,pci-r8a7790";
> + clocks = <&mstp7_clks R8A7790_CLK_EHCI>;
> + reg = <0x0 0xee090000 0x0 0xc00>,
> + <0x0 0xee080000 0x0 0x1100>;
> + interrupts = <0 108 IRQ_TYPE_LEVEL_HIGH>;
> + status = "disabled";
> +
> + bus-range = <0 0>;
> + #address-cells = >;
> + #size-cells = <2>;
> + #interrupt-cells = <1>;
> + interrupt-map-mask = <0xff00 0 0 0x7>;
> + interrupt-map = <0x0000 0 0 1 &gic 0 108 IRQ_TYPE_LEVEL_HIGH
> + 0x0800 0 0 1 &gic 0 108 IRQ_TYPE_LEVEL_HIGH
> + 0x1000 0 0 2 &gic 0 108 IRQ_TYPE_LEVEL_HIGH>;
> + };
Hmm, this device node is not actually compliant to the PCI binding,
it needs a "ranges" property that can be used to look up the memory
and I/O space windows. It also needs a device_type property.
I realize that the driver doesn't currently use them, but you should
adhere to the binding anyway, so we can fix the driver at some point.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: horms@verge.net.au, linux-sh@vger.kernel.org, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
devicetree@vger.kernel.org, magnus.damm@gmail.com,
linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org,
ben.dooks@codethink.co.uk
Subject: Re: [PATCH v4 1/2] ARM: shmobile: r8a7790: add internal PCI bridge nodes
Date: Fri, 20 Jun 2014 22:51:45 +0200 [thread overview]
Message-ID: <4637423.jWRbL1GbCK@wuerfel> (raw)
In-Reply-To: <201406210036.59693.sergei.shtylyov@cogentembedded.com>
On Saturday 21 June 2014 00:36:58 Sergei Shtylyov wrote:
> + pci0: pci@ee090000 {
> + compatible = "renesas,pci-r8a7790";
> + clocks = <&mstp7_clks R8A7790_CLK_EHCI>;
> + reg = <0x0 0xee090000 0x0 0xc00>,
> + <0x0 0xee080000 0x0 0x1100>;
> + interrupts = <0 108 IRQ_TYPE_LEVEL_HIGH>;
> + status = "disabled";
> +
> + bus-range = <0 0>;
> + #address-cells = >;
> + #size-cells = <2>;
> + #interrupt-cells = <1>;
> + interrupt-map-mask = <0xff00 0 0 0x7>;
> + interrupt-map = <0x0000 0 0 1 &gic 0 108 IRQ_TYPE_LEVEL_HIGH
> + 0x0800 0 0 1 &gic 0 108 IRQ_TYPE_LEVEL_HIGH
> + 0x1000 0 0 2 &gic 0 108 IRQ_TYPE_LEVEL_HIGH>;
> + };
Hmm, this device node is not actually compliant to the PCI binding,
it needs a "ranges" property that can be used to look up the memory
and I/O space windows. It also needs a device_type property.
I realize that the driver doesn't currently use them, but you should
adhere to the binding anyway, so we can fix the driver at some point.
Arnd
next prev parent reply other threads:[~2014-06-20 20:51 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 20:34 [PATCH v4 0/2] Add R8A7790/Lager board PCI USB DT support Sergei Shtylyov
2014-06-20 20:34 ` Sergei Shtylyov
2014-06-20 20:34 ` Sergei Shtylyov
2014-06-20 20:36 ` [PATCH v4 1/2] ARM: shmobile: r8a7790: add internal PCI bridge nodes Sergei Shtylyov
2014-06-20 20:36 ` Sergei Shtylyov
2014-06-20 20:36 ` Sergei Shtylyov
2014-06-20 20:51 ` Arnd Bergmann [this message]
2014-06-20 20:51 ` Arnd Bergmann
2014-06-20 20:51 ` Arnd Bergmann
2014-06-20 21:00 ` Sergei Shtylyov
2014-06-20 21:00 ` Sergei Shtylyov
2014-06-20 21:00 ` Sergei Shtylyov
2014-06-20 21:10 ` Arnd Bergmann
2014-06-20 21:10 ` Arnd Bergmann
2014-06-20 21:10 ` Arnd Bergmann
2014-06-20 21:25 ` Sergei Shtylyov
2014-06-20 21:25 ` Sergei Shtylyov
2014-06-20 21:25 ` Sergei Shtylyov
2014-06-21 9:15 ` Arnd Bergmann
2014-06-21 9:15 ` Arnd Bergmann
2014-06-21 9:15 ` Arnd Bergmann
2014-06-23 20:40 ` Jason Gunthorpe
2014-06-23 20:40 ` Jason Gunthorpe
2014-06-23 20:40 ` Jason Gunthorpe
2014-06-20 21:16 ` Sergei Shtylyov
2014-06-20 21:16 ` Sergei Shtylyov
2014-06-20 21:16 ` Sergei Shtylyov
2014-06-20 20:38 ` [PATCH v4 2/2] ARM: shmobile: lager: enable internal PCI Sergei Shtylyov
2014-06-20 20:38 ` Sergei Shtylyov
2014-06-20 20:38 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4637423.jWRbL1GbCK@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.