From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: linux-media@vger.kernel.org
Cc: ezequiel@vanguardiasur.com.ar, nicolas.dufresne@collabora.com,
mchehab@kernel.org, robh+dt@kernel.org, mripard@kernel.org,
wens@csie.org, p.zabel@pengutronix.de, andrzej.p@collabora.com,
gregkh@linuxfoundation.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH 0/7] media: hantro: add Allwinner H6 support
Date: Mon, 22 Nov 2021 19:51:19 +0100 [thread overview]
Message-ID: <4666655.GXAFRqVoOG@kista> (raw)
In-Reply-To: <20211122184702.768341-1-jernej.skrabec@gmail.com>
Dne ponedeljek, 22. november 2021 ob 19:46:55 CET je Jernej Skrabec
napisal(a):
> Hi everyone!
>
> Here is patchset which adds support for Hantro G2 core found in Allwinner
> H6 SoC. It is slightly older core, so it needs few quirks to be
> implemented:
> 1. It uses slightly different register layout in some cases. However, those
> differences are small, so it makes sense only to add quirks.
> 2. It doesn't use ring buffer for bitstream as newer variants.
> 3. It needs double buffering to be enabled in order to work correctly.
> 4. postproc must be enabled at the end of the job. It seems that core has
> some issues with latching register values if postproc registers are set
> at the beginning of the job
>
> legacy_regs quirk could be split into 3, like legacy_regs, ring_buffer and
> late_postproc, but I didn't see the need for that. I examined vendor
> sources at [1] and it suggests that legacy_regs implies no ring buffer.
>
> It's also unclear if core supports HEVC decoding or not. This can be
> implemented later. VP9 10-bit decoding support is mentioned in manual, but
> it doesn't work at the moment. This will be addressed later.
>
> Please take a look.
>
> Best regards,
> Jernej
>
> [1] https://github.com/CliveLau1990/imx-vpu-hantro
Forgot to add, this series is based on top of:
https://www.spinics.net/lists/linux-media/msg202448.html
Regards,
Jernej
>
> Jernej Skrabec (7):
> media: hantro: add support for reset lines
> media: hantro: vp9: use double buffering if needed
> media: hantro: vp9: add support for legacy register set
> media: hantro: move postproc enablement for old cores
> media: dt-bindings: allwinner: document H6 Hantro G2 binding
> media: hantro: Add support for Allwinner H6
> arm64: dts: allwinner: h6: Add Hantro G2 node
>
> .../media/allwinner,sun50i-h6-vpu-g2.yaml | 64 +++++++++++
> arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 9 ++
> drivers/staging/media/hantro/Kconfig | 10 +-
> drivers/staging/media/hantro/Makefile | 3 +
> drivers/staging/media/hantro/hantro.h | 7 ++
> drivers/staging/media/hantro/hantro_drv.c | 27 ++++-
> drivers/staging/media/hantro/hantro_g2_regs.h | 20 ++++
> .../staging/media/hantro/hantro_g2_vp9_dec.c | 76 ++++++++++---
> drivers/staging/media/hantro/hantro_hw.h | 1 +
> drivers/staging/media/hantro/sunxi_vpu_hw.c | 104 ++++++++++++++++++
> 10 files changed, 301 insertions(+), 20 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/media/
allwinner,sun50i-h6-vpu-g2.yaml
> create mode 100644 drivers/staging/media/hantro/sunxi_vpu_hw.c
>
> --
> 2.34.0
>
>
WARNING: multiple messages have this Message-ID (diff)
From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: linux-media@vger.kernel.org
Cc: ezequiel@vanguardiasur.com.ar, nicolas.dufresne@collabora.com,
mchehab@kernel.org, robh+dt@kernel.org, mripard@kernel.org,
wens@csie.org, p.zabel@pengutronix.de, andrzej.p@collabora.com,
gregkh@linuxfoundation.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH 0/7] media: hantro: add Allwinner H6 support
Date: Mon, 22 Nov 2021 19:51:19 +0100 [thread overview]
Message-ID: <4666655.GXAFRqVoOG@kista> (raw)
In-Reply-To: <20211122184702.768341-1-jernej.skrabec@gmail.com>
Dne ponedeljek, 22. november 2021 ob 19:46:55 CET je Jernej Skrabec
napisal(a):
> Hi everyone!
>
> Here is patchset which adds support for Hantro G2 core found in Allwinner
> H6 SoC. It is slightly older core, so it needs few quirks to be
> implemented:
> 1. It uses slightly different register layout in some cases. However, those
> differences are small, so it makes sense only to add quirks.
> 2. It doesn't use ring buffer for bitstream as newer variants.
> 3. It needs double buffering to be enabled in order to work correctly.
> 4. postproc must be enabled at the end of the job. It seems that core has
> some issues with latching register values if postproc registers are set
> at the beginning of the job
>
> legacy_regs quirk could be split into 3, like legacy_regs, ring_buffer and
> late_postproc, but I didn't see the need for that. I examined vendor
> sources at [1] and it suggests that legacy_regs implies no ring buffer.
>
> It's also unclear if core supports HEVC decoding or not. This can be
> implemented later. VP9 10-bit decoding support is mentioned in manual, but
> it doesn't work at the moment. This will be addressed later.
>
> Please take a look.
>
> Best regards,
> Jernej
>
> [1] https://github.com/CliveLau1990/imx-vpu-hantro
Forgot to add, this series is based on top of:
https://www.spinics.net/lists/linux-media/msg202448.html
Regards,
Jernej
>
> Jernej Skrabec (7):
> media: hantro: add support for reset lines
> media: hantro: vp9: use double buffering if needed
> media: hantro: vp9: add support for legacy register set
> media: hantro: move postproc enablement for old cores
> media: dt-bindings: allwinner: document H6 Hantro G2 binding
> media: hantro: Add support for Allwinner H6
> arm64: dts: allwinner: h6: Add Hantro G2 node
>
> .../media/allwinner,sun50i-h6-vpu-g2.yaml | 64 +++++++++++
> arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 9 ++
> drivers/staging/media/hantro/Kconfig | 10 +-
> drivers/staging/media/hantro/Makefile | 3 +
> drivers/staging/media/hantro/hantro.h | 7 ++
> drivers/staging/media/hantro/hantro_drv.c | 27 ++++-
> drivers/staging/media/hantro/hantro_g2_regs.h | 20 ++++
> .../staging/media/hantro/hantro_g2_vp9_dec.c | 76 ++++++++++---
> drivers/staging/media/hantro/hantro_hw.h | 1 +
> drivers/staging/media/hantro/sunxi_vpu_hw.c | 104 ++++++++++++++++++
> 10 files changed, 301 insertions(+), 20 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/media/
allwinner,sun50i-h6-vpu-g2.yaml
> create mode 100644 drivers/staging/media/hantro/sunxi_vpu_hw.c
>
> --
> 2.34.0
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-22 18:51 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 18:46 [PATCH 0/7] media: hantro: add Allwinner H6 support Jernej Skrabec
2021-11-22 18:46 ` Jernej Skrabec
2021-11-22 18:46 ` [PATCH 1/7] media: hantro: add support for reset lines Jernej Skrabec
2021-11-22 18:46 ` Jernej Skrabec
2021-11-23 11:09 ` Andrzej Pietrasiewicz
2021-11-23 11:09 ` Andrzej Pietrasiewicz
2021-11-23 14:59 ` Dan Carpenter
2021-11-23 14:59 ` Dan Carpenter
2021-11-23 16:36 ` Andrzej Pietrasiewicz
2021-11-23 16:36 ` Andrzej Pietrasiewicz
2021-11-23 16:46 ` Jernej Škrabec
2021-11-23 16:46 ` Jernej Škrabec
[not found] ` <CAAEAJfD3d4zjwvbv967+oe6awnAkZiGNKroYF5jvoTy=0sn+Pw@mail.gmail.com>
2021-11-30 10:39 ` Andrzej Pietrasiewicz
2021-11-30 10:39 ` Andrzej Pietrasiewicz
2021-11-22 18:46 ` [PATCH 2/7] media: hantro: vp9: use double buffering if needed Jernej Skrabec
2021-11-22 18:46 ` Jernej Skrabec
2021-11-23 11:22 ` Andrzej Pietrasiewicz
2021-11-23 11:22 ` Andrzej Pietrasiewicz
2021-11-22 18:46 ` [PATCH 3/7] media: hantro: vp9: add support for legacy register set Jernej Skrabec
2021-11-22 18:46 ` Jernej Skrabec
2021-11-23 12:06 ` Andrzej Pietrasiewicz
2021-11-23 12:06 ` Andrzej Pietrasiewicz
2021-11-22 18:46 ` [PATCH 4/7] media: hantro: move postproc enablement for old cores Jernej Skrabec
2021-11-22 18:46 ` Jernej Skrabec
2021-11-23 12:12 ` Andrzej Pietrasiewicz
2021-11-23 12:12 ` Andrzej Pietrasiewicz
2021-11-25 12:00 ` Ezequiel Garcia
2021-11-25 12:00 ` Ezequiel Garcia
2021-11-25 19:21 ` Jernej Škrabec
2021-11-25 19:21 ` Jernej Škrabec
2021-11-22 18:47 ` [PATCH 5/7] media: dt-bindings: allwinner: document H6 Hantro G2 binding Jernej Skrabec
2021-11-22 18:47 ` Jernej Skrabec
2021-11-22 18:47 ` [PATCH 6/7] media: hantro: Add support for Allwinner H6 Jernej Skrabec
2021-11-22 18:47 ` Jernej Skrabec
2021-11-23 12:23 ` Andrzej Pietrasiewicz
2021-11-23 12:23 ` Andrzej Pietrasiewicz
2021-11-22 18:47 ` [PATCH 7/7] arm64: dts: allwinner: h6: Add Hantro G2 node Jernej Skrabec
2021-11-22 18:47 ` Jernej Skrabec
2021-11-22 18:51 ` Jernej Škrabec [this message]
2021-11-22 18:51 ` [PATCH 0/7] media: hantro: add Allwinner H6 support Jernej Škrabec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4666655.GXAFRqVoOG@kista \
--to=jernej.skrabec@gmail.com \
--cc=andrzej.p@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-sunxi@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=nicolas.dufresne@collabora.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.