All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Ferre <nicolas.ferre@rfo.atmel.com>
To: Haavard Skinnemoen <hskinnemoen@atmel.com>,
	"Antonino A. Daplas" <adaplas@gmail.com>
Cc: Patrice Vilchez <patrice.vilchez@rfo.atmel.com>,
	Andrew Victor <andrew@sanpeople.com>,
	linux-fbdev-devel@lists.sourceforge.net,
	Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] atmel_lcdfb: Fix wrong line_length calculation
Date: Fri, 15 Jun 2007 10:49:11 +0200	[thread overview]
Message-ID: <46725287.7020702@rfo.atmel.com> (raw)
In-Reply-To: <1181647677482-git-send-email-hskinnemoen@atmel.com>

Haavard Skinnemoen :
> As Jan Altenberg pointed out, line_length will always be 0 if
> bits_per_pixel < 8. Fix this and also make sure that we round up to
> the nearest byte.
> 
> Signed-off-by: Haavard Skinnemoen <hskinnemoen@atmel.com>
> ---
> I haven't tested this with any real program that uses the frame buffer,
> but fbset seems to report sane values for line_length:

Thank you Haavard.

I have a bigger patch for all the support for STN display (tested with
mono STN display). It is based on the work from Jan Altenberg.

This bigger patch includes your modifications.

I send it right now. As a separate message.

Haavard, can you check if the compute_hozval()
function is ok on avr32 (I have reviewed with the at32ap7000 and hope 
that it is ok) ?


Regards,
-- 
Nicolas Ferre



-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@rfo.atmel.com>
To: Haavard Skinnemoen <hskinnemoen@atmel.com>,
	"Antonino A. Daplas" <adaplas@gmail.com>
Cc: linux-fbdev-devel@lists.sourceforge.net,
	Andrew Victor <andrew@sanpeople.com>,
	Linux Kernel list <linux-kernel@vger.kernel.org>,
	Jan Altenberg <jan.altenberg@linutronix.de>,
	Patrice Vilchez <patrice.vilchez@rfo.atmel.com>
Subject: Re: [PATCH] atmel_lcdfb: Fix wrong line_length calculation
Date: Fri, 15 Jun 2007 10:49:11 +0200	[thread overview]
Message-ID: <46725287.7020702@rfo.atmel.com> (raw)
In-Reply-To: <1181647677482-git-send-email-hskinnemoen@atmel.com>

Haavard Skinnemoen :
> As Jan Altenberg pointed out, line_length will always be 0 if
> bits_per_pixel < 8. Fix this and also make sure that we round up to
> the nearest byte.
> 
> Signed-off-by: Haavard Skinnemoen <hskinnemoen@atmel.com>
> ---
> I haven't tested this with any real program that uses the frame buffer,
> but fbset seems to report sane values for line_length:

Thank you Haavard.

I have a bigger patch for all the support for STN display (tested with
mono STN display). It is based on the work from Jan Altenberg.

This bigger patch includes your modifications.

I send it right now. As a separate message.

Haavard, can you check if the compute_hozval()
function is ok on avr32 (I have reviewed with the at32ap7000 and hope 
that it is ok) ?


Regards,
-- 
Nicolas Ferre



  reply	other threads:[~2007-06-15  8:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-07 14:11 [PATCH] atmel_lcdfb: AT91/AT32 LCD Controller framebuffer driver Nicolas Ferre
2007-05-07 16:01 ` [RFC] AVR32: Implement platform hooks for atmel_lcdfb driver Haavard Skinnemoen
2007-05-07 21:40 ` [Linux-fbdev-devel] [PATCH] atmel_lcdfb: AT91/AT32 LCD Controller framebuffer driver Antonino A. Daplas
2007-05-08 17:26   ` Haavard Skinnemoen
2007-05-08 17:26     ` [Linux-fbdev-devel] " Haavard Skinnemoen
2007-05-09 14:59   ` Nicolas Ferre
2007-05-18 18:05     ` Jan Altenberg
2007-06-12 11:27       ` [PATCH] atmel_lcdfb: Fix wrong line_length calculation Haavard Skinnemoen
2007-06-15  8:49         ` Nicolas Ferre [this message]
2007-06-15  8:49           ` Nicolas Ferre
2007-05-09 14:59   ` [PATCH] atmel_lcdfb: AT91/AT32 LCDController framebuffer driver Nicolas Ferre
2007-05-09 14:59     ` [Linux-fbdev-devel] " Nicolas Ferre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46725287.7020702@rfo.atmel.com \
    --to=nicolas.ferre@rfo.atmel.com \
    --cc=adaplas@gmail.com \
    --cc=andrew@sanpeople.com \
    --cc=hskinnemoen@atmel.com \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patrice.vilchez@rfo.atmel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.