* [PATCH v2] 9pfs: Stop including gstrfuncs.h
@ 2025-09-05 15:17 Peter Foley
2025-09-06 3:55 ` Richard Henderson
2025-09-08 16:15 ` Christian Schoenebeck
0 siblings, 2 replies; 3+ messages in thread
From: Peter Foley @ 2025-09-05 15:17 UTC (permalink / raw)
To: qemu-devel
Cc: Christian Schoenebeck, Greg Kurz, pbonzini, nabihestefan,
Peter Foley
gstrfuncs.h is not intended to be included directly.
In fact this only works because glib.h is already included by osdep.h.
Just remove the include.
Signed-off-by: Peter Foley <pefoley@google.com>
---
Changes in v2:
- Just remove the include entirely in favor of osdep.h
- Link to v1: https://lore.kernel.org/qemu-devel/20250904-9p-v1-1-e634cb374c80@google.com
---
hw/9pfs/9p-util-generic.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/9pfs/9p-util-generic.c b/hw/9pfs/9p-util-generic.c
index 4c1e9c887d00c44bc073bec00c07ed09d3868bf5..b71fa2cb3785349c6b4d2b9591f5ea4f917844d0 100644
--- a/hw/9pfs/9p-util-generic.c
+++ b/hw/9pfs/9p-util-generic.c
@@ -2,7 +2,6 @@
#include "qemu/osdep.h"
#include "9p-util.h"
-#include <glib/gstrfuncs.h>
char *qemu_open_flags_tostr(int flags)
{
---
base-commit: baa79455fa92984ff0f4b9ae94bed66823177a27
change-id: 20250904-9p-11c0405ae7c5
Best regards,
--
Peter Foley <pefoley@google.com>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] 9pfs: Stop including gstrfuncs.h
2025-09-05 15:17 [PATCH v2] 9pfs: Stop including gstrfuncs.h Peter Foley
@ 2025-09-06 3:55 ` Richard Henderson
2025-09-08 16:15 ` Christian Schoenebeck
1 sibling, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2025-09-06 3:55 UTC (permalink / raw)
To: qemu-devel
On 9/5/25 17:17, Peter Foley wrote:
> gstrfuncs.h is not intended to be included directly.
> In fact this only works because glib.h is already included by osdep.h.
> Just remove the include.
>
> Signed-off-by: Peter Foley <pefoley@google.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
> ---
> Changes in v2:
> - Just remove the include entirely in favor of osdep.h
> - Link to v1: https://lore.kernel.org/qemu-devel/20250904-9p-v1-1-e634cb374c80@google.com
> ---
> hw/9pfs/9p-util-generic.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/9pfs/9p-util-generic.c b/hw/9pfs/9p-util-generic.c
> index 4c1e9c887d00c44bc073bec00c07ed09d3868bf5..b71fa2cb3785349c6b4d2b9591f5ea4f917844d0 100644
> --- a/hw/9pfs/9p-util-generic.c
> +++ b/hw/9pfs/9p-util-generic.c
> @@ -2,7 +2,6 @@
>
> #include "qemu/osdep.h"
> #include "9p-util.h"
> -#include <glib/gstrfuncs.h>
>
> char *qemu_open_flags_tostr(int flags)
> {
>
> ---
> base-commit: baa79455fa92984ff0f4b9ae94bed66823177a27
> change-id: 20250904-9p-11c0405ae7c5
>
> Best regards,
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] 9pfs: Stop including gstrfuncs.h
2025-09-05 15:17 [PATCH v2] 9pfs: Stop including gstrfuncs.h Peter Foley
2025-09-06 3:55 ` Richard Henderson
@ 2025-09-08 16:15 ` Christian Schoenebeck
1 sibling, 0 replies; 3+ messages in thread
From: Christian Schoenebeck @ 2025-09-08 16:15 UTC (permalink / raw)
To: qemu-devel
Cc: Greg Kurz, pbonzini, nabihestefan, Peter Foley, Richard Henderson
On Friday, September 5, 2025 5:17:11 PM CEST Peter Foley wrote:
> gstrfuncs.h is not intended to be included directly.
> In fact this only works because glib.h is already included by osdep.h.
> Just remove the include.
>
> Signed-off-by: Peter Foley <pefoley@google.com>
> ---
Queued on 9p.next:
https://github.com/cschoenebeck/qemu/commits/9p.next
Thanks!
/Christian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-09-08 16:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-05 15:17 [PATCH v2] 9pfs: Stop including gstrfuncs.h Peter Foley
2025-09-06 3:55 ` Richard Henderson
2025-09-08 16:15 ` Christian Schoenebeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.