* [Xenomai-core] [PATCH] Switch to pci_register_driver
@ 2007-06-19 10:31 Jan Kiszka
2007-06-19 19:26 ` Wolfgang Grandegger
2007-06-21 11:20 ` Wolfgang Grandegger
0 siblings, 2 replies; 4+ messages in thread
From: Jan Kiszka @ 2007-06-19 10:31 UTC (permalink / raw)
To: Wolfgang Grandegger; +Cc: xenomai-core
[-- Attachment #1: Type: text/plain, Size: 1202 bytes --]
Hi Wolfgang,
can we just switch over to pci_register_driver in order to avoid
deprecated (and soon removed) pci_module_init? Or do we also need some
wrapper for older 2.4 kernels (latest 2.4 is already aligned with 2.6)?
Jan
Index: ksrc/drivers/can/sja1000/rtcan_ixxat_pci.c
===================================================================
--- ksrc/drivers/can/sja1000/rtcan_ixxat_pci.c (Revision 2609)
+++ ksrc/drivers/can/sja1000/rtcan_ixxat_pci.c (Arbeitskopie)
@@ -307,7 +307,7 @@ static struct pci_driver rtcan_ixxat_pci
static int __init rtcan_ixxat_pci_init(void)
{
- return pci_module_init(&rtcan_ixxat_pci_driver);
+ return pci_register_driver(&rtcan_ixxat_pci_driver);
}
Index: ksrc/drivers/can/sja1000/rtcan_peak_pci.c
===================================================================
--- ksrc/drivers/can/sja1000/rtcan_peak_pci.c (Revision 2609)
+++ ksrc/drivers/can/sja1000/rtcan_peak_pci.c (Arbeitskopie)
@@ -346,7 +346,7 @@ static struct pci_driver rtcan_peak_pci_
static int __init rtcan_peak_pci_init(void)
{
- return pci_module_init(&rtcan_peak_pci_driver);
+ return pci_register_driver(&rtcan_peak_pci_driver);
}
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 250 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Xenomai-core] [PATCH] Switch to pci_register_driver
2007-06-19 10:31 [Xenomai-core] [PATCH] Switch to pci_register_driver Jan Kiszka
@ 2007-06-19 19:26 ` Wolfgang Grandegger
2007-06-21 11:20 ` Wolfgang Grandegger
1 sibling, 0 replies; 4+ messages in thread
From: Wolfgang Grandegger @ 2007-06-19 19:26 UTC (permalink / raw)
To: Jan Kiszka; +Cc: xenomai-core
Jan Kiszka wrote:
> Hi Wolfgang,
>
> can we just switch over to pci_register_driver in order to avoid
> deprecated (and soon removed) pci_module_init? Or do we also need some
> wrapper for older 2.4 kernels (latest 2.4 is already aligned with 2.6)?
Likely. I will do some tests tomorrow.
Wolfgang.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Xenomai-core] [PATCH] Switch to pci_register_driver
2007-06-19 10:31 [Xenomai-core] [PATCH] Switch to pci_register_driver Jan Kiszka
2007-06-19 19:26 ` Wolfgang Grandegger
@ 2007-06-21 11:20 ` Wolfgang Grandegger
2007-06-21 13:48 ` Philippe Gerum
1 sibling, 1 reply; 4+ messages in thread
From: Wolfgang Grandegger @ 2007-06-21 11:20 UTC (permalink / raw)
To: Jan Kiszka; +Cc: xenomai-core
Hi Jan,
Jan Kiszka wrote:
> Hi Wolfgang,
>
> can we just switch over to pci_register_driver in order to avoid
> deprecated (and soon removed) pci_module_init? Or do we also need some
> wrapper for older 2.4 kernels (latest 2.4 is already aligned with 2.6)?
It works with 2.4.25, at least and from my point of view it can be applied.
Thanks.
Wolfgang.
> Jan
>
>
> Index: ksrc/drivers/can/sja1000/rtcan_ixxat_pci.c
> ===================================================================
> --- ksrc/drivers/can/sja1000/rtcan_ixxat_pci.c (Revision 2609)
> +++ ksrc/drivers/can/sja1000/rtcan_ixxat_pci.c (Arbeitskopie)
> @@ -307,7 +307,7 @@ static struct pci_driver rtcan_ixxat_pci
>
> static int __init rtcan_ixxat_pci_init(void)
> {
> - return pci_module_init(&rtcan_ixxat_pci_driver);
> + return pci_register_driver(&rtcan_ixxat_pci_driver);
> }
>
>
> Index: ksrc/drivers/can/sja1000/rtcan_peak_pci.c
> ===================================================================
> --- ksrc/drivers/can/sja1000/rtcan_peak_pci.c (Revision 2609)
> +++ ksrc/drivers/can/sja1000/rtcan_peak_pci.c (Arbeitskopie)
> @@ -346,7 +346,7 @@ static struct pci_driver rtcan_peak_pci_
>
> static int __init rtcan_peak_pci_init(void)
> {
> - return pci_module_init(&rtcan_peak_pci_driver);
> + return pci_register_driver(&rtcan_peak_pci_driver);
> }
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Xenomai-core] [PATCH] Switch to pci_register_driver
2007-06-21 11:20 ` Wolfgang Grandegger
@ 2007-06-21 13:48 ` Philippe Gerum
0 siblings, 0 replies; 4+ messages in thread
From: Philippe Gerum @ 2007-06-21 13:48 UTC (permalink / raw)
To: Wolfgang Grandegger; +Cc: Jan Kiszka, xenomai-core
On Thu, 2007-06-21 at 13:20 +0200, Wolfgang Grandegger wrote:
> Hi Jan,
>
> Jan Kiszka wrote:
> > Hi Wolfgang,
> >
> > can we just switch over to pci_register_driver in order to avoid
> > deprecated (and soon removed) pci_module_init? Or do we also need some
> > wrapper for older 2.4 kernels (latest 2.4 is already aligned with 2.6)?
>
> It works with 2.4.25, at least and from my point of view it can be applied.
>
Ok, so that's fine with me too. Please apply.
> Thanks.
>
> Wolfgang.
>
> > Jan
> >
> >
> > Index: ksrc/drivers/can/sja1000/rtcan_ixxat_pci.c
> > ===================================================================
> > --- ksrc/drivers/can/sja1000/rtcan_ixxat_pci.c (Revision 2609)
> > +++ ksrc/drivers/can/sja1000/rtcan_ixxat_pci.c (Arbeitskopie)
> > @@ -307,7 +307,7 @@ static struct pci_driver rtcan_ixxat_pci
> >
> > static int __init rtcan_ixxat_pci_init(void)
> > {
> > - return pci_module_init(&rtcan_ixxat_pci_driver);
> > + return pci_register_driver(&rtcan_ixxat_pci_driver);
> > }
> >
> >
> > Index: ksrc/drivers/can/sja1000/rtcan_peak_pci.c
> > ===================================================================
> > --- ksrc/drivers/can/sja1000/rtcan_peak_pci.c (Revision 2609)
> > +++ ksrc/drivers/can/sja1000/rtcan_peak_pci.c (Arbeitskopie)
> > @@ -346,7 +346,7 @@ static struct pci_driver rtcan_peak_pci_
> >
> > static int __init rtcan_peak_pci_init(void)
> > {
> > - return pci_module_init(&rtcan_peak_pci_driver);
> > + return pci_register_driver(&rtcan_peak_pci_driver);
> > }
> >
> >
> >
>
>
> _______________________________________________
> Xenomai-core mailing list
> Xenomai-core@domain.hid
> https://mail.gna.org/listinfo/xenomai-core
--
Philippe.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-06-21 13:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-19 10:31 [Xenomai-core] [PATCH] Switch to pci_register_driver Jan Kiszka
2007-06-19 19:26 ` Wolfgang Grandegger
2007-06-21 11:20 ` Wolfgang Grandegger
2007-06-21 13:48 ` Philippe Gerum
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.