[lm-sensors] initial fintek f71882fg driver, test please

[lm-sensors] initial fintek f71882fg driver, test please

[Hans de Goede]

[-- Attachment #1: Type: text/plain, Size: 928 bytes --]

Hi all,

Here is my first work on a fintek f71882fg driver (also epox 1308). Still todo:
in1 max, beep and alarm read and write
tempX fault read
tempX beep and alarm read and write
tempX max / crit / hyst writing
fanX fault read
pwm support

This version should work on non Epox motherboards like MSI too (Thanks Mathias 
Grimmberger)

To test drop fintek71882 and the Makefile in a dir, type make and then insmod 
fintek71882.ko

The easiest way to then read the settings is by using the 3.0 sensors branch, 
which comes with dyn chipsupport:
remove your current lm-sensors userspace package (for example on Fedora do rpm 
-e lm_sensors --nodeps)
svn checkout http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0
cd lm-sensors-3.0.0
make
sudo make install
sudo ldconfig


I've also attached a sensors.conf for the Epox M1697 motherboard I'm using for 
testing, modify as needed.


Thanks for testing & Regards,

Hans

[-- Attachment #2: Makefile --]
[-- Type: text/plain, Size: 161 bytes --]

obj-m += fintek71882.o

all:
	make -C /lib/modules/$(shell uname -r)/build M=$(PWD) modules

clean:
	make -C /lib/modules/$(shell uname -r)/build M=$(PWD) clean

[-- Attachment #3: fintek71882.c --]
[-- Type: text/x-csrc, Size: 17600 bytes --]

/***************************************************************************
 *   Copyright (C) 2006 by Hans Edgington                                  *
 *   hans@edgington.nl                                                     *
 *                                                                         *
 *   This program is free software; you can redistribute it and/or modify  *
 *   it under the terms of the GNU General Public License as published by  *
 *   the Free Software Foundation; either version 2 of the License, or     *
 *   (at your option) any later version.                                   *
 *                                                                         *
 *   This program is distributed in the hope that it will be useful,       *
 *   but WITHOUT ANY WARRANTY; without even the implied warranty of        *
 *   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the         *
 *   GNU General Public License for more details.                          *
 *                                                                         *
 *   You should have received a copy of the GNU General Public License     *
 *   along with this program; if not, write to the                         *
 *   Free Software Foundation, Inc.,                                       *
 *   59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.             *
 ***************************************************************************/

#include <linux/module.h>
#include <linux/init.h>
#include <linux/slab.h>
#include <linux/jiffies.h>
#include <linux/platform_device.h>
#include <linux/hwmon.h>
#include <linux/hwmon-sysfs.h>
#include <linux/err.h>
#include <linux/mutex.h>
#include <asm/io.h>

#define DRVNAME "f71882fg"

#define SIO_F71882FG_LD_HWM	0x04	/* Hardware monitor logical device*/
#define SIO_UNLOCK_KEY		0x87	/* Key to enable Super-I/O */
#define SIO_LOCK_KEY		0xAA	/* Key to diasble Super-I/O */

#define SIO_REG_LDSEL		0x07	/* Logical device select */
#define SIO_REG_DEVID		0x20	/* Device ID (2 bytes) */
#define SIO_REG_DEVREV		0x22	/* Device revision */
#define SIO_REG_MANID		0x23	/* Fintek ID (2 bytes) */
#define SIO_REG_ENABLE		0x30	/* Logical device enable */
#define SIO_REG_ADDR		0x60	/* Logical device address (2 bytes) */

#define SIO_FINTEK_ID	0x1934 /* Manufacturers ID */
#define SIO_F71882_ID	0x0541 /* Chipset ID */

#define REGION_LENGTH	8
#define ADDR_REG_OFFSET	5
#define DATA_REG_OFFSET	6

#define F71882FG_REG_PECI		0x0A
#define F71882FG_REG_IN(nr)		(0x20  + (nr))
#define F71882FG_REG_FAN(nr)		(0xA0 + (16 * (nr)))
#define F71882FG_REG_TEMP(nr)		(0x72 + 2 * (nr))
#define F71882FG_REG_TEMP_OVT(nr)	(0x82 + 2 * (nr))
#define F71882FG_REG_TEMP_HIGH(nr)	(0x83 + 2 * (nr))
#define F71882FG_REG_TEMP_HYST1		0x6C
#define F71882FG_REG_TEMP_HYST23	0x6D
#define F71882FG_REG_TEMP_TYPE		0x6B

#define	F71882FG_REG_START		0x01

#define FAN_MIN_DETECT	366 /* Lowest detectable fanspeed */

static struct platform_device *f71882fg_pdev = NULL;

/* Super-I/O Function prototypes */
static inline int superio_inb(int base, int reg);
static inline int superio_inw(int base, int reg);
static inline void superio_enter(int base);
static inline void superio_select(int base, int ld);
static inline void superio_exit(int base);

static inline u16 fan_from_reg ( u16 reg );

struct f71882fg_data {
	unsigned short addr;
	struct class_device *class_dev;

	struct mutex update_lock;
	char valid;			/* !=0 if following fields are valid */
	unsigned long last_updated;	/* In jiffies */
	unsigned long last_limits;	/* In jiffies */

	/* Register Values */
	u8	in[9];
	u16	fan[4];
	u8	temp[3];
	u8	temp_ovt[3];
	u8	temp_high[3];
	u8	temp_hyst[3];
	u8	temp_type[3];
};

static u8 f71882fg_read8(struct f71882fg_data *data, u8 reg);
static u16 f71882fg_read16(struct f71882fg_data *data, u8 reg);
static void f71882fg_write8(struct f71882fg_data *data, u8 reg, u8 val);

/* Sysfs in*/
static ssize_t show_in ( struct device *dev, struct device_attribute *devattr, char *buf );
/* Sysfs Fan */
static ssize_t show_fan ( struct device *dev, struct device_attribute *devattr, char *buf );
/* Sysfs Temp */
static ssize_t show_temp ( struct device *dev, struct device_attribute *devattr, char *buf );
static ssize_t show_temp_max ( struct device *dev, struct device_attribute *devattr, char *buf );
static ssize_t show_temp_crit ( struct device *dev, struct device_attribute *devattr, char *buf );
static ssize_t show_temp_hyst ( struct device *dev, struct device_attribute *devattr, char *buf );
static ssize_t show_temp_type (struct device *dev, struct device_attribute *devattr, char *buf );

static ssize_t show_name( struct device *dev, struct device_attribute *devattr, char *buf );

static int __devinit f71882fg_probe(struct platform_device * pdev);
static int __devexit f71882fg_remove(struct platform_device *pdev);
static int __init f71882fg_init(void);
static int __init f71882fg_find(int sioaddr, unsigned short *address);
static int __init f71882fg_device_add(unsigned short address);
static void __exit f71882fg_exit(void);

static struct platform_driver f71882fg_driver = {
	.driver = {
		.owner	= THIS_MODULE,
		.name	= DRVNAME,
	},
	.probe		= f71882fg_probe,
	.remove		= __devexit_p(f71882fg_remove),
};

static struct device_attribute f71882fg_dev_attr[] =
{
	__ATTR( name, S_IRUGO, show_name, NULL ),
};

static struct sensor_device_attribute f71882fg_in_temp_attr[] =
{
	SENSOR_ATTR(in0_input, S_IRUGO, show_in, NULL, 0),
	SENSOR_ATTR(in1_input, S_IRUGO, show_in, NULL, 1),
	SENSOR_ATTR(in2_input, S_IRUGO, show_in, NULL, 2),
	SENSOR_ATTR(in3_input, S_IRUGO, show_in, NULL, 3),
	SENSOR_ATTR(in4_input, S_IRUGO, show_in, NULL, 4),
	SENSOR_ATTR(in5_input, S_IRUGO, show_in, NULL, 5),
	SENSOR_ATTR(in6_input, S_IRUGO, show_in, NULL, 6),
	SENSOR_ATTR(in7_input, S_IRUGO, show_in, NULL, 7),
	SENSOR_ATTR(in8_input, S_IRUGO, show_in, NULL, 8),
	SENSOR_ATTR(temp1_input, S_IRUGO, show_temp, NULL, 0),
	SENSOR_ATTR(temp1_max, S_IRUGO, show_temp_max, NULL, 0),
	SENSOR_ATTR(temp1_max_hyst, S_IRUGO, show_temp_hyst, NULL, 0),
	SENSOR_ATTR(temp1_crit, S_IRUGO, show_temp_crit, NULL, 0),
	SENSOR_ATTR(temp1_crit_hyst, S_IRUGO, show_temp_hyst, NULL, 0),
	SENSOR_ATTR(temp1_type, S_IRUGO, show_temp_type, NULL, 0),
	SENSOR_ATTR(temp2_input, S_IRUGO, show_temp, NULL, 1),
	SENSOR_ATTR(temp2_max, S_IRUGO, show_temp_max, NULL, 1),
	SENSOR_ATTR(temp2_max_hyst, S_IRUGO, show_temp_hyst, NULL, 1),
	SENSOR_ATTR(temp2_crit, S_IRUGO, show_temp_crit, NULL, 1),
	SENSOR_ATTR(temp2_crit_hyst, S_IRUGO, show_temp_hyst, NULL, 1),
	SENSOR_ATTR(temp2_type, S_IRUGO, show_temp_type, NULL, 1),
	SENSOR_ATTR(temp3_input, S_IRUGO, show_temp, NULL, 2),
	SENSOR_ATTR(temp3_max, S_IRUGO, show_temp_max, NULL, 2),
	SENSOR_ATTR(temp3_max_hyst, S_IRUGO, show_temp_hyst, NULL, 2),
	SENSOR_ATTR(temp3_crit, S_IRUGO, show_temp_crit, NULL, 2),
	SENSOR_ATTR(temp3_crit_hyst, S_IRUGO, show_temp_hyst, NULL, 2),
	SENSOR_ATTR(temp3_type, S_IRUGO, show_temp_type, NULL, 2)
};

static struct sensor_device_attribute f71882fg_fan_attr[] =
{
	SENSOR_ATTR(fan1_input, S_IRUGO, show_fan, NULL, 0 ),
	SENSOR_ATTR(fan2_input, S_IRUGO, show_fan, NULL, 1 ),
	SENSOR_ATTR(fan3_input, S_IRUGO, show_fan, NULL, 2 ),
	SENSOR_ATTR(fan4_input, S_IRUGO, show_fan, NULL, 3 )
};


/* Super I/O functions */
static inline int superio_inb(int base, int reg)
{
	outb(reg, base);
	return inb(base + 1);
}

static int superio_inw(int base, int reg)
{
	int val;
	outb(reg++, base);
	val = inb(base + 1) << 8;
	outb(reg, base);
	val |= inb(base + 1);
	return val;
}

static inline void superio_enter(int base)
{
	outb( SIO_UNLOCK_KEY, base);
	outb( SIO_UNLOCK_KEY, base);
}

static inline void superio_select( int base, int ld)
{
	outb(SIO_REG_LDSEL, base);
	outb(ld, base + 1);
}

static inline void superio_exit(int base)
{
	outb(SIO_LOCK_KEY, base);
}

static inline u16 fan_from_reg ( u16 reg )
{
	return ( 1500000 / reg );
}

static u8 f71882fg_read8(struct f71882fg_data *data, u8 reg)
{
	u8 val;

	outb(reg, data->addr + ADDR_REG_OFFSET);
	val = inb(data->addr + DATA_REG_OFFSET);

	return val;
}

static u16 f71882fg_read16(struct f71882fg_data *data, u8 reg)
{
	u16 val;

	outb(reg, data->addr + ADDR_REG_OFFSET);
	val = inb(data->addr + DATA_REG_OFFSET) << 8;
	outb(++reg, data->addr + ADDR_REG_OFFSET);
	val |= inb(data->addr + DATA_REG_OFFSET);

	return val;
}

static void f71882fg_write8(struct f71882fg_data *data, u8 reg, u8 val)
{
	outb(reg, data->addr + ADDR_REG_OFFSET );
	outb(val, data->addr + DATA_REG_OFFSET );	
}

static struct f71882fg_data *f71882fg_update_device(struct device * dev)
{
	struct f71882fg_data *data = dev_get_drvdata(dev);
	int nr, reg, reg2;

	mutex_lock(&data->update_lock);
	
	/* Update once every 60 seconds */
	if ( time_after(jiffies, data->last_updated + 60 * HZ ) ||
			!data->valid) {
		/* Get High & boundary temps*/
		for (nr = 0; nr < 3; nr++) {
			data->temp_ovt[nr] = f71882fg_read8(data,
						F71882FG_REG_TEMP_OVT(nr));
			data->temp_high[nr] = f71882fg_read8(data,
						F71882FG_REG_TEMP_HIGH(nr));
		}

		/* Have to hardcode hyst*/
		data->temp_hyst[0] = f71882fg_read8(data,
						F71882FG_REG_TEMP_HYST1) >> 4;
		/* Hyst temps 2 & 3 stored in same register */
		reg = f71882fg_read8(data, F71882FG_REG_TEMP_HYST23);
		data->temp_hyst[1] = reg & 0x0F;
		data->temp_hyst[2] = reg >> 4;

		/* Have to hardcode type, because temp1 is special */
		reg  = f71882fg_read8(data, F71882FG_REG_TEMP_TYPE);
		reg2 = f71882fg_read8(data, F71882FG_REG_PECI);
		if ((reg2 & 0x03) == 0x01) 
			data->temp_type[0] = 6 /* PECI */;
		else if ((reg2 & 0x03) == 0x02)
			data->temp_type[0] = 5 /* AMDSI */;
		else
			data->temp_type[0] = (reg & 0x02) ? 2 : 4;
		
		data->temp_type[1] = (reg & 0x04) ? 2 : 4;
		data->temp_type[2] = (reg & 0x08) ? 2 : 4;

		data->last_limits = jiffies;
	}
	
	/* Update every second */
	if (time_after(jiffies, data->last_updated + HZ) || !data->valid)  {
		for (nr = 0; nr < 3; nr++)
			data->temp[nr] = f71882fg_read8(data,
						F71882FG_REG_TEMP(nr));

		for (nr = 0; nr < 4; nr++)
			data->fan[nr] = f71882fg_read16(data,
						F71882FG_REG_FAN(nr));

		for (nr = 0; nr < 9; nr++)
			data->in[nr] = f71882fg_read8(data,
						F71882FG_REG_IN(nr));

		data->last_updated = jiffies;
		data->valid = 1;
	}

	mutex_unlock(&data->update_lock);

	return data;
}

/* Sysfs Interface */
static ssize_t show_fan ( struct device *dev, struct device_attribute *devattr, char *buf )
{
	struct f71882fg_data *data = f71882fg_update_device( dev );
	struct sensor_device_attribute * attr = to_sensor_dev_attr( devattr );
	int nr = attr->index;

	return sprintf( buf, "%d\n", fan_from_reg( data->fan[nr] ));
}

static ssize_t show_in ( struct device *dev, struct device_attribute *devattr, char *buf )
{
	struct f71882fg_data *data = f71882fg_update_device( dev );
	struct sensor_device_attribute * attr = to_sensor_dev_attr( devattr );
	int nr = attr->index;

	return sprintf( buf, "%d\n", data->in[nr] * 8);
}

static ssize_t show_temp ( struct device *dev, struct device_attribute *devattr, char *buf )
{
	struct f71882fg_data *data = f71882fg_update_device( dev );
	struct sensor_device_attribute * attr = to_sensor_dev_attr( devattr );
	int nr = attr->index;

	return sprintf( buf, "%d\n", data->temp[nr] * 1000);
}

static ssize_t show_temp_max ( struct device *dev, struct device_attribute *devattr, char *buf )
{
	struct f71882fg_data *data = f71882fg_update_device( dev );
	struct sensor_device_attribute * attr = to_sensor_dev_attr( devattr );
	int nr = attr->index;

	return sprintf( buf, "%d\n", data->temp_high[nr] * 1000);
}

static ssize_t show_temp_crit ( struct device *dev, struct device_attribute *devattr, char *buf )
{
	struct f71882fg_data *data = f71882fg_update_device( dev );
	struct sensor_device_attribute * attr = to_sensor_dev_attr( devattr );
	int nr = attr->index;

	return sprintf( buf, "%d\n", data->temp_ovt[nr] * 1000);
}

static ssize_t show_temp_hyst (struct device *dev, struct device_attribute *devattr, char *buf )
{
	struct f71882fg_data *data = f71882fg_update_device( dev );
	struct sensor_device_attribute * attr = to_sensor_dev_attr( devattr );
	int nr = attr->index;

	return sprintf( buf, "%d\n", (data->temp_hyst[nr] * 1000));
}

static ssize_t show_temp_type (struct device *dev, struct device_attribute *devattr, char *buf )
{
	struct f71882fg_data *data = f71882fg_update_device( dev );
	struct sensor_device_attribute * attr = to_sensor_dev_attr( devattr );
	int nr = attr->index;

	return sprintf(buf, "%d\n", data->temp_type[nr]);
}

static ssize_t show_name( struct device *dev, struct device_attribute *devattr, char *buf )
{
	return sprintf( buf, DRVNAME "\n");
}


static int __devinit f71882fg_probe(struct platform_device * pdev)
{
	struct f71882fg_data *data;
	int err, i;
	u8 start_reg;

	if(!(data = kzalloc(sizeof(struct f71882fg_data), GFP_KERNEL)))
		return -ENOMEM;

	data->addr = platform_get_resource(pdev, IORESOURCE_IO, 0)->start;
	mutex_init(&data->update_lock);
	platform_set_drvdata(pdev, data);

	/* Register sysfs interface files */
	for (i = 0; i < ARRAY_SIZE(f71882fg_dev_attr); i++) {
		err = device_create_file(&pdev->dev, &f71882fg_dev_attr[i]);
		if (err)
			goto exit_unregister_sysfs;
	}
	
	start_reg = f71882fg_read8(data, F71882FG_REG_START);
	if (start_reg & 0x01) {
		for (i = 0; i < ARRAY_SIZE(f71882fg_in_temp_attr); i++) {
			err = device_create_file(&pdev->dev,
					&f71882fg_in_temp_attr[i].dev_attr);
			if (err)
				goto exit_unregister_sysfs;
		}
	}

	if (start_reg & 0x02) {
		for (i = 0; i < ARRAY_SIZE(f71882fg_fan_attr); i++) {
			err = device_create_file(&pdev->dev,
					&f71882fg_fan_attr[i].dev_attr);
			if (err)
				goto exit_unregister_sysfs;
		}
	}
	
	data->class_dev = hwmon_device_register(&pdev->dev);
	if (IS_ERR(data->class_dev)) {
		err = PTR_ERR(data->class_dev);
		goto exit_unregister_sysfs;
	}

	return 0;

exit_unregister_sysfs:
	for (i = 0; i < ARRAY_SIZE(f71882fg_dev_attr); i++)
		device_remove_file(&pdev->dev, &f71882fg_dev_attr[i]);
	
	for (i = 0; i < ARRAY_SIZE(f71882fg_in_temp_attr); i++)
		device_remove_file(&pdev->dev,
					&f71882fg_in_temp_attr[i].dev_attr);
	
	for (i = 0; i < ARRAY_SIZE(f71882fg_fan_attr); i++)
		device_remove_file(&pdev->dev, &f71882fg_fan_attr[i].dev_attr);

	kfree(data);

	return err;
}

static int __devexit f71882fg_remove(struct platform_device *pdev)
{
	int i;
	struct f71882fg_data *data = platform_get_drvdata(pdev);

	platform_set_drvdata(pdev, NULL);
	hwmon_device_unregister(data->class_dev);

	for (i = 0; i < ARRAY_SIZE(f71882fg_dev_attr); i++)
		device_remove_file(&pdev->dev, &f71882fg_dev_attr[i]);
	
	for (i = 0; i < ARRAY_SIZE(f71882fg_in_temp_attr); i++)
		device_remove_file(&pdev->dev,
					&f71882fg_in_temp_attr[i].dev_attr);
	
	for (i = 0; i < ARRAY_SIZE(f71882fg_fan_attr); i++)
		device_remove_file(&pdev->dev, &f71882fg_fan_attr[i].dev_attr);

	kfree(data);

	return 0;
}

static int __init f71882fg_find(int sioaddr, unsigned short *address)
{
	int err = -ENODEV;
	u16 devid;
	u8 start_reg;
	struct f71882fg_data data;

	superio_enter(sioaddr);
	
	devid = superio_inw(sioaddr, SIO_REG_MANID);
	if (devid != SIO_FINTEK_ID) {
		printk(KERN_INFO DRVNAME ": Not a Fintek device\n");
		goto exit;
	}

	devid = superio_inw(sioaddr, SIO_REG_DEVID);
	if (devid != SIO_F71882_ID) {
		printk(KERN_INFO DRVNAME ": Unsupported Fintek device\n");
		goto exit;
	}

	superio_select(sioaddr, SIO_F71882FG_LD_HWM);
	if (!(superio_inb(sioaddr, SIO_REG_ENABLE) & 0x01))  {
		printk(KERN_WARNING DRVNAME ": Device not activated\n");
		goto exit;
	}

	*address = superio_inw(sioaddr, SIO_REG_ADDR);
	if (*address == 0) 
	{
		printk(KERN_WARNING DRVNAME ": Base address not set\n");
		goto exit;
	}
	*address &= ~(REGION_LENGTH - 1);	/* Ignore 3 LSB */
	
	data.addr = *address;
	start_reg = f71882fg_read8(&data, F71882FG_REG_START);
	if (!(start_reg & 0x03)) {
		printk(KERN_WARNING DRVNAME
			": Hardware monitoring not activated\n");
		goto exit;
	}

	err = 0;
	printk(KERN_INFO DRVNAME ": Found F71882FG chip at %#x, revision %d\n",
		(unsigned int)*address,
		(int)superio_inb(sioaddr, SIO_REG_DEVREV));
exit:
	superio_exit(sioaddr);
	return err;
}

static int __init f71882fg_device_add(unsigned short address)
{
	struct resource res = {
		.start	= address,
		.end	= address + REGION_LENGTH - 1,
		.flags	= IORESOURCE_IO,
	};
	int err;

	f71882fg_pdev = platform_device_alloc(DRVNAME, address);
	if(!f71882fg_pdev)
		return -ENOMEM;

	res.name = f71882fg_pdev->name;
	err = platform_device_add_resources(f71882fg_pdev, &res, 1);
	if(err) {
		printk(KERN_ERR DRVNAME ": Device resource addition failed\n");
		goto exit_device_put;
	}

	err = platform_device_add(f71882fg_pdev);
	if(err) {
		printk(KERN_ERR DRVNAME ": Device addition failed\n");
		goto exit_device_put;
	}
	
	return 0;

exit_device_put:
	platform_device_put(f71882fg_pdev);

	return err;
}

static int __init f71882fg_init(void)
{
	int err = -ENODEV;
	unsigned short address;

	if (f71882fg_find(0x2e, &address) && f71882fg_find(0x4e, &address))
		goto exit;

	if ((err = platform_driver_register(&f71882fg_driver)))
		goto exit;
	
	if ((err = f71882fg_device_add(address)))
		goto exit_driver;

	return 0;

exit_driver:
	platform_driver_unregister(&f71882fg_driver);
exit:
	return err;
}

static void __exit f71882fg_exit(void)
{
	platform_device_unregister(f71882fg_pdev);
	platform_driver_unregister(&f71882fg_driver);
}

MODULE_DESCRIPTION("F71882FG Hardware Monitoring Driver");
MODULE_AUTHOR("Hans Edgington (hans@edgington.nl)");
MODULE_LICENSE("GPL");

module_init(f71882fg_init);
module_exit(f71882fg_exit);

[-- Attachment #4: sensors.conf --]
[-- Type: text/plain, Size: 1092 bytes --]

chip "f71882fg-*"
# Fintek f71882fg
# Notice that this config is for the Epox M1697 board, which has a Fintek
# f71882fg relabeled as Epox ep1308. Your milage with thos config on other
# boards will probably vary

# Temperature
    label temp1       "CPU"
    label temp2       "System"
    ignore temp3
    ignore temp4

# Fans
    label fan1        "CPU"
    ignore fan2
    ignore fan3
    ignore fan4

# Voltage
    label in0         "3.3V"
    label in1         "Vcore"
    label in2         "Vdimm"
    label in3         "Vchip"
    label in4         "+5V"
    label in5         "12V"
    label in6         "5VSB"
    label in7         "3VSB"
    label in8         "Batery"

# never change the in0, in7 and in8 compute, these are hardwired in the chip!
    compute in0       (@ * 2), (@ / 2) 
    compute in2       (@ * 2), (@ / 2)
    compute in3       (@ * 2), (@ / 2)
    compute in4       (@ * 5.25), (@ / 5.25)
    compute in5       (@ * 12.83), (@ / 12.83)
    compute in6       (@ * 5.25), (@ / 5.25)
    compute in7       (@ * 2), (@ / 2)
    compute in8       (@ * 2), (@ / 2)

[-- Attachment #5: Type: text/plain, Size: 153 bytes --]

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] initial fintek f71882fg driver, test please

[Hans de Goede]

Jacob Heerikhuisen wrote:
> Hi Hans,
> 
> I have tried out your driver, and it's working well! Thanks!
> 
> Is there a simple way to get the gnome-sensors-applet to interface with
> this driver?
> 

I'm afraid not, gnome-sensors-applet seems pretty broken. I'll take a look at 
fixing it one of these days.

Regards,

Hans

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] initial fintek f71882fg driver, test please

[Walt H]

Hans de Goede wrote:
> Hi all,
>
> Here is my first work on a fintek f71882fg driver (also epox 1308). 
> Still todo:
> in1 max, beep and alarm read and write
> tempX fault read
> tempX beep and alarm read and write
> tempX max / crit / hyst writing
> fanX fault read
> pwm support
>
> This version should work on non Epox motherboards like MSI too (Thanks 
> Mathias Grimmberger)
>
> To test drop fintek71882 and the Makefile in a dir, type make and then 
> insmod fintek71882.ko
>
> The easiest way to then read the settings is by using the 3.0 sensors 
> branch, which comes with dyn chipsupport:
> remove your current lm-sensors userspace package (for example on 
> Fedora do rpm -e lm_sensors --nodeps)
> svn checkout 
> http://lm-sensors.org/svn/lm-sensors/branches/lm-sensors-3.0.0
> cd lm-sensors-3.0.0
> make
> sudo make install
> sudo ldconfig
>
>
> I've also attached a sensors.conf for the Epox M1697 motherboard I'm 
> using for testing, modify as needed.
>
>
> Thanks for testing & Regards,
>
> Hans

Compiled and installed fine against a patched 2.6.21 x86_64 kernel .  
Looks good so far.  I'm displaying sensor values through gkrellm and the 
temps and fan values look good.  Vcor1 looks high, and the voltage 
inputs need tweaks under gkrellm, but I'm mainly interested in temp and 
fan values anyway.  Appreciate everybody's work on this!  Thanks,

-Walt



_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] initial fintek f71882fg driver, test please

[Goede, J.W.R. de]

Walt H wrote:
> Compiled and installed fine against a patched 2.6.21
x86_64 kernel .  
> Looks good so far.  I'm displaying sensor values through
gkrellm and the 
> temps and fan values look good.  Vcor1 looks high, and
the voltage 
> inputs need tweaks under gkrellm, but I'm mainly
interested in temp and 
> fan values anyway.  Appreciate everybody's work on this!
 Thanks,
> 
> -Walt

Thanks for the feedback, on what motherboard did you test?
I doubt that vcore 1 is high because vcore usually is
connected without a divider, also since if there is a
scaling problem, its almost aways a missing divider, not a
multiply,  I would expect vcore to be to low, not to high.

Regards,

Hans


p.s. Did you try this with the libsensors 3 branch? I would
be much oblidged you could, then run sensors and update
sensors.conf until things look good and last send the
working snesors.conf to te list.

Regards,

Hans


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] initial fintek f71882fg driver, test please

[Walt H]

Goede, J.W.R. de wrote:
> Thanks for the feedback, on what motherboard did you test?
> I doubt that vcore 1 is high because vcore usually is
> connected without a divider, also since if there is a
> scaling problem, its almost aways a missing divider, not a
> multiply,  I would expect vcore to be to low, not to high.
>
> Regards,
>
> Hans
>
>
> p.s. Did you try this with the libsensors 3 branch? I would
> be much oblidged you could, then run sensors and update
> sensors.conf until things look good and last send the
> working snesors.conf to te list.
>
> Regards,
>
> Hans
>
>
>   
This was tested on an MSI P965 Platinum MB.  I installed the svn 
checkout of libsensors3 and copied the section from the f71805 to modify 
for this chip.  The set statements for the chip fail, so I'm not able to 
set hysteresis or critical values on temperatures yet.  Also, on my MB, 
the BIOS hardware monitor only shows the CPU Vcore, +5 VSB, +5, +12, NB 
and DRAM voltage, so I can't vouch for the other inputs.  The comments 
from the f71805 indicate that in0 (+3.3) should be internally scaled and 
need no adjustment, however, if that input is correct it appears to be 
scaled in half by default, so I multiplied it by 2.  The output from a 
sensors command looks like this:

f71882fg-isa-0a10
Adapter: ISA adapter
+3.3V:           +3.31 V
Vtt1.2V:         +1.14 V
Vram:            +1.98 V
Vchip:           +3.00 V
+5V:             +5.00 V
+12V:           +12.23 V
Vcc1.5V:         +1.26 V
Vcore:           +1.66 V
5VSB:            +5.03 V
CPU Fan:        1400 RPM
Sys Fan:        1466 RPM
CPU Temp:        +39.0 C  (high = +85.0 C, hyst =  +4.0 C)  sensor = 
transistor
temp1_crit:     +100.0 C  (hyst =  +4.0 C)
Sys Temp:        +35.0 C  (high = +85.0 C, hyst =  +4.0 C)  sensor = 
transistor
temp2_crit:     +100.0 C  (hyst =  +4.0 C)

The values I can check against the HW monitor in the bios are pretty 
close.  The bios measured:
1.3~ on CPU Vcore
5.045 on +5VSB
5.003 on +5
12.232 on +12
1.26 on NB
2.00 on DRAM

The relevant section of the sensors.conf for the chip are:


chip "f71882fg-*"
# Voltages
   label in0 "+3.3V"
   label in1 "Vtt1.2V"
   label in2 "Vram"
   label in3 "Vchip"
   label in4 "+5V"
   label in5 "+12V"
   label in6 "Vcc1.5V"
   label in7 "Vcore"
   label in8 "5VSB"

   # in0 is scaled internally
   compute in0  @*2, @*2
   compute in2  @*(1+100/100), @/(1+100/100)
   compute in3  @*(1+100/47),  @/(1+100/47)
   compute in4  @*(1+200/47),  @/(1+200/47)
   compute in5  @*(1+200/20),  @/(1+200/20)
   compute in8  @*(1+100/46),  @/(1+100/46)

   # in0 is the chip's own VCC.
   #set in0_min  3.0
   #set in0_max  3.6

   #set in1_min  1.2 * 0.95
   #set in1_max  1.2 * 1.05
   #set in2_min  2.5 * 0.95
   #set in2_max  2.6 * 1.05
   #set in3_min  3.3 * 0.95
   #set in3_max  3.3 * 1.05
   #set in4_min  5.0 * 0.95
   #set in4_max  5.0 * 1.05
   #set in5_min 12.0 * 0.95
   #set in5_max 12.0 * 1.05
   #set in6_min  1.5 * 0.95
   #set in6_max  1.5 * 1.05
   # in7 nominal value depends on the CPU model
   #set in7_min  1.4 * 0.95
   #set in7_max  1.4 * 1.05
   #set in8_min  5.0 * 0.95
   #set in8_max  5.0 * 1.05

# Fans
   label fan1 "CPU Fan"
   label fan2 "Sys Fan"
   label fan3 "Aux Fan"

   #set fan1_min 2100
   #set fan2_min 1400
   #set fan3_min 1400
   ignore fan3
   ignore fan4

# Temperatures
   label temp1 "CPU Temp"
   label temp2 "Sys Temp"
   label temp3 "Aux Temp"

   set temp1_max   60
   set temp1_max_hyst  58
   set temp2_max   50
   set temp2_max_hyst  48
   ignore temp3
   #set temp3_max   50
   #set temp3_hyst  48


Also, not sure about this driver, although it's probably similar, I 
needed to disable pnpacpi in order to detect the chip with the first rev 
from Hans Edgington.  Seems the pnpacpi driver claims the I/O ports 
first and blocked the driver from accessing it.  I'm running this on a 
Core2 Duo E6600 compiled for x86_64, so I used pnpacpi=off as a boot 
line parm.

Hope this helps,

-Walt



_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] initial fintek f71882fg driver, test please

[Walt H]

Walt H wrote:
>
> The values I can check against the HW monitor in the bios are pretty 
> close.  The bios measured:
> 1.3~ on CPU Vcore
> 5.045 on +5VSB
> 5.003 on +5
> 12.232 on +12
> 1.26 on NB
> 2.00 on DRAM
>
Just a follow-up.  I forgot to mention it in my prior mail, but the 
temperature and fan readings are pretty much spot-on. 

-Walt



_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] initial fintek f71882fg driver, test please

[Hans de Goede]

Walt H wrote:
> Goede, J.W.R. de wrote:
>> On Wed, 20 Jun 2007 18:28:49 -0500
>>  Walt H <walt_h@lorettotel.net> wrote:
>>> This was tested on an MSI P965 Platinum MB.  I installed
>>> the svn checkout of libsensors3 and copied the section
>>> from the f71805 to modify for this chip.  The set
>>> statements for the chip fail, so I'm not able to set
>>> hysteresis or critical values on temperatures yet.  Also,
>>> on my MB, the BIOS hardware monitor only shows the CPU
>>> Vcore, +5 VSB, +5, +12, NB and DRAM voltage, so I can't
>>> vouch for the other inputs.
>> Well, the 3.3V, 3.3VSB and Vbat inputs are all internally
>> connected in the chip, so they should be fine. That still
>> leaves us one voltage short though.
>>
>>
>>   The comments from the f71805
>>> indicate that in0 (+3.3) should be internally scaled and
>>> need no adjustment, however, if that input is correct it
>>> appears to be scaled in half by default, so I multiplied
>>> it by 2.
>> Ahha, if you would have looken at the epox sensors.conf I
>> attched and am using for tested you would have seen that
>> I'm scaling in0 there by a factor of 2, and a comment not
>> to change this as its internally scaled. I guess the f71805
>> driver is doing the scaling in the driver already. Which
>> makes sense. I'll modify my driver todo the same for in0
>> and in6 and in7.
>>
> Sorry, missed that.... Figured F71805 would be close.
> 
>> Also Vcore is most likely connected to in1, as in1 is the
>> only one which can cause voltage alarms.
> 
> Makes sense.
>> I think using the config below should yield better results,
>> can you try this please? ALso please write down your BIOS
>> readings till the last diget, assuming you have a decent
>> powersupply the readings should be pretty stable, so maybe
>> we can compare the last digits to find out exactly whats
>> what. Because currently in2, in3 and in4 are all reading
>> about 1V unscaled, which when using normal scaling factors
>> could be any of: 1V 2V or 5.2V when scaled, so the lables
>> currently apointed to them below are somewhat random ATM.
>>
>> chip "f71882fg-*"
>>
>> # Temperature
>>     label temp1 "CPU"
>>     label temp2 "System"
>>     ignore temp3
>>     ignore temp4
>>
>> # Fans
>>     label fan1 "CPU"
>>     label fan2 "System"
>>     ignore fan3
>>     ignore fan4
>>
>> # Voltage
>>     label in0 "3.3V"
>>     label in1 "Vcore"
>>     label in2 "Vram"
>>     label in3 "5VSB"
>>     label in4 "+5V"
>>     label in5 "12V"
>>     label in6 "??"
>>     label in7 "3VSB"
>>     label in8 "Batery"
>>
>> # never change the in0, in7 and in8 compute, these are
>> hardwired in the chip!
>>     compute in0 (@ * 2), (@ / 2)
>>     compute in2 (@ * 2), (@ / 2)
>>     compute in3  @*(1+200/47),  @/(1+200/47)
>>     compute in4  @*(1+200/47),  @/(1+200/47)
>>     compute in5  @*(1+200/20),  @/(1+200/20)
>>     compute in7 (@ * 2), (@ / 2)
>>     compute in8 (@ * 2), (@ / 2)
>>
>> Regards,
>>
>> Hans
>>
>>
> This looks good Hans.  The Vcore is seems to be spot on now.  It does
> range, as expected due to freq. scaling, but it matches up with what
> I've seen in the BIOS.  All the rest look good as well.  The ?? (in6) 
> sensor appears to be NB as that is what is set in the bios under the
> "overclocking" menu. 
> 
> Also, tried booting without pnpacpi turned off and it worked just fine. 
> Current output is as follows:
> 
> f71882fg-isa-0a10
> Adapter: ISA adapter
> 3.3V:            +3.31 V
> Vcore:           +1.14 V
> Vram:            +1.98 V
> 5VSB:            +5.05 V
> +5V:             +5.00 V
> 12V:            +12.23 V
> ??:              +1.26 V
> 3VSB:            +3.31 V
> Batery:          +3.17 V                       *** (spelling: S/B  Battery)
> CPU Fan:        1066 RPM
> System Fan:     1469 RPM
> CPU:             +39.0 C  (high = +85.0 C, hyst =  +4.0 C)  sensor > transistor
> temp1_crit:     +100.0 C  (hyst =  +4.0 C)
> System:          +34.0 C  (high = +85.0 C, hyst =  +4.0 C)  sensor > transistor
> temp2_crit:     +100.0 C  (hyst =  +4.0 C)
> 

Thanks for testing,

I've added this config for the MSI P965 Platinum to the wiki, see:
http://www.lm-sensors.org/wiki/Configurations/MSI/P965-Platinum

Regards,

Hans


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors