All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rudolf Marek <r.marek@assembler.cz>
To: Luca Tettamanti <kronos.it@gmail.com>
Cc: lm-sensors@lm-sensors.org, linux-acpi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [lm-sensors] [RFC] ACPI based hwmon driver for ASUS
Date: Thu, 21 Jun 2007 21:02:02 +0200	[thread overview]
Message-ID: <467ACB2A.4070707@assembler.cz> (raw)
In-Reply-To: <20070602222829.GA11893@dreamland.darkstar.lan>

Hi again,

Of course it is not there because I removed it myself :/ The "sensors" command 
will just produce "general parse error" this is because of the unknown device 
class (imho). So I removed that and forgot. Well now I have the sysfs files:

/sys/class/hwmon/hwmon2/device/:
bus         fan0_min    fan2_input  fan3_label    in0_input  in1_label  in2_max 
    in3_min    temp0_crit   temp1_input
driver      fan1_input  fan2_label  fan3_max      in0_label  in1_max    in2_min 
    name       temp0_input  temp1_label
fan0_input  fan1_label  fan2_max    fan3_min      in0_max    in1_min 
in3_input  path       temp0_label  temp1_max
fan0_label  fan1_max    fan2_min    hid           in0_min    in2_input 
in3_label  power      temp0_max    uevent
fan0_max    fan1_min    fan3_input  hwmon:hwmon2  in1_input  in2_label  in3_max 
    subsystem  temp1_crit


Please note that in kernelsrc/Documentation/hwmon/sysfs-interface
is defined the interface. We have fans starting from 1 and not 0
Also temperatures are in milidegrees. So your 3200 should be 32000.
Temps file starts also from 1 and not 0. (so no temp0...)

Please can you fix this issues? I will do the review later once this things are 
fixed. Values seems to match.

Thanks,
Rudolf

WARNING: multiple messages have this Message-ID (diff)
From: Rudolf Marek <r.marek@assembler.cz>
To: Luca Tettamanti <kronos.it@gmail.com>
Cc: lm-sensors@lm-sensors.org, linux-acpi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [lm-sensors] [RFC] ACPI based hwmon driver for ASUS
Date: Thu, 21 Jun 2007 19:02:02 +0000	[thread overview]
Message-ID: <467ACB2A.4070707@assembler.cz> (raw)
In-Reply-To: <20070602222829.GA11893@dreamland.darkstar.lan>

Hi again,

Of course it is not there because I removed it myself :/ The "sensors" command 
will just produce "general parse error" this is because of the unknown device 
class (imho). So I removed that and forgot. Well now I have the sysfs files:

/sys/class/hwmon/hwmon2/device/:
bus         fan0_min    fan2_input  fan3_label    in0_input  in1_label  in2_max 
    in3_min    temp0_crit   temp1_input
driver      fan1_input  fan2_label  fan3_max      in0_label  in1_max    in2_min 
    name       temp0_input  temp1_label
fan0_input  fan1_label  fan2_max    fan3_min      in0_max    in1_min 
in3_input  path       temp0_label  temp1_max
fan0_label  fan1_max    fan2_min    hid           in0_min    in2_input 
in3_label  power      temp0_max    uevent
fan0_max    fan1_min    fan3_input  hwmon:hwmon2  in1_input  in2_label  in3_max 
    subsystem  temp1_crit


Please note that in kernelsrc/Documentation/hwmon/sysfs-interface
is defined the interface. We have fans starting from 1 and not 0
Also temperatures are in milidegrees. So your 3200 should be 32000.
Temps file starts also from 1 and not 0. (so no temp0...)

Please can you fix this issues? I will do the review later once this things are 
fixed. Values seems to match.

Thanks,
Rudolf

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2007-06-21 19:02 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-13 22:33 [RFC] ACPI based hwmon driver for ASUS Luca Tettamanti
2007-05-13 22:33 ` [lm-sensors] " Luca Tettamanti
2007-05-21 21:29 ` Rudolf Marek
2007-05-21 21:29   ` Rudolf Marek
2007-05-21 21:38   ` Luca
2007-05-21 21:38     ` [lm-sensors] " Luca
2007-05-21 21:53   ` Luca
2007-05-21 21:53     ` Luca
2007-05-22  6:19     ` Rudolf Marek
2007-05-22  6:19       ` Rudolf Marek
2007-05-22  6:19       ` Rudolf Marek
2007-06-02 22:28       ` Luca Tettamanti
2007-06-02 22:28         ` Luca Tettamanti
2007-06-02 22:28         ` Luca Tettamanti
2007-06-21 18:49         ` Rudolf Marek
2007-06-21 18:49           ` Rudolf Marek
2007-06-21 19:33           ` Luca
2007-06-21 19:33             ` Luca
2007-06-21 19:02         ` Rudolf Marek [this message]
2007-06-21 19:02           ` Rudolf Marek
2007-06-21 19:15           ` Alexey Starikovskiy
2007-06-21 19:15             ` Alexey Starikovskiy
2007-06-21 20:11             ` Luca
2007-06-21 20:11               ` Luca

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=467ACB2A.4070707@assembler.cz \
    --to=r.marek@assembler.cz \
    --cc=kronos.it@gmail.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.