From: Jeff Garzik <jeff@garzik.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
Jens Axboe <jens.axboe@oracle.com>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: block/bsg.c
Date: Mon, 16 Jul 2007 21:12:26 -0400 [thread overview]
Message-ID: <469C177A.3080002@garzik.org> (raw)
In-Reply-To: <20070716180908.e15325bd.akpm@linux-foundation.org>
Andrew Morton wrote:
> Yup, but the concern (from Al, iirc) was that someone could change the code
> later on, add a new bug and have that bug hidden by the unneeded
> initialisation.
True.
That's why #gccbug went the safe route, took the cost of extra
instructions, and initialized it to zero.
> uninitialized_var() has the advantage that it generates no code, whereas "=
> 0" often adds instructions. Plus of course it is self-documenting, greppable-for
> and centrally alterable.
Agreed.
Jeff
next prev parent reply other threads:[~2007-07-17 1:12 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-16 23:57 block/bsg.c Andrew Morton
2007-07-17 0:47 ` block/bsg.c Jeff Garzik
2007-07-17 0:53 ` block/bsg.c Andrew Morton
2007-07-17 0:58 ` block/bsg.c Jeff Garzik
2007-07-17 1:09 ` block/bsg.c Andrew Morton
2007-07-17 1:12 ` Jeff Garzik [this message]
2007-07-17 1:47 ` block/bsg.c Jeff Garzik
2007-07-17 1:47 ` block/bsg.c Jeff Garzik
2007-07-17 3:00 ` block/bsg.c Jeremy Fitzhardinge
2007-07-17 3:00 ` block/bsg.c Jeremy Fitzhardinge
2007-07-17 3:03 ` block/bsg.c Andrew Morton
2007-07-17 3:03 ` block/bsg.c Andrew Morton
2007-07-17 0:52 ` block/bsg.c Satyam Sharma
2007-07-17 0:57 ` block/bsg.c FUJITA Tomonori
2007-07-17 1:01 ` block/bsg.c Gabriel C
2007-07-17 4:57 ` block/bsg.c Joseph Fannin
2007-07-17 6:38 ` block/bsg.c Jens Axboe
2007-07-17 6:43 ` block/bsg.c FUJITA Tomonori
2007-07-17 6:59 ` block/bsg.c Jens Axboe
2007-07-17 7:08 ` block/bsg.c FUJITA Tomonori
2007-07-17 7:10 ` block/bsg.c Jens Axboe
2007-07-17 7:17 ` block/bsg.c FUJITA Tomonori
2007-07-17 7:19 ` block/bsg.c Jens Axboe
2007-07-17 10:07 ` block/bsg.c FUJITA Tomonori
2007-07-17 10:19 ` block/bsg.c Jens Axboe
2007-07-17 18:53 ` block/bsg.c James Bottomley
2007-07-17 19:48 ` block/bsg.c Andrew Morton
2007-07-17 19:52 ` block/bsg.c James Bottomley
2007-07-18 0:20 ` block/bsg.c FUJITA Tomonori
2007-07-18 13:54 ` block/bsg.c James Bottomley
2007-07-18 14:23 ` block/bsg.c James Bottomley
2007-07-18 23:18 ` block/bsg.c FUJITA Tomonori
2007-07-17 20:52 ` block/bsg.c Bartlomiej Zolnierkiewicz
2007-07-17 21:34 ` block/bsg.c Andrew Morton
2007-07-17 23:19 ` block/bsg.c Bartlomiej Zolnierkiewicz
2007-07-17 22:26 ` block/bsg.c FUJITA Tomonori
2007-07-17 22:26 ` block/bsg.c FUJITA Tomonori
2007-07-18 20:39 ` block/bsg.c Bartlomiej Zolnierkiewicz
2007-07-18 23:44 ` block/bsg.c FUJITA Tomonori
2007-07-17 7:24 ` block/bsg.c FUJITA Tomonori
2007-07-17 19:18 ` block/bsg.c Andrew Morton
2007-07-17 20:22 ` block/bsg.c Andrew Morton
2007-07-17 22:19 ` block/bsg.c James Bottomley
2007-07-17 22:54 ` block/bsg.c Andrew Morton
2007-07-17 22:57 ` block/bsg.c James Bottomley
2007-07-17 23:37 ` block/bsg.c Jeff Garzik
2007-07-18 0:43 ` block/bsg.c Bartlomiej Zolnierkiewicz
2007-07-18 14:11 ` block/bsg.c James Bottomley
2007-07-18 20:32 ` block/bsg.c Bartlomiej Zolnierkiewicz
2007-07-18 21:32 ` block/bsg.c James Bottomley
2007-07-17 7:48 ` block/bsg.c Jan Engelhardt
2007-07-17 12:04 ` [PATCH] Don't define empty struct bsg_class_device if !CONFIG_BLK_DEV_BSG (was: Re: block/bsg.c) Geert Uytterhoeven
2007-07-17 12:10 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=469C177A.3080002@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.