All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Jeff Garzik <jeff@garzik.org>
Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
	Jens Axboe <jens.axboe@oracle.com>,
	linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: block/bsg.c
Date: Mon, 16 Jul 2007 20:03:57 -0700	[thread overview]
Message-ID: <20070716200357.15dd8c64.akpm@linux-foundation.org> (raw)
In-Reply-To: <469C1FA9.3090809@garzik.org>

On Mon, 16 Jul 2007 21:47:21 -0400 Jeff Garzik <jeff@garzik.org> wrote:

> hrm.  uninitialized_var(x) does not silence the warning, on my compiler:
> 
> [jgarzik@pretzel misc-2.6]$ rpm -q gcc
> gcc-4.1.2-13.fc6
> 
> @@ -1358,6 +1358,8 @@ udf_load_partition(struct super_block *sb, kernel_lb_addr
>             	{
>             		kernel_lb_addr ino;
> + 			uninitialized_var(ino.partitionReferenceNum);
> +
>                	if (!UDF_SB_LASTBLOCK(sb))

[erk, wordwrapping!]

> still yields
> 
> fs/udf/super.c: In function ‘udf_fill_super’:
> fs/udf/super.c:1359: warning: ‘ino.partitionReferenceNum’ may be used 
> uninitialized in this function
> 

We use it as

-	int foo;
+	int uninitialized_var(foo);

so what you have is effectively


		kernel_lb_addr ino;

		ino.partitionReferenceNum = ino.partitionReferenceNum;


so it still warns.



Hopefully this will work:

		kernel_lb_addr uninitialized_var(ino);

	
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Jeff Garzik <jeff@garzik.org>
Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
	Jens Axboe <jens.axboe@oracle.com>,
	linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: block/bsg.c
Date: Mon, 16 Jul 2007 20:03:57 -0700	[thread overview]
Message-ID: <20070716200357.15dd8c64.akpm@linux-foundation.org> (raw)
In-Reply-To: <469C1FA9.3090809@garzik.org>

On Mon, 16 Jul 2007 21:47:21 -0400 Jeff Garzik <jeff@garzik.org> wrote:

> hrm.  uninitialized_var(x) does not silence the warning, on my compiler:
> 
> [jgarzik@pretzel misc-2.6]$ rpm -q gcc
> gcc-4.1.2-13.fc6
> 
> @@ -1358,6 +1358,8 @@ udf_load_partition(struct super_block *sb, kernel_lb_addr
>             	{
>             		kernel_lb_addr ino;
> + 			uninitialized_var(ino.partitionReferenceNum);
> +
>                	if (!UDF_SB_LASTBLOCK(sb))

[erk, wordwrapping!]

> still yields
> 
> fs/udf/super.c: In function ‘udf_fill_super’:
> fs/udf/super.c:1359: warning: ‘ino.partitionReferenceNum’ may be used 
> uninitialized in this function
> 

We use it as

-	int foo;
+	int uninitialized_var(foo);

so what you have is effectively


		kernel_lb_addr ino;

		ino.partitionReferenceNum = ino.partitionReferenceNum;


so it still warns.



Hopefully this will work:

		kernel_lb_addr uninitialized_var(ino);

	

  parent reply	other threads:[~2007-07-17  3:04 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-16 23:57 block/bsg.c Andrew Morton
2007-07-17  0:47 ` block/bsg.c Jeff Garzik
2007-07-17  0:53   ` block/bsg.c Andrew Morton
2007-07-17  0:58     ` block/bsg.c Jeff Garzik
2007-07-17  1:09       ` block/bsg.c Andrew Morton
2007-07-17  1:12         ` block/bsg.c Jeff Garzik
2007-07-17  1:47         ` block/bsg.c Jeff Garzik
2007-07-17  1:47           ` block/bsg.c Jeff Garzik
2007-07-17  3:00           ` block/bsg.c Jeremy Fitzhardinge
2007-07-17  3:00             ` block/bsg.c Jeremy Fitzhardinge
2007-07-17  3:03           ` Andrew Morton [this message]
2007-07-17  3:03             ` block/bsg.c Andrew Morton
2007-07-17  0:52 ` block/bsg.c Satyam Sharma
2007-07-17  0:57   ` block/bsg.c FUJITA Tomonori
2007-07-17  1:01   ` block/bsg.c Gabriel C
2007-07-17  4:57 ` block/bsg.c Joseph Fannin
2007-07-17  6:38 ` block/bsg.c Jens Axboe
2007-07-17  6:43   ` block/bsg.c FUJITA Tomonori
2007-07-17  6:59     ` block/bsg.c Jens Axboe
2007-07-17  7:08       ` block/bsg.c FUJITA Tomonori
2007-07-17  7:10         ` block/bsg.c Jens Axboe
2007-07-17  7:17           ` block/bsg.c FUJITA Tomonori
2007-07-17  7:19             ` block/bsg.c Jens Axboe
2007-07-17 10:07           ` block/bsg.c FUJITA Tomonori
2007-07-17 10:19             ` block/bsg.c Jens Axboe
2007-07-17 18:53               ` block/bsg.c James Bottomley
2007-07-17 19:48                 ` block/bsg.c Andrew Morton
2007-07-17 19:52                   ` block/bsg.c James Bottomley
2007-07-18  0:20                 ` block/bsg.c FUJITA Tomonori
2007-07-18 13:54                   ` block/bsg.c James Bottomley
2007-07-18 14:23                     ` block/bsg.c James Bottomley
2007-07-18 23:18                       ` block/bsg.c FUJITA Tomonori
2007-07-17 20:52               ` block/bsg.c Bartlomiej Zolnierkiewicz
2007-07-17 21:34                 ` block/bsg.c Andrew Morton
2007-07-17 23:19                   ` block/bsg.c Bartlomiej Zolnierkiewicz
2007-07-17 22:26                 ` block/bsg.c FUJITA Tomonori
2007-07-17 22:26                   ` block/bsg.c FUJITA Tomonori
2007-07-18 20:39                   ` block/bsg.c Bartlomiej Zolnierkiewicz
2007-07-18 23:44                     ` block/bsg.c FUJITA Tomonori
2007-07-17  7:24   ` block/bsg.c FUJITA Tomonori
2007-07-17 19:18   ` block/bsg.c Andrew Morton
2007-07-17 20:22     ` block/bsg.c Andrew Morton
2007-07-17 22:19       ` block/bsg.c James Bottomley
2007-07-17 22:54         ` block/bsg.c Andrew Morton
2007-07-17 22:57           ` block/bsg.c James Bottomley
2007-07-17 23:37         ` block/bsg.c Jeff Garzik
2007-07-18  0:43           ` block/bsg.c Bartlomiej Zolnierkiewicz
2007-07-18 14:11             ` block/bsg.c James Bottomley
2007-07-18 20:32               ` block/bsg.c Bartlomiej Zolnierkiewicz
2007-07-18 21:32                 ` block/bsg.c James Bottomley
2007-07-17  7:48 ` block/bsg.c Jan Engelhardt
2007-07-17 12:04 ` [PATCH] Don't define empty struct bsg_class_device if !CONFIG_BLK_DEV_BSG (was: Re: block/bsg.c) Geert Uytterhoeven
2007-07-17 12:10   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070716200357.15dd8c64.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=jeff@garzik.org \
    --cc=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.