Re: [RFC 7/8]KVM: swap out guest pages

[Avi Kivity <avi@qumranet.com>]

Shaohua Li wrote:
> Make KVM guest pages be allocated dynamically and able to be swaped out.
>
> One issue: all inodes returned from anon_inode_getfd are shared,
> if one module changes field of the inode, other moduels might break.
> Should we introduce a new API to not share inode?
>
> Signed-off-by: Shaohua Li <shaohua.li@intel.com>
> ---
>  drivers/kvm/kvm.h      |    8 +
>  drivers/kvm/kvm_main.c |  220 +++++++++++++++++++++++++++++++++++++++++++++----
>  2 files changed, 211 insertions(+), 17 deletions(-)
>
> +
> +	/*
> +	 * We just zap vcpu 0's page table. For a SMP guest, we should zap all
> + 	 * vcpus'. It's better shadow page table is per-vm.
> +	 */
> +	if (PagePrivate(page))
> +		kvm_mmu_zap_pagetbl(&kvm->vcpus[0], page->index);
> +
>   

You're not removing any shadows of the page, in case that page is a 
guest page table.  But I don't see anything wrong with it -- the page 
won't change while it's in swap.

-- 
error compiling committee.c: too many arguments to function