From: Avi Kivity <avi@qumranet.com>
To: Shaohua Li <shaoh.li@gmail.com>
Cc: kvm-devel <kvm-devel@lists.sourceforge.net>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [kvm-devel] [RFC 7/8]KVM: swap out guest pages
Date: Wed, 25 Jul 2007 16:25:08 +0300 [thread overview]
Message-ID: <46A74F34.5040508@qumranet.com> (raw)
In-Reply-To: <288dbef70707250620u5483d5dbxbcc461f8f685acdc@mail.gmail.com>
Shaohua Li wrote:
>> So write to a file, right? Yes, it can avoid use move to swap, and
>> should be feasible.
> Say you want to write guest pages out to file A of back store fs, in
> kvm->writepage(), we could do:
> 1. lower_page = grap_cache_page(file A's mapping)
> 2. file A's ->prepare_write(lower_page)
> 3. copy kvm guest page to lower_page
> 4. file A's ->commit_write(lower_page)
> then guest page can be freed. Just like the stack fs does. The
> downside is step 1 needs allocate a new page.
Yeah. Hopefully we can find a better solution, the copy isn't pretty
(though it's probably not too bad from a performance point of view
compared to the IPIs involved).
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Shaohua Li <shaoh.li-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: kvm-devel
<kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
lkml <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [RFC 7/8]KVM: swap out guest pages
Date: Wed, 25 Jul 2007 16:25:08 +0300 [thread overview]
Message-ID: <46A74F34.5040508@qumranet.com> (raw)
In-Reply-To: <288dbef70707250620u5483d5dbxbcc461f8f685acdc-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Shaohua Li wrote:
>> So write to a file, right? Yes, it can avoid use move to swap, and
>> should be feasible.
> Say you want to write guest pages out to file A of back store fs, in
> kvm->writepage(), we could do:
> 1. lower_page = grap_cache_page(file A's mapping)
> 2. file A's ->prepare_write(lower_page)
> 3. copy kvm guest page to lower_page
> 4. file A's ->commit_write(lower_page)
> then guest page can be freed. Just like the stack fs does. The
> downside is step 1 needs allocate a new page.
Yeah. Hopefully we can find a better solution, the copy isn't pretty
(though it's probably not too bad from a performance point of view
compared to the IPIs involved).
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
next prev parent reply other threads:[~2007-07-25 13:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-23 6:51 [RFC 7/8]KVM: swap out guest pages Shaohua Li
2007-07-23 6:51 ` Shaohua Li
2007-07-23 11:32 ` Avi Kivity
2007-07-23 11:32 ` Avi Kivity
2007-07-24 1:51 ` Shaohua Li
2007-07-24 1:51 ` Shaohua Li
2007-07-24 5:38 ` Avi Kivity
2007-07-24 5:38 ` Avi Kivity
2007-07-24 14:55 ` Avi Kivity
2007-07-24 14:55 ` Avi Kivity
2007-07-25 11:55 ` [kvm-devel] " Shaohua Li
2007-07-25 11:55 ` Shaohua Li
2007-07-25 13:20 ` [kvm-devel] " Shaohua Li
2007-07-25 13:20 ` Shaohua Li
2007-07-25 13:25 ` Avi Kivity [this message]
2007-07-25 13:25 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46A74F34.5040508@qumranet.com \
--to=avi@qumranet.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=shaoh.li@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.