From: Mike Christie <michaelc@cs.wisc.edu>
To: "Michael S. Tsirkin" <mst@dev.mellanox.co.il>
Cc: James Bottomley <James.Bottomley@steeleye.com>,
linux-scsi@vger.kernel.org, Roland Dreier <rdreier@cisco.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
general@lists.openfabrics.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: [ofa-general] Re: [PATCH trivial] include linux/mutex.h from scsi_transport_iscsi.h
Date: Wed, 25 Jul 2007 13:52:48 -0500 [thread overview]
Message-ID: <46A79C00.200@cs.wisc.edu> (raw)
In-Reply-To: <20070725110907.GF3826@mellanox.co.il>
Michael S. Tsirkin wrote:
> scsi/scsi_transport_iscsi.h uses struct mutex, so while
> linux/mutex.h seems to be pulled in indirectly
> by one of the headers it includes, the right thing
> is to include linux/mutex.h directly.
>
Is that part about always including the header directly right? If so
then were you going to include list.h too, and were you going to fix up
some of the other iscsi code?
WARNING: multiple messages have this Message-ID (diff)
From: Mike Christie <michaelc@cs.wisc.edu>
To: "Michael S. Tsirkin" <mst@dev.mellanox.co.il>
Cc: James Bottomley <James.Bottomley@steeleye.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-scsi@vger.kernel.org, Roland Dreier <rdreier@cisco.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
general@lists.openfabrics.org
Subject: Re: [PATCH trivial] include linux/mutex.h from scsi_transport_iscsi.h
Date: Wed, 25 Jul 2007 13:52:48 -0500 [thread overview]
Message-ID: <46A79C00.200@cs.wisc.edu> (raw)
In-Reply-To: <20070725110907.GF3826@mellanox.co.il>
Michael S. Tsirkin wrote:
> scsi/scsi_transport_iscsi.h uses struct mutex, so while
> linux/mutex.h seems to be pulled in indirectly
> by one of the headers it includes, the right thing
> is to include linux/mutex.h directly.
>
Is that part about always including the header directly right? If so
then were you going to include list.h too, and were you going to fix up
some of the other iscsi code?
next prev parent reply other threads:[~2007-07-25 18:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-25 11:09 [PATCH trivial] include linux/mutex.h from scsi_transport_iscsi.h Michael S. Tsirkin
2007-07-25 18:52 ` Mike Christie [this message]
2007-07-25 18:52 ` Mike Christie
2007-07-25 19:12 ` [ofa-general] " Michael S. Tsirkin
2007-07-25 19:12 ` Michael S. Tsirkin
2007-07-26 8:42 ` [PATCH trivial v2] add includes to scsi_transport_iscsi.h Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46A79C00.200@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=James.Bottomley@steeleye.com \
--cc=akpm@linux-foundation.org \
--cc=general@lists.openfabrics.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mst@dev.mellanox.co.il \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.