* [PATCH trivial] include linux/mutex.h from scsi_transport_iscsi.h
@ 2007-07-25 11:09 Michael S. Tsirkin
2007-07-25 18:52 ` Mike Christie
2007-07-26 8:42 ` [PATCH trivial v2] add includes to scsi_transport_iscsi.h Michael S. Tsirkin
0 siblings, 2 replies; 6+ messages in thread
From: Michael S. Tsirkin @ 2007-07-25 11:09 UTC (permalink / raw)
To: James Bottomley, Andrew Morton, linux-scsi, Mike Christie,
Roland Dreier, Linux Kernel Mailing List, general
scsi/scsi_transport_iscsi.h uses struct mutex, so while
linux/mutex.h seems to be pulled in indirectly
by one of the headers it includes, the right thing
is to include linux/mutex.h directly.
Signed-off-by: Michael S. Tsirkin <mst@dev.mellanox.co.il>
---
diff --git a/include/scsi/scsi_transport_iscsi.h b/include/scsi/scsi_transport_iscsi.h
index 706c0cd..7530e98 100644
--- a/include/scsi/scsi_transport_iscsi.h
+++ b/include/scsi/scsi_transport_iscsi.h
@@ -24,6 +24,7 @@
#define SCSI_TRANSPORT_ISCSI_H
#include <linux/device.h>
+#include <linux/mutex.h>
#include <scsi/iscsi_if.h>
struct scsi_transport_template;
--
MST
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [ofa-general] Re: [PATCH trivial] include linux/mutex.h from scsi_transport_iscsi.h
2007-07-25 11:09 [PATCH trivial] include linux/mutex.h from scsi_transport_iscsi.h Michael S. Tsirkin
@ 2007-07-25 18:52 ` Mike Christie
2007-07-26 8:42 ` [PATCH trivial v2] add includes to scsi_transport_iscsi.h Michael S. Tsirkin
1 sibling, 0 replies; 6+ messages in thread
From: Mike Christie @ 2007-07-25 18:52 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: James Bottomley, linux-scsi, Roland Dreier,
Linux Kernel Mailing List, general, Andrew Morton
Michael S. Tsirkin wrote:
> scsi/scsi_transport_iscsi.h uses struct mutex, so while
> linux/mutex.h seems to be pulled in indirectly
> by one of the headers it includes, the right thing
> is to include linux/mutex.h directly.
>
Is that part about always including the header directly right? If so
then were you going to include list.h too, and were you going to fix up
some of the other iscsi code?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH trivial] include linux/mutex.h from scsi_transport_iscsi.h
@ 2007-07-25 18:52 ` Mike Christie
0 siblings, 0 replies; 6+ messages in thread
From: Mike Christie @ 2007-07-25 18:52 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: James Bottomley, Andrew Morton, linux-scsi, Roland Dreier,
Linux Kernel Mailing List, general
Michael S. Tsirkin wrote:
> scsi/scsi_transport_iscsi.h uses struct mutex, so while
> linux/mutex.h seems to be pulled in indirectly
> by one of the headers it includes, the right thing
> is to include linux/mutex.h directly.
>
Is that part about always including the header directly right? If so
then were you going to include list.h too, and were you going to fix up
some of the other iscsi code?
^ permalink raw reply [flat|nested] 6+ messages in thread
* [ofa-general] Re: [PATCH trivial] include linux/mutex.h from scsi_transport_iscsi.h
2007-07-25 18:52 ` Mike Christie
@ 2007-07-25 19:12 ` Michael S. Tsirkin
-1 siblings, 0 replies; 6+ messages in thread
From: Michael S. Tsirkin @ 2007-07-25 19:12 UTC (permalink / raw)
To: Mike Christie
Cc: James Bottomley, linux-scsi, Roland Dreier,
Linux Kernel Mailing List, Michael S. Tsirkin, general,
Andrew Morton
> Quoting Mike Christie <michaelc@cs.wisc.edu>:
> Subject: Re: [PATCH trivial] include linux/mutex.h from scsi_transport_iscsi.h
>
> Michael S. Tsirkin wrote:
> >scsi/scsi_transport_iscsi.h uses struct mutex, so while
> >linux/mutex.h seems to be pulled in indirectly
> >by one of the headers it includes, the right thing
> >is to include linux/mutex.h directly.
> >
>
> Is that part about always including the header directly right?
Think so. Analogous patches by me has been accepted in various
subsystems. See e.g. f8916c11a4dc4cb2367e9bee1788f4e0f1b4eabc.
> If so
> then were you going to include list.h too,
Makes sense. I'll repost.
> and were you going to fix up
> some of the other iscsi code?
Not at the moment.
The reason I noticed this is because I'm doing some other project.
I'll post patches for other files if/when I notice any issues.
--
MST
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH trivial] include linux/mutex.h from scsi_transport_iscsi.h
@ 2007-07-25 19:12 ` Michael S. Tsirkin
0 siblings, 0 replies; 6+ messages in thread
From: Michael S. Tsirkin @ 2007-07-25 19:12 UTC (permalink / raw)
To: Mike Christie
Cc: Michael S. Tsirkin, James Bottomley, Andrew Morton, linux-scsi,
Roland Dreier, Linux Kernel Mailing List, general
> Quoting Mike Christie <michaelc@cs.wisc.edu>:
> Subject: Re: [PATCH trivial] include linux/mutex.h from scsi_transport_iscsi.h
>
> Michael S. Tsirkin wrote:
> >scsi/scsi_transport_iscsi.h uses struct mutex, so while
> >linux/mutex.h seems to be pulled in indirectly
> >by one of the headers it includes, the right thing
> >is to include linux/mutex.h directly.
> >
>
> Is that part about always including the header directly right?
Think so. Analogous patches by me has been accepted in various
subsystems. See e.g. f8916c11a4dc4cb2367e9bee1788f4e0f1b4eabc.
> If so
> then were you going to include list.h too,
Makes sense. I'll repost.
> and were you going to fix up
> some of the other iscsi code?
Not at the moment.
The reason I noticed this is because I'm doing some other project.
I'll post patches for other files if/when I notice any issues.
--
MST
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH trivial v2] add includes to scsi_transport_iscsi.h
2007-07-25 11:09 [PATCH trivial] include linux/mutex.h from scsi_transport_iscsi.h Michael S. Tsirkin
2007-07-25 18:52 ` Mike Christie
@ 2007-07-26 8:42 ` Michael S. Tsirkin
1 sibling, 0 replies; 6+ messages in thread
From: Michael S. Tsirkin @ 2007-07-26 8:42 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: James Bottomley, Andrew Morton, linux-scsi, Mike Christie,
Roland Dreier, Linux Kernel Mailing List, general
scsi/scsi_transport_iscsi.h uses struct mutex and struct list_head,
so while linux/mutex.h and linux/list.h seem to be pulled in indirectly
by one of the headers it includes, the right thing
is to include linux/mutex.h and linus/list.h directly.
Signed-off-by: Michael S. Tsirkin <mst@dev.mellanox.co.il>
---
Changelog:
Mike Christie pointed out that linux/list.h is missing too.
diff --git a/include/scsi/scsi_transport_iscsi.h b/include/scsi/scsi_transport_iscsi.h
index 706c0cd..7ff6199 100644
--- a/include/scsi/scsi_transport_iscsi.h
+++ b/include/scsi/scsi_transport_iscsi.h
@@ -24,6 +24,8 @@
#define SCSI_TRANSPORT_ISCSI_H
#include <linux/device.h>
+#include <linux/list.h>
+#include <linux/mutex.h>
#include <scsi/iscsi_if.h>
struct scsi_transport_template;
--
MST
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-07-26 8:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-25 11:09 [PATCH trivial] include linux/mutex.h from scsi_transport_iscsi.h Michael S. Tsirkin
2007-07-25 18:52 ` [ofa-general] " Mike Christie
2007-07-25 18:52 ` Mike Christie
2007-07-25 19:12 ` [ofa-general] " Michael S. Tsirkin
2007-07-25 19:12 ` Michael S. Tsirkin
2007-07-26 8:42 ` [PATCH trivial v2] add includes to scsi_transport_iscsi.h Michael S. Tsirkin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.