Re: grub2 ChangeLog conf/i386-pc.rmk conf/powerpc-i...

Re: grub2 ChangeLog conf/i386-pc.rmk conf/powerpc-i...

[Vesa Jääskeläinen]

Jerone Young wrote:
> Added files:
> 	include        : multiboot.h multiboot2.h 
> 	include/grub   : multiboot.h multiboot2.h multiboot_loader.h 

include directory should be clean of grub includes, so I suppose first
line is mistake commit?

Re: grub2 ChangeLog conf/i386-pc.rmk conf/powerpc-i...

[Jerone Young]

This was no mistake. So here is the thinking here (I figured this
would come up). The multiboot heads outside of the grub directory are
not grub specific. This gives other operating systems or programs (in
this case GPL 3 compatible operating systems) the ability to include
these headers and use them. They mainly contain definitions that are
not just specific to grub, but multiboot.



On 7/25/07, Vesa Jääskeläinen <chaac@nic.fi> wrote:
> Jerone Young wrote:
> > Added files:
> >       include        : multiboot.h multiboot2.h
> >       include/grub   : multiboot.h multiboot2.h multiboot_loader.h
>
> include directory should be clean of grub includes, so I suppose first
> line is mistake commit?
>
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>

Re: grub2 ChangeLog conf/i386-pc.rmk conf/powerpc-i...

[Marco Gerards]

"Jerone Young" <jerone@gmail.com> writes:

> This was no mistake. So here is the thinking here (I figured this
> would come up). The multiboot heads outside of the grub directory are
> not grub specific. This gives other operating systems or programs (in
> this case GPL 3 compatible operating systems) the ability to include
> these headers and use them. They mainly contain definitions that are
> not just specific to grub, but multiboot.

It would be better to discuss such things on the list first, clearly.
The directory structure is, unfortunately, quite permanent in CVS and
difficult to change properly.

How about using include/multiboot/*.h instead?

--
Marco

Re: grub2 ChangeLog conf/i386-pc.rmk conf/powerpc-i...

[Jerone Young]

On 7/30/07, Marco Gerards <mgerards@xs4all.nl> wrote:
> "Jerone Young" <jerone@gmail.com> writes:
>
> > This was no mistake. So here is the thinking here (I figured this
> > would come up). The multiboot heads outside of the grub directory are
> > not grub specific. This gives other operating systems or programs (in
> > this case GPL 3 compatible operating systems) the ability to include
> > these headers and use them. They mainly contain definitions that are
> > not just specific to grub, but multiboot.
>
> It would be better to discuss such things on the list first, clearly.
> The directory structure is, unfortunately, quite permanent in CVS and
> difficult to change properly.
>
> How about using include/multiboot/*.h instead?

That could work also. Having include/multiboot/*.h wouldn't hurt.
Though is it necessary to have everything in it's own directory under
the include directory? I'm in favor either way.

>
> --
> Marco
>
>
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>

Re: grub2 ChangeLog conf/i386-pc.rmk conf/powerpc-i...

[Marco Gerards]

"Jerone Young" <jerone@gmail.com> writes:

> On 7/30/07, Marco Gerards <mgerards@xs4all.nl> wrote:
>> "Jerone Young" <jerone@gmail.com> writes:
>>
>> > This was no mistake. So here is the thinking here (I figured this
>> > would come up). The multiboot heads outside of the grub directory are
>> > not grub specific. This gives other operating systems or programs (in
>> > this case GPL 3 compatible operating systems) the ability to include
>> > these headers and use them. They mainly contain definitions that are
>> > not just specific to grub, but multiboot.
>>
>> It would be better to discuss such things on the list first, clearly.
>> The directory structure is, unfortunately, quite permanent in CVS and
>> difficult to change properly.
>>
>> How about using include/multiboot/*.h instead?
>
> That could work also. Having include/multiboot/*.h wouldn't hurt.
> Though is it necessary to have everything in it's own directory under
> the include directory? I'm in favor either way.

It is not a big issue for me and changing it now would make it messy
with CVS, I think.  It depends on what the other developers think.

--
Marco

Re: grub2 ChangeLog conf/i386-pc.rmk conf/powerpc-i...

[Yoshinori K. Okuji]

Hello,

On Thursday 26 July 2007 00:28, Jerone Young wrote:
> This was no mistake. So here is the thinking here (I figured this
> would come up). The multiboot heads outside of the grub directory are
> not grub specific. This gives other operating systems or programs (in
> this case GPL 3 compatible operating systems) the ability to include
> these headers and use them. They mainly contain definitions that are
> not just specific to grub, but multiboot.

First of all, thank you for the great contribution! I guess I really must 
finish writing up the specification now...

About the headers, I don't like the location, either. As I said before, the 
purpose of GRUB is not to provide a library. Even if code can be reused, this 
is out of our concern. And, more importantly, the reason why the header files 
are put under grub/ is to avoid conflicts with system headers. Although the 
probablity of having such a conflict on multiboot.h, I still prefer to 
segregate our own headers under grub.

Thanks,
Okuji

Re: grub2 ChangeLog conf/i386-pc.rmk conf/powerpc-i...

[Jerone Young]

That sounds reasonable. So perhaps having a multiboot directory as
Marco specified is the best way to go then. Let me know if this is an
a way everyone agrees on and I'll get a patch together to make things
nice for everyone.

On 8/7/07, Yoshinori K. Okuji <okuji@enbug.org> wrote:
> Hello,
>
> On Thursday 26 July 2007 00:28, Jerone Young wrote:
> > This was no mistake. So here is the thinking here (I figured this
> > would come up). The multiboot heads outside of the grub directory are
> > not grub specific. This gives other operating systems or programs (in
> > this case GPL 3 compatible operating systems) the ability to include
> > these headers and use them. They mainly contain definitions that are
> > not just specific to grub, but multiboot.
>
> First of all, thank you for the great contribution! I guess I really must
> finish writing up the specification now...
>
> About the headers, I don't like the location, either. As I said before, the
> purpose of GRUB is not to provide a library. Even if code can be reused, this
> is out of our concern. And, more importantly, the reason why the header files
> are put under grub/ is to avoid conflicts with system headers. Although the
> probablity of having such a conflict on multiboot.h, I still prefer to
> segregate our own headers under grub.
>
> Thanks,
> Okuji
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>

Re: grub2 ChangeLog conf/i386-pc.rmk conf/powerpc-i...

[Marco Gerards]

"Jerone Young" <jerone@gmail.com> writes:

> That sounds reasonable. So perhaps having a multiboot directory as
> Marco specified is the best way to go then. Let me know if this is an
> a way everyone agrees on and I'll get a patch together to make things
> nice for everyone.

I hear no objections... :-)

Too bad CVS sucks for these kinds of things :-)

--
Marco