From: Gabriel C <nix.or.die@googlemail.com>
To: Len Brown <lenb@kernel.org>
Cc: david@lang.hm, Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: defconfig , ACPI=n compile error
Date: Thu, 26 Jul 2007 20:53:22 +0200 [thread overview]
Message-ID: <46A8EDA2.4000905@googlemail.com> (raw)
In-Reply-To: <200707261405.09278.lenb@kernel.org>
>>
>> config ACPI_PROCESSOR
>> tristate "Processor"
>> default y
>> help
>> This driver installs ACPI as the idle handler for Linux, and uses
>> ACPI C2 and C3 processor states to save power, on systems that
>> support it. It is required by several flavors of cpufreq
>> Performance-state drivers.
>>
>> ...
>>
>> Is more logical for me to do it here but I may be wrong.
>
> ACPI_PROCESSOR supports C-states and P-states and is not directly
> related to support for system sleep states. If your system is recent,
> then it is likely that you want to enable this (and cpufreq) to save power --
> even if you are not interested in system-wide sleep states.
Btw nothing about HOTPLUG_CPU now but something is broken.
do a defconfig , make menuconfig , disable ACPI , make , and you get :
...
In file included from arch/i386/kernel/acpi/cstate.c:16:
include/acpi/processor.h:90: error: expected specifier-qualifier-list before 'acpi_integer'
include/acpi/processor.h:108: error: expected specifier-qualifier-list before 'acpi_integer'
include/acpi/processor.h:131: error: expected specifier-qualifier-list before 'acpi_integer'
include/acpi/processor.h:149: error: expected specifier-qualifier-list before 'acpi_integer'
include/acpi/processor.h:205: error: expected specifier-qualifier-list before 'acpi_handle'
include/acpi/processor.h:319: warning: 'struct acpi_device' declared inside parameter list
include/acpi/processor.h:319: warning: its scope is only this definition or declaration, which is probably not what you want
include/acpi/processor.h:322: warning: 'struct acpi_device' declared inside parameter list
make[2]: *** [arch/i386/kernel/acpi/cstate.o] Error 1
make[1]: *** [arch/i386/kernel/acpi] Error 2
...
$ grep ACPI .config
# Power management options (ACPI, APM)
# CONFIG_ACPI is not set
CONFIG_ACPI_PROCESSOR=y
CONFIG_X86_ACPI_CPUFREQ=y
CONFIG_X86_POWERNOW_K8_ACPI=y
CONFIG_X86_ACPI_CPUFREQ_PROC_INTF=y
Looks like CONFIG_X86_POWERNOW_K8_ACPI selects only ACPI_PROCESSOR , guessing it should depend on ACPI ?
>
> -Len
>
Gabriel
next prev parent reply other threads:[~2007-07-26 18:57 UTC|newest]
Thread overview: 146+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-25 16:38 [GIT PATCH] ACPI patches for 2.6.23-rc1 Len Brown
2007-07-25 16:49 ` Tino Keitel
2007-07-25 19:44 ` Len Brown
2007-07-25 18:48 ` Linus Torvalds
2007-07-25 22:51 ` Len Brown
2007-07-26 2:20 ` david
2007-07-26 4:26 ` Len Brown
2007-07-26 5:00 ` david
2007-07-26 6:55 ` Linus Torvalds
2007-07-26 17:45 ` Len Brown
2007-07-26 18:01 ` Linus Torvalds
2007-07-26 18:02 ` david
2007-07-26 18:16 ` Linus Torvalds
2007-07-26 18:27 ` Jeff Garzik
2007-07-26 18:18 ` Len Brown
2007-07-26 19:17 ` CONFIG_SUSPEND? (was: Re: [GIT PATCH] ACPI patches for 2.6.23-rc1) Rafael J. Wysocki
2007-07-26 19:57 ` Linus Torvalds
2007-07-26 20:48 ` Rafael J. Wysocki
2007-07-26 20:55 ` Linus Torvalds
2007-07-27 22:25 ` [2.6 patch] let SUSPEND select HOTPLUG_CPU Adrian Bunk
2007-07-27 22:47 ` Stefan Richter
2007-07-27 23:03 ` Adrian Bunk
2007-07-28 8:42 ` Stefan Richter
2007-07-30 21:18 ` Pavel Machek
2007-07-28 14:44 ` Sergio Monteiro Basto
2007-07-27 22:57 ` Linus Torvalds
2007-07-28 4:52 ` [2.6 patch] SOFTWARE_SUSPEND: handle HOTPLUG_CPU automatically Adrian Bunk
2007-07-28 9:07 ` Stefan Richter
2007-07-28 18:30 ` [2.6 patch] let SUSPEND select HOTPLUG_CPU Rafael J. Wysocki
2007-07-28 7:30 ` CONFIG_SUSPEND? (was: Re: [GIT PATCH] ACPI patches for 2.6.23-rc1) Len Brown
2007-07-28 7:33 ` [PATCH] ACPI: restore CONFIG_ACPI_SLEEP Len Brown
2007-07-28 16:25 ` CONFIG_SUSPEND? (was: Re: [GIT PATCH] ACPI patches for 2.6.23-rc1) Linus Torvalds
2007-07-28 16:55 ` Linus Torvalds
2007-07-28 18:29 ` Rafael J. Wysocki
2007-07-28 18:31 ` Linus Torvalds
2007-07-29 10:20 ` [PATCH 0/2] Introduce CONFIG_HIBERNATION and CONFIG_SUSPEND (was: CONFIG_SUSPEND?) Rafael J. Wysocki
2007-07-29 10:20 ` Rafael J. Wysocki
2007-07-29 10:21 ` [PATCH 1/2] Replace CONFIG_SOFTWARE_SUSPEND with CONFIG_HIBERNATION Rafael J. Wysocki
2007-07-29 10:21 ` Rafael J. Wysocki
2007-07-29 12:38 ` [PATCH 2/2] Introduce CONFIG_SUSPEND Rafael J. Wysocki
2007-07-29 12:38 ` Rafael J. Wysocki
2007-07-29 20:40 ` Adrian Bunk
2007-07-29 20:40 ` Adrian Bunk
2007-07-29 21:17 ` Rafael J. Wysocki
2007-07-29 21:17 ` Rafael J. Wysocki
2007-07-29 21:17 ` Rafael J. Wysocki
2007-07-29 21:18 ` Adrian Bunk
2007-07-29 21:18 ` Adrian Bunk
2007-07-29 21:36 ` Rafael J. Wysocki
2007-07-29 21:36 ` Rafael J. Wysocki
2007-07-29 21:30 ` Richard Hughes
2007-07-29 22:22 ` Rafael J. Wysocki
2007-07-30 21:26 ` Pavel Machek
2007-07-30 21:26 ` Pavel Machek
2007-07-29 22:22 ` Rafael J. Wysocki
2007-07-30 2:47 ` Kyle Moffett
2007-07-30 2:47 ` Kyle Moffett
2007-07-29 21:30 ` Richard Hughes
2007-07-29 21:36 ` Rafael J. Wysocki
2007-07-29 21:18 ` Adrian Bunk
2007-07-29 20:40 ` Adrian Bunk
2007-07-29 21:23 ` [PATCH 0/2] Introduce CONFIG_HIBERNATION and CONFIG_SUSPEND (updated) Rafael J. Wysocki
2007-07-29 21:24 ` [PATCH 1/2] Replace CONFIG_SOFTWARE_SUSPEND with CONFIG_HIBERNATION (updated) Rafael J. Wysocki
2007-07-29 21:24 ` Rafael J. Wysocki
2007-07-29 21:27 ` [PATCH 2/2] Introduce CONFIG_SUSPEND (updated) Rafael J. Wysocki
2007-07-31 4:59 ` Len Brown
2007-07-31 4:59 ` Len Brown
2007-07-31 9:15 ` Rafael J. Wysocki
2007-07-31 9:16 ` [linux-pm] " Oliver Neukum
2007-07-31 10:01 ` Rafael J. Wysocki
2007-07-31 10:01 ` [linux-pm] " Rafael J. Wysocki
2007-07-31 9:16 ` Oliver Neukum
2007-07-31 9:15 ` Rafael J. Wysocki
2007-07-29 21:27 ` Rafael J. Wysocki
2007-07-30 0:21 ` [PATCH 0/2] Introduce CONFIG_HIBERNATION and " Linus Torvalds
2007-07-30 0:21 ` Linus Torvalds
2007-07-30 7:25 ` Rafael J. Wysocki
2007-07-30 7:25 ` Rafael J. Wysocki
2007-07-31 3:54 ` Len Brown
2007-07-31 3:54 ` Len Brown
2007-07-31 3:54 ` [PATCH] create CONFIG_SUSPEND_UP_POSSIBLE Len Brown
2007-07-31 6:38 ` Pavel Machek
2007-07-31 9:33 ` Rafael J. Wysocki
2007-07-31 9:33 ` Rafael J. Wysocki
2007-08-03 19:23 ` Len Brown
2007-08-03 19:23 ` Len Brown
2007-08-05 18:36 ` Pavel Machek
2007-08-05 18:36 ` Pavel Machek
2007-07-31 6:38 ` Pavel Machek
2007-07-31 3:54 ` Len Brown
2007-08-01 3:27 ` [PATCH] ACPI: delete CONFIG_ACPI_PROCFS_SLEEP (again) Len Brown
2007-08-01 3:27 ` Len Brown
2007-08-01 10:24 ` Rafael J. Wysocki
2007-08-01 10:24 ` Rafael J. Wysocki
2007-07-29 21:23 ` [PATCH 0/2] Introduce CONFIG_HIBERNATION and CONFIG_SUSPEND (updated) Rafael J. Wysocki
2007-07-31 3:53 ` CONFIG_SUSPEND? (was: Re: [GIT PATCH] ACPI patches for 2.6.23-rc1) Len Brown
2007-07-31 4:09 ` david
2007-07-31 6:33 ` Pavel Machek
2007-07-26 10:07 ` [GIT PATCH] ACPI patches for 2.6.23-rc1 Gabriel C
2007-07-26 18:05 ` Len Brown
2007-07-26 18:18 ` Linus Torvalds
2007-07-26 18:38 ` Gabriel C
2007-07-26 18:53 ` Gabriel C [this message]
2007-07-26 7:02 ` Linus Torvalds
2007-07-27 6:26 ` Jan Dittmer
2007-07-27 16:25 ` Thomas Renninger
2007-07-27 23:07 ` Adrian Bunk
2007-07-27 23:07 ` Adrian Bunk
2007-07-27 23:41 ` Andreas Schwab
2007-07-27 23:41 ` Andreas Schwab
[not found] ` <617E1C2C70743745A92448908E030B2A0209BB9D@scsmsx411.amr.corp.intel.com>
2007-07-28 1:39 ` scripts/mod/file2alias.c cross compile problem Adrian Bunk
2007-07-28 1:39 ` Adrian Bunk
2007-08-02 15:09 ` Thomas Renninger
2007-08-02 15:09 ` Thomas Renninger
2007-08-02 16:25 ` Luck, Tony
2007-08-02 16:25 ` Luck, Tony
2007-08-02 16:25 ` Luck, Tony
2007-08-02 16:36 ` Andreas Schwab
2007-08-02 16:36 ` Andreas Schwab
2007-08-02 16:36 ` Andreas Schwab
2007-08-02 17:40 ` Luck, Tony
2007-08-02 17:40 ` Luck, Tony
2007-08-02 17:40 ` Luck, Tony
2007-08-02 18:09 ` Sam Ravnborg
2007-08-02 18:09 ` Sam Ravnborg
2007-08-02 19:15 ` Adrian Bunk
2007-08-02 19:15 ` Adrian Bunk
2007-08-02 19:24 ` Sam Ravnborg
2007-08-02 19:24 ` Sam Ravnborg
2007-08-02 19:39 ` Al Viro
2007-08-02 19:39 ` Al Viro
2007-08-02 22:08 ` Rusty Russell
2007-08-02 22:08 ` Rusty Russell
2007-08-02 23:03 ` Adrian Bunk
2007-08-02 23:03 ` Adrian Bunk
2007-08-16 14:27 ` Thomas Renninger
2007-08-16 14:27 ` Thomas Renninger
2007-08-16 16:26 ` Luck, Tony
2007-08-16 16:26 ` Luck, Tony
2007-08-16 16:26 ` Luck, Tony
2007-08-16 17:03 ` Thomas Renninger
2007-08-16 17:03 ` Thomas Renninger
2007-07-27 23:50 ` [GIT PATCH] ACPI patches for 2.6.23-rc1 Andreas Schwab
2007-07-27 23:50 ` Andreas Schwab
2007-07-28 7:58 ` Jan Dittmer
2007-08-01 1:34 ` Yasha Okshtein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46A8EDA2.4000905@googlemail.com \
--to=nix.or.die@googlemail.com \
--cc=akpm@linux-foundation.org \
--cc=david@lang.hm \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.