From: "Kok, Auke" <auke-jan.h.kok@intel.com>
To: Jan-Bernd Themann <ossthema@de.ibm.com>
Cc: Thomas Klein <tklein@de.ibm.com>, Jeff Garzik <jeff@garzik.org>,
Jan-Bernd Themann <themann@de.ibm.com>,
netdev <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-ppc <linuxppc-dev@ozlabs.org>,
Christoph Raisch <raisch@de.ibm.com>,
Marcus Eder <meder@de.ibm.com>,
Andrew Gallatin <gallatin@myri.com>,
Stefan Roscher <stefan.roscher@de.ibm.com>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH 3/4][RFC] ehea: LRO support
Date: Mon, 30 Jul 2007 09:37:36 -0700 [thread overview]
Message-ID: <46AE13D0.7060902@intel.com> (raw)
In-Reply-To: <200707301724.49829.ossthema@de.ibm.com>
Jan-Bernd Themann wrote:
> Added LRO support using the "SKB aggregate" interface
>
> Signed-off-by: Jan-Bernd Themann <themann@de.ibm.com>
>
> ---
> drivers/net/ehea/ehea.h | 9 ++++-
> drivers/net/ehea/ehea_ethtool.c | 15 +++++++
> drivers/net/ehea/ehea_main.c | 82 +++++++++++++++++++++++++++++++++++---
> 3 files changed, 98 insertions(+), 8 deletions(-)
<snip>
> +module_param(use_lro, int, 0);
> +module_param(lro_max_aggr, int, 0);
this should obviously (and Stephen H. probably agrees) be implemented in ethtool
instead, and opens up the question as to what changes we need to add to ethtool. ..
Auke
WARNING: multiple messages have this Message-ID (diff)
From: "Kok, Auke" <auke-jan.h.kok@intel.com>
To: Jan-Bernd Themann <ossthema@de.ibm.com>
Cc: netdev <netdev@vger.kernel.org>,
Christoph Raisch <raisch@de.ibm.com>,
Jan-Bernd Themann <themann@de.ibm.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-ppc <linuxppc-dev@ozlabs.org>,
Marcus Eder <meder@de.ibm.com>, Thomas Klein <tklein@de.ibm.com>,
Stefan Roscher <stefan.roscher@de.ibm.com>,
Jeff Garzik <jeff@garzik.org>, David Miller <davem@davemloft.net>,
Andrew Gallatin <gallatin@myri.com>
Subject: Re: [PATCH 3/4][RFC] ehea: LRO support
Date: Mon, 30 Jul 2007 09:37:36 -0700 [thread overview]
Message-ID: <46AE13D0.7060902@intel.com> (raw)
In-Reply-To: <200707301724.49829.ossthema@de.ibm.com>
Jan-Bernd Themann wrote:
> Added LRO support using the "SKB aggregate" interface
>
> Signed-off-by: Jan-Bernd Themann <themann@de.ibm.com>
>
> ---
> drivers/net/ehea/ehea.h | 9 ++++-
> drivers/net/ehea/ehea_ethtool.c | 15 +++++++
> drivers/net/ehea/ehea_main.c | 82 +++++++++++++++++++++++++++++++++++---
> 3 files changed, 98 insertions(+), 8 deletions(-)
<snip>
> +module_param(use_lro, int, 0);
> +module_param(lro_max_aggr, int, 0);
this should obviously (and Stephen H. probably agrees) be implemented in ethtool
instead, and opens up the question as to what changes we need to add to ethtool. ..
Auke
next prev parent reply other threads:[~2007-07-30 16:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-30 15:24 [PATCH 3/4][RFC] ehea: LRO support Jan-Bernd Themann
2007-07-30 15:24 ` Jan-Bernd Themann
2007-07-30 16:37 ` Kok, Auke [this message]
2007-07-30 16:37 ` Kok, Auke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46AE13D0.7060902@intel.com \
--to=auke-jan.h.kok@intel.com \
--cc=davem@davemloft.net \
--cc=gallatin@myri.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=meder@de.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=ossthema@de.ibm.com \
--cc=raisch@de.ibm.com \
--cc=stefan.roscher@de.ibm.com \
--cc=themann@de.ibm.com \
--cc=tklein@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.