From: Zoltan Menyhart <Zoltan.Menyhart@bull.net>
To: David Mosberger-Tang <dmosberger@gmail.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
LKML <linux-kernel@vger.kernel.org>,
"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
"tony.luck@intel.com" <tony.luck@intel.com>,
Christoph Lameter <clameter@sgi.com>
Subject: Re: [PATCH] flush icache before set_pte take6. [4/4] optimization
Date: Tue, 31 Jul 2007 08:38:48 +0000 [thread overview]
Message-ID: <46AEF518.4000002@bull.net> (raw)
In-Reply-To: <ed5aea430707302115h484620f1le51fc054436b273a@mail.gmail.com>
David Mosberger-Tang wrote:
> This seems crazy to me. Flushing should occur according to the
> *architecture*, not model-by-model. Even if we happen to get "lucky"
> on pre-Montecito CPUs, that doesn't justify such ugly hacks. Or you
> really want to debug this *again* come next CPU?
>
> --david
O.K. let's say we flush by default: the global flag is set.
We can have a (short) list of the CPU models which do not require
this flush.
If all of the CPUs are on the list then clear the global flag. And:
static inline void sync_icache_dcache(pte_t pte) {
if (pte_exec(pte) && global_flag)
__sync_icache_dcache(pte);
}
Thanks,
Zoltan
WARNING: multiple messages have this Message-ID (diff)
From: Zoltan Menyhart <Zoltan.Menyhart@bull.net>
To: David Mosberger-Tang <dmosberger@gmail.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
LKML <linux-kernel@vger.kernel.org>,
"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
"tony.luck@intel.com" <tony.luck@intel.com>,
Christoph Lameter <clameter@sgi.com>
Subject: Re: [PATCH] flush icache before set_pte take6. [4/4] optimization for cpus other than montecito
Date: Tue, 31 Jul 2007 10:38:48 +0200 [thread overview]
Message-ID: <46AEF518.4000002@bull.net> (raw)
In-Reply-To: <ed5aea430707302115h484620f1le51fc054436b273a@mail.gmail.com>
David Mosberger-Tang wrote:
> This seems crazy to me. Flushing should occur according to the
> *architecture*, not model-by-model. Even if we happen to get "lucky"
> on pre-Montecito CPUs, that doesn't justify such ugly hacks. Or you
> really want to debug this *again* come next CPU?
>
> --david
O.K. let's say we flush by default: the global flag is set.
We can have a (short) list of the CPU models which do not require
this flush.
If all of the CPUs are on the list then clear the global flag. And:
static inline void sync_icache_dcache(pte_t pte) {
if (pte_exec(pte) && global_flag)
__sync_icache_dcache(pte);
}
Thanks,
Zoltan
next prev parent reply other threads:[~2007-07-31 8:38 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-31 2:35 [PATCH] flush icache before set_pte take6. [0/4] KAMEZAWA Hiroyuki
2007-07-31 2:35 ` KAMEZAWA Hiroyuki
2007-07-31 2:38 ` [PATCH] flush icache before set_pte take6. [1/4] migration fix KAMEZAWA Hiroyuki
2007-07-31 2:38 ` KAMEZAWA Hiroyuki
2007-07-31 2:39 ` [PATCH] flush icache before set_pte take6. [2/4] sync icache dcache KAMEZAWA Hiroyuki
2007-07-31 2:39 ` KAMEZAWA Hiroyuki
2007-07-31 2:40 ` [PATCH] flush icache before set_pte take6. [3/4] add montecito KAMEZAWA Hiroyuki
2007-07-31 2:40 ` [PATCH] flush icache before set_pte take6. [3/4] add montecito brand name KAMEZAWA Hiroyuki
2007-07-31 2:41 ` [PATCH] flush icache before set_pte take6. [4/4] optimization for KAMEZAWA Hiroyuki
2007-07-31 2:41 ` [PATCH] flush icache before set_pte take6. [4/4] optimization for cpus other than montecito KAMEZAWA Hiroyuki
2007-07-31 4:15 ` David Mosberger-Tang
2007-07-31 4:15 ` David Mosberger-Tang
2007-07-31 4:29 ` [PATCH] flush icache before set_pte take6. [4/4] optimization KAMEZAWA Hiroyuki
2007-07-31 4:29 ` [PATCH] flush icache before set_pte take6. [4/4] optimization for cpus other than montecito KAMEZAWA Hiroyuki
2007-07-31 5:02 ` [PATCH] flush icache before set_pte take6. [4/4] optimization KAMEZAWA Hiroyuki
2007-07-31 5:02 ` [PATCH] flush icache before set_pte take6. [4/4] optimization for cpus other than montecito KAMEZAWA Hiroyuki
2007-07-31 17:06 ` Jim Hull
2007-07-31 17:06 ` Jim Hull
2007-08-01 9:27 ` [PATCH] flush icache before set_pte take6. [4/4] optimization Zoltan Menyhart
2007-08-01 9:27 ` [PATCH] flush icache before set_pte take6. [4/4] optimization for cpus other than montecito Zoltan Menyhart
2007-07-31 8:38 ` Zoltan Menyhart [this message]
2007-07-31 8:38 ` Zoltan Menyhart
2007-07-31 10:17 ` [PATCH] flush icache before set_pte take6. [4/4] optimization KAMEZAWA Hiroyuki
2007-07-31 10:17 ` [PATCH] flush icache before set_pte take6. [4/4] optimization for cpus other than montecito KAMEZAWA Hiroyuki
2007-07-31 11:02 ` [PATCH] flush icache before set_pte take6. [4/4] optimization Zoltan Menyhart
2007-07-31 11:02 ` [PATCH] flush icache before set_pte take6. [4/4] optimization for cpus other than montecito Zoltan Menyhart
2007-07-31 16:39 ` [PATCH] flush icache before set_pte take6. [3/4] add montecito brand name Luck, Tony
2007-07-31 16:39 ` Luck, Tony
2007-08-01 0:17 ` [PATCH] flush icache before set_pte take6. [3/4] add montecito KAMEZAWA Hiroyuki
2007-08-01 0:17 ` [PATCH] flush icache before set_pte take6. [3/4] add montecito brand name KAMEZAWA Hiroyuki
2007-07-31 16:44 ` [PATCH] flush icache before set_pte take6. [4/4] optimization for cpus other than montecito Luck, Tony
2007-07-31 16:44 ` Luck, Tony
2007-08-01 9:38 ` [PATCH] flush icache before set_pte take6. [4/4] optimization Zoltan Menyhart
2007-08-01 9:38 ` [PATCH] flush icache before set_pte take6. [4/4] optimization for cpus other than montecito Zoltan Menyhart
2007-08-01 13:44 ` David Mosberger-Tang
2007-08-01 13:44 ` David Mosberger-Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46AEF518.4000002@bull.net \
--to=zoltan.menyhart@bull.net \
--cc=clameter@sgi.com \
--cc=dmosberger@gmail.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.