All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Hancock <hancockr@shaw.ca>
To: Mark Lord <lkml@rtr.ca>
Cc: "Maciej W. Rozycki" <macro@linux-mips.org>,
	Russell King <rmk+lkml@arm.linux.org.uk>,
	Lee Howard <faxguy@howardsilvan.com>,
	linux-serial@vger.kernel.org, tytso@mit.edu,
	linux-kernel@vger.kernel.org
Subject: Re: serial flow control appears broken
Date: Thu, 02 Aug 2007 10:40:20 -0600	[thread overview]
Message-ID: <46B208F4.6090901@shaw.ca> (raw)
In-Reply-To: <46B20662.6080606@rtr.ca>

Mark Lord wrote:
>> I think that PIO transfers only have to be done with interrupts 
>> disabled on really old, evil controllers (without unmask set). I don't 
>> think libata ever disables interrupts during transfers(?)
> 
> That's what "hdparm -u1" (or -u0) controls.
> 
> But it doesn't matter a whit here.  The problem is that the IDE interrupt
> handling can take a long time, regardless of whether it unmasks IRQs or 
> not.
> And if that IDE interrupt interrupts a serial interrupt, then the serial
> stuff won't get handled until the IDE stuff completes.  Thus the problem.
> 
> The "fix" could be to have the serial IRQ handler never unmask interrupts,
> but that's a bit unsociable to others.  The IDE stuff really needs to not
> do so much during the actual IRQ handler.
> 
> Ingo's RT patches would probably fix all of this.

libata also doesn't do the actual PIO transfer from the interrupt 
handler like old IDE does, either, and it only disables interrupts for 
the transfer if it's transferring to/from high memory..

-- 
Robert Hancock      Saskatoon, SK, Canada
To email, remove "nospam" from hancockr@nospamshaw.ca
Home Page: http://www.roberthancock.com/


  reply	other threads:[~2007-08-02 16:41 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <fa.Z6O0xFRT69zes0Mg+agt3Uiwux4@ifi.uio.no>
2007-07-26  7:20 ` serial flow control appears broken Robert Hancock
2007-07-26 16:08   ` Lee Howard
2007-07-26 16:31     ` Alan Cox
2007-07-27  5:53       ` Lee Howard
2007-07-27 11:47         ` Alan Cox
2007-07-27 17:36           ` Lee Howard
2007-07-27 13:45         ` Tilman Schmidt
2007-07-27 19:34           ` Paul Fulghum
2007-08-27 20:38             ` Paul Fulghum
2007-07-27 20:48             ` Lee Howard
2007-07-27 23:28               ` Paul Fulghum
2007-07-28  4:51                 ` Lee Howard
2007-07-28  9:18                   ` Russell King
2007-07-28 12:00                   ` Alan Cox
2007-07-28 15:39                     ` Lee Howard
2007-08-01 21:54                       ` Frantisek Rysanek
2007-07-28 16:41                   ` Ray Lee
2007-08-04 18:21                     ` Lee Howard
2007-08-04 22:07                       ` Paul Fulghum
2007-08-05  0:00                         ` Lee Howard
2007-08-05 14:52                           ` Paul Fulghum
2007-07-27 19:34           ` Paul Fulghum
2007-07-27 20:05           ` Lee Howard
2007-07-27 11:32     ` Maciej W. Rozycki
2007-07-27 17:11       ` Lee Howard
2007-07-27 17:41         ` Alan Cox
2007-07-27 17:53         ` Maciej W. Rozycki
2007-07-27 18:11           ` Lee Howard
2007-07-30  9:36             ` Maciej W. Rozycki
2007-07-27 18:22           ` Robert Hancock
2007-07-27 18:46             ` Paul Fulghum
2007-07-27 19:05             ` Paul Fulghum
2007-07-30  9:39               ` Maciej W. Rozycki
2007-07-27 19:14             ` Paul Fulghum
2007-07-28  9:28             ` Russell King
2007-07-30  9:45               ` Maciej W. Rozycki
2007-07-30  9:59                 ` Russell King
2007-08-02 14:57                 ` Mark Lord
2007-08-02 16:14                   ` Robert Hancock
2007-08-02 16:29                     ` Mark Lord
2007-08-02 16:40                       ` Robert Hancock [this message]
2007-08-02 17:13                       ` Alan Cox
2007-08-04 19:38                       ` Lee Howard
2007-08-02 16:57                     ` Alan Cox
2007-08-02 17:02                       ` Robert Hancock
2007-08-03  9:32                       ` Maciej W. Rozycki
2007-07-30  9:34             ` Maciej W. Rozycki
2007-08-04 18:19           ` Lee Howard
2007-07-26  1:52 Lee Howard
2007-07-26 12:34 ` Uwe Kleine-König
2007-07-26 12:34   ` Uwe Kleine-König
2007-07-26 16:28   ` Lee Howard
2007-07-26 16:28     ` Lee Howard
2007-07-26 16:41     ` Alan Cox
2007-07-27  6:17       ` Lee Howard
2007-07-27 11:56         ` Alan Cox
2007-07-27 18:00           ` Lee Howard
2007-07-26 15:51 ` Tosoni
2007-07-26 16:31   ` Lee Howard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46B208F4.6090901@shaw.ca \
    --to=hancockr@shaw.ca \
    --cc=faxguy@howardsilvan.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=lkml@rtr.ca \
    --cc=macro@linux-mips.org \
    --cc=rmk+lkml@arm.linux.org.uk \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.