All of lore.kernel.org
 help / color / mirror / Atom feed
From: Songmao Tian <tiansm@lemote.com>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: linux-mips@linux-mips.org, alsa-devel@alsa-project.org,
	tiwai@suse.de, greg@kroah.com, ralf@linux-mips.org,
	jiankemeng@gmail.com
Subject: Re: ALSA on MIPS platform
Date: Wed, 08 Aug 2007 08:40:14 +0800	[thread overview]
Message-ID: <46B910EE.2010905@lemote.com> (raw)
In-Reply-To: <20070807.230157.59463765.anemo@mba.ocn.ne.jp>

Atsushi Nemoto wrote:
> On Tue, 7 Aug 2007 10:18:04 +0400, "Dajie Tan" <jiankemeng@gmail.com> wrote:
>   
>>  static inline unsigned long virt_to_phys(volatile const void *address)
>>  {
>> -       return (unsigned long)address - PAGE_OFFSET + PHYS_OFFSET;
>> +       return ((unsigned long)address & 0x1fffffff) + PHYS_OFFSET;
>>  }
>>     
>
> This makes virt_to_phys() a bit slower, and more importantly, breaks
> 64-bit kernel.
>   

I have tried this way, and disassemble result show 32-bit kernel add 
only one instruction.
But I don't really insist on this patch, for it doesn't resolve some 
driver code requirement.
> ---
> Atsushi Nemoto
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
>
>   

WARNING: multiple messages have this Message-ID (diff)
From: Songmao Tian <tiansm@lemote.com>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: jiankemeng@gmail.com, linux-mips@linux-mips.org,
	alsa-devel@alsa-project.org, tiwai@suse.de, greg@kroah.com,
	ralf@linux-mips.org
Subject: Re: [alsa-devel] ALSA on MIPS platform
Date: Wed, 08 Aug 2007 08:40:14 +0800	[thread overview]
Message-ID: <46B910EE.2010905@lemote.com> (raw)
In-Reply-To: <20070807.230157.59463765.anemo@mba.ocn.ne.jp>

Atsushi Nemoto wrote:
> On Tue, 7 Aug 2007 10:18:04 +0400, "Dajie Tan" <jiankemeng@gmail.com> wrote:
>   
>>  static inline unsigned long virt_to_phys(volatile const void *address)
>>  {
>> -       return (unsigned long)address - PAGE_OFFSET + PHYS_OFFSET;
>> +       return ((unsigned long)address & 0x1fffffff) + PHYS_OFFSET;
>>  }
>>     
>
> This makes virt_to_phys() a bit slower, and more importantly, breaks
> 64-bit kernel.
>   

I have tried this way, and disassemble result show 32-bit kernel add 
only one instruction.
But I don't really insist on this patch, for it doesn't resolve some 
driver code requirement.
> ---
> Atsushi Nemoto
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
>
>   

  parent reply	other threads:[~2007-08-08  0:40 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-01  7:56 ALSA on MIPS platform Songmao Tian
2007-08-02 14:56 ` Atsushi Nemoto
2007-08-03 13:50   ` Songmao Tian
2007-08-03 13:50     ` Songmao Tian
2007-08-03 13:59     ` Takashi Iwai
2007-08-03 13:59       ` [alsa-devel] " Takashi Iwai
2007-08-03 15:57       ` Songmao Tian
2007-08-03 15:57         ` [alsa-devel] " Songmao Tian
2007-08-06 12:17         ` Takashi Iwai
2007-08-06 12:17           ` [alsa-devel] " Takashi Iwai
2007-08-07  5:53     ` Dajie Tan
2007-08-07  6:18       ` Dajie Tan
2007-08-07 14:01         ` Atsushi Nemoto
2007-08-07 17:54           ` Ralf Baechle
2007-08-07 17:54             ` Ralf Baechle
2007-08-07 18:41             ` Takashi Iwai
2007-08-07 18:41               ` Takashi Iwai
2007-08-08 11:58               ` Ralf Baechle
2007-08-08 11:58                 ` Ralf Baechle
2007-08-08 12:40                 ` Maciej W. Rozycki
2007-08-08 12:57                 ` Takashi Iwai
2007-08-08 12:57                   ` Takashi Iwai
2007-08-09  1:24             ` Songmao Tian
2007-08-09  1:24               ` Songmao Tian
2007-08-08  0:40           ` Songmao Tian [this message]
2007-08-08  0:40             ` [alsa-devel] " Songmao Tian
  -- strict thread matches above, loose matches on Subject: below --
2006-01-25 14:50 Atsushi Nemoto
2006-01-25 19:03 ` Takashi Iwai
2006-01-26 15:29   ` Atsushi Nemoto
2006-01-26 16:02     ` Takashi Iwai
2006-01-26 19:19       ` Hugh Dickins
2006-01-27 15:45       ` Atsushi Nemoto
2006-01-27 15:49         ` Martin Michlmayr
2006-01-27 16:01           ` Takashi Iwai
2006-01-27 15:57         ` Takashi Iwai
2006-01-30  9:56           ` Atsushi Nemoto
2006-01-30 10:18             ` Takashi Iwai
2006-01-30 10:38               ` Atsushi Nemoto
2006-01-30 12:25               ` Ralf Baechle
2006-01-30 15:46               ` Martin Michlmayr
2006-01-30 15:52                 ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46B910EE.2010905@lemote.com \
    --to=tiansm@lemote.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=anemo@mba.ocn.ne.jp \
    --cc=greg@kroah.com \
    --cc=jiankemeng@gmail.com \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.