From: Avi Kivity <avi@qumranet.com>
To: Laurent Vivier <Laurent.Vivier@bull.net>
Cc: kvm-devel <kvm-devel@lists.sourceforge.net>,
linux-kernel <linux-kernel@vger.kernel.org>,
virtualization <virtualization@lists.linux-foundation.org>
Subject: Re: [kvm-devel] [PATCH/RFC 4/4, second shot]KVM uses "account_guest_time()"
Date: Fri, 17 Aug 2007 16:03:14 +0300 [thread overview]
Message-ID: <46C59C92.40902@qumranet.com> (raw)
In-Reply-To: <46C58C8C.3080803@bull.net>
Laurent Vivier wrote:
> KVM updates vtime in task_struct to allow account_guest_time() to modify user,
> system and guest time in cpustat accordingly.
>
> --- kvm.orig/drivers/kvm/Kconfig 2007-08-17 10:24:46.000000000 +0200
> +++ kvm/drivers/kvm/Kconfig 2007-08-17 10:25:25.000000000 +0200
> @@ -41,4 +41,10 @@
> Provides support for KVM on AMD processors equipped with the AMD-V
> (SVM) extensions.
>
> +config GUEST_ACCOUNTING
> + bool "Virtual Machine accounting support"
> + depends on KVM
> + ---help---
> + Allows to account CPU time used by the Virtual Machines.
> +
Other way round. In the patch that adds account_guest_time(), have a
CONFIG_GUEST_ACCOUNTING (defaulting to n, with no description, help, or
dependencies. Then, CONFIG_KVM can select GUEST_ACCOUNTING.
The advantages of this are:
- the puppyvisor can also select this if it so wishes
- we don't have core code reference some obscure module
CONFIG_PREEMPT_NOTIFIERS does the same thing.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Laurent Vivier <Laurent.Vivier-6ktuUTfB/bM@public.gmane.org>
Cc: kvm-devel
<kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
linux-kernel
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
virtualization
<virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
Subject: Re: [PATCH/RFC 4/4, second shot]KVM uses "account_guest_time()"
Date: Fri, 17 Aug 2007 16:03:14 +0300 [thread overview]
Message-ID: <46C59C92.40902@qumranet.com> (raw)
In-Reply-To: <46C58C8C.3080803-6ktuUTfB/bM@public.gmane.org>
Laurent Vivier wrote:
> KVM updates vtime in task_struct to allow account_guest_time() to modify user,
> system and guest time in cpustat accordingly.
>
> --- kvm.orig/drivers/kvm/Kconfig 2007-08-17 10:24:46.000000000 +0200
> +++ kvm/drivers/kvm/Kconfig 2007-08-17 10:25:25.000000000 +0200
> @@ -41,4 +41,10 @@
> Provides support for KVM on AMD processors equipped with the AMD-V
> (SVM) extensions.
>
> +config GUEST_ACCOUNTING
> + bool "Virtual Machine accounting support"
> + depends on KVM
> + ---help---
> + Allows to account CPU time used by the Virtual Machines.
> +
Other way round. In the patch that adds account_guest_time(), have a
CONFIG_GUEST_ACCOUNTING (defaulting to n, with no description, help, or
dependencies. Then, CONFIG_KVM can select GUEST_ACCOUNTING.
The advantages of this are:
- the puppyvisor can also select this if it so wishes
- we don't have core code reference some obscure module
CONFIG_PREEMPT_NOTIFIERS does the same thing.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
next prev parent reply other threads:[~2007-08-17 13:03 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <46C4719A.2060308@bull.net>
2007-08-16 15:57 ` [PATCH/RFC 1/4]Introduce a new field "guest" in cpustat Laurent Vivier
2007-08-16 15:57 ` Laurent Vivier
[not found] ` <46C4720F.7030304@bull.net>
2007-08-16 15:57 ` [PATCH/RFC 2/4]Introduce a new field "guest" in task_struct Laurent Vivier
2007-08-16 15:57 ` Laurent Vivier
[not found] ` <46C4725A.4070607@bull.net>
2007-08-16 15:58 ` [PATCH/RFC 3/4]Introduce "account modifiers" mechanism Laurent Vivier
2007-08-16 22:39 ` Rusty Russell
2007-08-16 22:39 ` Rusty Russell
2007-08-17 7:35 ` Laurent Vivier
2007-08-17 7:35 ` Laurent Vivier
2007-08-17 8:30 ` Rusty Russell
2007-08-17 8:30 ` Rusty Russell
2007-08-17 8:30 ` Rusty Russell
2007-08-17 9:16 ` Laurent Vivier
2007-08-17 9:16 ` Laurent Vivier
2007-08-17 9:16 ` Laurent Vivier
2007-08-17 11:51 ` [PATCH/RFC 3/4, second shot]Introduce "account_guest_time" Laurent Vivier
2007-08-17 11:51 ` Laurent Vivier
2007-08-17 11:51 ` Laurent Vivier
2007-08-17 11:54 ` [PATCH/RFC 4/4, second shot]KVM uses "account_guest_time()" Laurent Vivier
2007-08-17 13:03 ` Avi Kivity [this message]
2007-08-17 13:03 ` Avi Kivity
2007-08-17 13:16 ` [kvm-devel] " Laurent Vivier
2007-08-17 13:16 ` Laurent Vivier
2007-08-19 7:39 ` [kvm-devel] " Avi Kivity
2007-08-19 7:39 ` Avi Kivity
2007-08-19 7:39 ` [kvm-devel] " Avi Kivity
2007-08-17 13:16 ` Laurent Vivier
2007-08-17 13:03 ` Avi Kivity
2007-08-17 11:54 ` Laurent Vivier
2007-08-17 12:59 ` [kvm-devel] [PATCH/RFC 3/4, second shot]Introduce "account_guest_time" Avi Kivity
2007-08-17 12:59 ` Avi Kivity
2007-08-17 12:55 ` [kvm-devel] [PATCH/RFC 3/4]Introduce "account modifiers" mechanism Avi Kivity
2007-08-17 12:55 ` Avi Kivity
2007-08-17 13:08 ` [kvm-devel] " Laurent Vivier
2007-08-17 13:08 ` Laurent Vivier
2007-08-17 13:08 ` Laurent Vivier
2007-08-17 13:32 ` [kvm-devel] " Christian Borntraeger
2007-08-17 13:32 ` Christian Borntraeger
2007-08-17 13:32 ` Christian Borntraeger
2007-08-19 7:41 ` [kvm-devel] " Avi Kivity
2007-08-19 7:41 ` Avi Kivity
2007-08-19 7:41 ` [kvm-devel] " Avi Kivity
2007-08-17 14:12 ` Laurent Vivier
2007-08-17 14:12 ` Laurent Vivier
2007-08-19 7:38 ` [kvm-devel] " Avi Kivity
2007-08-19 7:38 ` Avi Kivity
2007-08-19 7:38 ` Avi Kivity
2007-08-20 7:30 ` [kvm-devel] " Laurent Vivier
2007-08-20 7:30 ` Laurent Vivier
2007-08-20 7:55 ` [kvm-devel] " Avi Kivity
2007-08-20 7:55 ` Avi Kivity
2007-08-20 7:55 ` [kvm-devel] " Avi Kivity
2007-08-20 7:30 ` Laurent Vivier
2007-08-17 14:12 ` Laurent Vivier
2007-08-17 12:55 ` Avi Kivity
2007-08-17 7:35 ` Laurent Vivier
2007-08-16 15:58 ` Laurent Vivier
[not found] ` <46C472D2.7000702@bull.net>
2007-08-16 15:59 ` [PATCH/RFC 4/4]Modify KVM to use the "account modifiers" Laurent Vivier
2007-08-16 15:59 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46C59C92.40902@qumranet.com \
--to=avi@qumranet.com \
--cc=Laurent.Vivier@bull.net \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.