All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@qumranet.com>
To: Laurent Vivier <Laurent.Vivier@bull.net>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	kvm-devel <kvm-devel@lists.sourceforge.net>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	virtualization <virtualization@lists.linux-foundation.org>
Subject: Re: [kvm-devel] [PATCH/RFC 3/4]Introduce "account modifiers" mechanism
Date: Sun, 19 Aug 2007 10:38:10 +0300	[thread overview]
Message-ID: <46C7F362.80106@qumranet.com> (raw)
In-Reply-To: <46C5ACE8.2050004@bull.net>

Laurent Vivier wrote:
> Avi Kivity wrote:
> [...]
>   
>> The normal user/system accounting has the same issue, no?  Whereever we
>> happen to land (kernel or user) gets the whole tick.
>>
>> So I think it is okay to have the same limitation for guest time.
>>
>>     
>
> So this is how it looks like.
> PATCH 1 and 2 are always a prerequisite.
>
>   

> +	tmp = cputime_to_cputime64(cputime);
> +	if (p->flags & PF_VCPU) {
> +		p->utime = cputime_add(p->utime, cputime);
> +		p->gtime = cputime_add(p->gtime, cputime);
> +
> +		cpustat->guest = cputime64_add(cpustat->guest, tmp);
> +		cpustat->user = cputime64_add(cpustat->user, tmp);
> +
> +		p->flags &= ~PF_VCPU;
> +
> +		return;
> +	}
> +

Where did CONFIG_GUEST_ACCOUNTING go?


-- 
error compiling committee.c: too many arguments to function


WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Laurent Vivier <Laurent.Vivier-6ktuUTfB/bM@public.gmane.org>
Cc: kvm-devel
	<kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
	linux-kernel
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	virtualization
	<virtualization-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
Subject: Re: [PATCH/RFC 3/4]Introduce "account modifiers" mechanism
Date: Sun, 19 Aug 2007 10:38:10 +0300	[thread overview]
Message-ID: <46C7F362.80106@qumranet.com> (raw)
In-Reply-To: <46C5ACE8.2050004-6ktuUTfB/bM@public.gmane.org>

Laurent Vivier wrote:
> Avi Kivity wrote:
> [...]
>   
>> The normal user/system accounting has the same issue, no?  Whereever we
>> happen to land (kernel or user) gets the whole tick.
>>
>> So I think it is okay to have the same limitation for guest time.
>>
>>     
>
> So this is how it looks like.
> PATCH 1 and 2 are always a prerequisite.
>
>   

> +	tmp = cputime_to_cputime64(cputime);
> +	if (p->flags & PF_VCPU) {
> +		p->utime = cputime_add(p->utime, cputime);
> +		p->gtime = cputime_add(p->gtime, cputime);
> +
> +		cpustat->guest = cputime64_add(cpustat->guest, tmp);
> +		cpustat->user = cputime64_add(cpustat->user, tmp);
> +
> +		p->flags &= ~PF_VCPU;
> +
> +		return;
> +	}
> +

Where did CONFIG_GUEST_ACCOUNTING go?


-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

  parent reply	other threads:[~2007-08-19  7:38 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <46C4719A.2060308@bull.net>
2007-08-16 15:57 ` [PATCH/RFC 1/4]Introduce a new field "guest" in cpustat Laurent Vivier
2007-08-16 15:57 ` Laurent Vivier
     [not found] ` <46C4720F.7030304@bull.net>
2007-08-16 15:57   ` [PATCH/RFC 2/4]Introduce a new field "guest" in task_struct Laurent Vivier
2007-08-16 15:57   ` Laurent Vivier
     [not found]   ` <46C4725A.4070607@bull.net>
2007-08-16 15:58     ` [PATCH/RFC 3/4]Introduce "account modifiers" mechanism Laurent Vivier
2007-08-16 22:39       ` Rusty Russell
2007-08-17  7:35         ` Laurent Vivier
2007-08-17  7:35           ` Laurent Vivier
2007-08-17  8:30           ` Rusty Russell
2007-08-17  8:30           ` Rusty Russell
2007-08-17  8:30             ` Rusty Russell
2007-08-17  9:16             ` Laurent Vivier
2007-08-17  9:16             ` Laurent Vivier
2007-08-17  9:16               ` Laurent Vivier
2007-08-17 11:51               ` [PATCH/RFC 3/4, second shot]Introduce "account_guest_time" Laurent Vivier
2007-08-17 11:51                 ` Laurent Vivier
2007-08-17 11:54                 ` [PATCH/RFC 4/4, second shot]KVM uses "account_guest_time()" Laurent Vivier
2007-08-17 11:54                 ` Laurent Vivier
2007-08-17 13:03                   ` [kvm-devel] " Avi Kivity
2007-08-17 13:03                   ` Avi Kivity
2007-08-17 13:03                     ` Avi Kivity
2007-08-17 13:16                     ` [kvm-devel] " Laurent Vivier
2007-08-17 13:16                     ` Laurent Vivier
2007-08-17 13:16                       ` Laurent Vivier
2007-08-19  7:39                       ` [kvm-devel] " Avi Kivity
2007-08-19  7:39                         ` Avi Kivity
2007-08-19  7:39                       ` [kvm-devel] " Avi Kivity
2007-08-17 12:59                 ` [kvm-devel] [PATCH/RFC 3/4, second shot]Introduce "account_guest_time" Avi Kivity
2007-08-17 12:59                 ` Avi Kivity
2007-08-17 11:51               ` Laurent Vivier
2007-08-17 12:55               ` [kvm-devel] [PATCH/RFC 3/4]Introduce "account modifiers" mechanism Avi Kivity
2007-08-17 12:55               ` Avi Kivity
2007-08-17 12:55                 ` Avi Kivity
2007-08-17 13:08                 ` [kvm-devel] " Laurent Vivier
2007-08-17 13:08                 ` Laurent Vivier
2007-08-17 13:08                   ` Laurent Vivier
2007-08-17 13:32                   ` [kvm-devel] " Christian Borntraeger
2007-08-17 13:32                   ` Christian Borntraeger
2007-08-17 13:32                     ` Christian Borntraeger
2007-08-19  7:41                   ` [kvm-devel] " Avi Kivity
2007-08-19  7:41                   ` Avi Kivity
2007-08-19  7:41                     ` Avi Kivity
2007-08-17 14:12                 ` [kvm-devel] " Laurent Vivier
2007-08-17 14:12                   ` Laurent Vivier
2007-08-19  7:38                   ` [kvm-devel] " Avi Kivity
2007-08-19  7:38                   ` Avi Kivity [this message]
2007-08-19  7:38                     ` Avi Kivity
2007-08-20  7:30                     ` [kvm-devel] " Laurent Vivier
2007-08-20  7:30                       ` Laurent Vivier
2007-08-20  7:55                       ` [kvm-devel] " Avi Kivity
2007-08-20  7:55                         ` Avi Kivity
2007-08-20  7:55                       ` [kvm-devel] " Avi Kivity
2007-08-20  7:30                     ` Laurent Vivier
2007-08-17 14:12                 ` Laurent Vivier
2007-08-17  7:35         ` Laurent Vivier
2007-08-16 22:39       ` Rusty Russell
2007-08-16 15:58     ` Laurent Vivier
     [not found]     ` <46C472D2.7000702@bull.net>
2007-08-16 15:59       ` [PATCH/RFC 4/4]Modify KVM to use the "account modifiers" Laurent Vivier
2007-08-16 15:59       ` Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46C7F362.80106@qumranet.com \
    --to=avi@qumranet.com \
    --cc=Laurent.Vivier@bull.net \
    --cc=kvm-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.