From: Rene Herman <rene.herman@gmail.com>
To: Satyam Sharma <satyam@infradead.org>
Cc: Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jaroslav Kysela <perex@suse.cz>
Subject: Re: [PATCH -mm] sb16: Shut up uninitialized var build warning
Date: Mon, 03 Sep 2007 00:06:08 +0200 [thread overview]
Message-ID: <46DB33D0.40204@gmail.com> (raw)
In-Reply-To: <alpine.LFD.0.999.0709030143550.29617@enigma.security.iitk.ac.in>
On 09/02/2007 10:15 PM, Satyam Sharma wrote:
> sound/isa/sb16/sb16.c: In function ‘snd_sb16_isa_probe’:
Blah. Your message has:
Content-Type: TEXT/PLAIN; charset=iso-2022-jp
This apparently is caused by a combination of GCC using groovy UTF tickmarks
in its error messages when in a UTF locale and alpine believing it to be a
great idea to automatically try for the "simplest" character set it can
encode the content in. No idea why that means that iso-2022-jp is picked,
but it is.
While I could actually read the message this time you should see what
iso-2022-jp does to my font. It's scary. Best solution as far as I'm
concerned is slap a few GCC developers (not that it wil help, but it'll
certainly feel good) and then teach alpine to go for UTF-8 directly if
US-ASCII won't do.
As to the content of this patch -- I'd almost say it's better to live with
the warning than with that unitialized_var() thing. That ARRAY_SIZE is very
much a compile time constant, so exactly how dumb must GCC get before we get
to say to here and no further?
> --- linux-2.6.23-rc4-mm1/sound/isa/sb/sb16.c~fix 2007-09-02 21:41:51.000000000 +0530
> +++ linux-2.6.23-rc4-mm1/sound/isa/sb/sb16.c 2007-09-02 21:42:56.000000000 +0530
> @@ -556,7 +556,6 @@ static int __devinit snd_sb16_isa_match(
>
> static int __devinit snd_sb16_isa_probe(struct device *pdev, unsigned int dev)
> {
> - int err;
> static int possible_irqs[] = {5, 9, 10, 7, -1};
> static int possible_dmas8[] = {1, 3, 0, -1};
> static int possible_dmas16[] = {5, 6, 7, -1};
> @@ -585,6 +584,8 @@ static int __devinit snd_sb16_isa_probe(
> else {
> static int possible_ports[] = {0x220, 0x240, 0x260, 0x280};
> int i;
> + int uninitialized_var(err);
> +
> for (i = 0; i < ARRAY_SIZE(possible_ports); i++) {
> port[dev] = possible_ports[i];
> err = snd_sb16_isa_probe1(dev, pdev);
Rene.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
WARNING: multiple messages have this Message-ID (diff)
From: Rene Herman <rene.herman@gmail.com>
To: Satyam Sharma <satyam@infradead.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Takashi Iwai <tiwai@suse.de>, Jaroslav Kysela <perex@suse.cz>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH -mm] sb16: Shut up uninitialized var build warning
Date: Mon, 03 Sep 2007 00:06:08 +0200 [thread overview]
Message-ID: <46DB33D0.40204@gmail.com> (raw)
In-Reply-To: <alpine.LFD.0.999.0709030143550.29617@enigma.security.iitk.ac.in>
On 09/02/2007 10:15 PM, Satyam Sharma wrote:
> sound/isa/sb16/sb16.c: In function ‘snd_sb16_isa_probe’:
Blah. Your message has:
Content-Type: TEXT/PLAIN; charset=iso-2022-jp
This apparently is caused by a combination of GCC using groovy UTF tickmarks
in its error messages when in a UTF locale and alpine believing it to be a
great idea to automatically try for the "simplest" character set it can
encode the content in. No idea why that means that iso-2022-jp is picked,
but it is.
While I could actually read the message this time you should see what
iso-2022-jp does to my font. It's scary. Best solution as far as I'm
concerned is slap a few GCC developers (not that it wil help, but it'll
certainly feel good) and then teach alpine to go for UTF-8 directly if
US-ASCII won't do.
As to the content of this patch -- I'd almost say it's better to live with
the warning than with that unitialized_var() thing. That ARRAY_SIZE is very
much a compile time constant, so exactly how dumb must GCC get before we get
to say to here and no further?
> --- linux-2.6.23-rc4-mm1/sound/isa/sb/sb16.c~fix 2007-09-02 21:41:51.000000000 +0530
> +++ linux-2.6.23-rc4-mm1/sound/isa/sb/sb16.c 2007-09-02 21:42:56.000000000 +0530
> @@ -556,7 +556,6 @@ static int __devinit snd_sb16_isa_match(
>
> static int __devinit snd_sb16_isa_probe(struct device *pdev, unsigned int dev)
> {
> - int err;
> static int possible_irqs[] = {5, 9, 10, 7, -1};
> static int possible_dmas8[] = {1, 3, 0, -1};
> static int possible_dmas16[] = {5, 6, 7, -1};
> @@ -585,6 +584,8 @@ static int __devinit snd_sb16_isa_probe(
> else {
> static int possible_ports[] = {0x220, 0x240, 0x260, 0x280};
> int i;
> + int uninitialized_var(err);
> +
> for (i = 0; i < ARRAY_SIZE(possible_ports); i++) {
> port[dev] = possible_ports[i];
> err = snd_sb16_isa_probe1(dev, pdev);
Rene.
next prev parent reply other threads:[~2007-09-02 22:12 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.LFD.0.999.0709022344550.27844@enigma.security.iitk.ac.i n>
2007-09-02 20:02 ` [-mm patchset] War on warnings Satyam Sharma
2007-09-02 20:04 ` Jesper Juhl
2007-09-02 20:39 ` Satyam Sharma
2007-09-02 20:30 ` Jesper Juhl
2007-09-02 20:07 ` [PATCH -mm] sisusbvga: Fix bug and build warnings Satyam Sharma
2007-09-02 20:11 ` Jesper Juhl
2007-09-02 20:32 ` Satyam Sharma
2007-09-02 20:23 ` Jesper Juhl
2007-09-02 21:18 ` Alistair John Strachan
2007-09-02 21:38 ` Satyam Sharma
2007-09-02 22:27 ` Satyam Sharma
2007-09-09 21:32 ` patch usb-sisusbvga-fix-bug-and-build-warnings.patch added to gregkh-2.6 tree gregkh
2007-09-02 20:09 ` [PATCH -mm] sunrpc svc: Shut up bogus uninitialized variable warning Satyam Sharma
2007-09-02 20:11 ` [PATCH -mm] net/wireless/sysfs.c: Shut up build warning Satyam Sharma
2007-09-02 20:24 ` Johannes Berg
2007-09-02 20:12 ` [PATCH -mm] drivers/usb/serial/bus.c: Fix incompatible pointer type warning Satyam Sharma
2007-09-02 20:13 ` [PATCH -mm] IPS SCSI driver: Check return of scsi_add_host() Satyam Sharma
2007-09-02 20:03 ` Jesper Juhl
2007-09-02 20:03 ` Jesper Juhl
2007-09-02 20:32 ` Jeff Garzik
2007-09-02 20:32 ` Jeff Garzik
2007-09-02 22:39 ` Satyam Sharma
2007-09-02 20:15 ` [PATCH -mm] sb16: Shut up uninitialized var build warning Satyam Sharma
2007-09-02 22:06 ` Rene Herman [this message]
2007-09-02 22:06 ` Rene Herman
2007-09-02 22:34 ` Satyam Sharma
2007-09-02 22:34 ` Satyam Sharma
2007-09-20 17:52 ` Denys Vlasenko
2007-09-20 17:52 ` Denys Vlasenko
2007-09-22 4:20 ` Rene Herman
2007-09-22 4:20 ` Rene Herman
2007-09-02 20:16 ` [PATCH -mm] drivers/mmc/core/bus.c: Fix unused var warning Satyam Sharma
2007-09-03 9:04 ` Pierre Ossman
2007-09-02 20:18 ` [PATCH -mm] I2O: Fix "defined but not used" build warnings Satyam Sharma
2007-09-02 20:20 ` [PATCH -mm] mpt fusion: Shut up uninitialized variable warnings Satyam Sharma
2007-09-05 23:55 ` Moore, Eric
2007-09-02 20:21 ` [PATCH -mm] es18xx: Shut up uninitialized var build warning Satyam Sharma
2007-09-02 22:14 ` Rene Herman
2007-09-02 22:14 ` Rene Herman
2007-09-02 20:22 ` [PATCH -mm] drivers/md/: Shut up uninitialized variable warnings Satyam Sharma
2007-09-02 20:22 ` Satyam Sharma
2007-09-02 20:34 ` Jeff Garzik
2007-09-02 20:57 ` Satyam Sharma
2007-09-02 20:57 ` Satyam Sharma
2007-09-02 20:23 ` [PATCH -mm] DC395x SCSI driver: Shut up uninitialized variable build warning Satyam Sharma
2007-09-02 20:23 ` Jeff Garzik
2007-09-02 20:23 ` Jeff Garzik
2007-09-02 20:49 ` Satyam Sharma
2007-09-02 20:43 ` Jeff Garzik
2007-09-02 20:24 ` [PATCH -mm] i386 cpuid_count: Fix argument signedness warnings Satyam Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46DB33D0.40204@gmail.com \
--to=rene.herman@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@suse.cz \
--cc=satyam@infradead.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.