From: Tejun Heo <htejun@gmail.com>
To: postfail@hushmail.com
Cc: brandon@ifup.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH resubmit] /drivers/ata ioremap returncode check
Date: Mon, 03 Sep 2007 08:29:57 +0000 [thread overview]
Message-ID: <46DBC605.9040401@gmail.com> (raw)
In-Reply-To: <648310.70195.qm@web44903.mail.sp1.yahoo.com>
Scott Thompson wrote:
> Patchset against 2.6.23-rc3. corrects missing ioremap return
> checks, resending after fixing for documentation making changes suggested...
>
> As for suggestions, I did fix the {} that weren't needed. I did not add in a
> "printk" err or warn statement as the rest of the module does not contain these
> messages. When auditing (as I am for ioremap checking here) I am attempting
> to keep changes "in the style of their surroundings". Otherwise it's massive
> scope screep on these patches.
>
> Signed-off-by: Scott Thompson <postfail <at> hushmail.com>
Acked-by: Tejun Heo <htejun@gmail.com>
It would be better to start the subject line with pata_ixp4xx_cf: but
maybe Jeff can fix it up while applying.
Thanks.
--
tejun
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <htejun@gmail.com>
To: postfail@hushmail.com
Cc: brandon@ifup.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH resubmit] /drivers/ata ioremap returncode check
Date: Mon, 03 Sep 2007 17:29:57 +0900 [thread overview]
Message-ID: <46DBC605.9040401@gmail.com> (raw)
In-Reply-To: <648310.70195.qm@web44903.mail.sp1.yahoo.com>
Scott Thompson wrote:
> Patchset against 2.6.23-rc3. corrects missing ioremap return
> checks, resending after fixing for documentation making changes suggested...
>
> As for suggestions, I did fix the {} that weren't needed. I did not add in a
> "printk" err or warn statement as the rest of the module does not contain these
> messages. When auditing (as I am for ioremap checking here) I am attempting
> to keep changes "in the style of their surroundings". Otherwise it's massive
> scope screep on these patches.
>
> Signed-off-by: Scott Thompson <postfail <at> hushmail.com>
Acked-by: Tejun Heo <htejun@gmail.com>
It would be better to start the subject line with pata_ixp4xx_cf: but
maybe Jeff can fix it up while applying.
Thanks.
--
tejun
next prev parent reply other threads:[~2007-09-03 8:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070823023328.19E6CDA82B@mailserver7.hushmail.com>
2007-08-23 2:47 ` [PATCH resubmit] /drivers/ata ioremap returncode check Scott Thompson
2007-08-23 2:47 ` Scott Thompson
2007-08-23 5:34 ` Brandon Philips
2007-08-23 5:34 ` Brandon Philips
2007-08-23 17:42 ` Alexey Dobriyan
2007-08-23 17:42 ` Alexey Dobriyan
2007-08-23 17:53 ` Brandon Philips
2007-08-23 17:53 ` Brandon Philips
2007-08-23 19:34 ` Scott Thompson
2007-08-23 19:34 ` Scott Thompson
2007-09-03 8:29 ` Tejun Heo [this message]
2007-09-03 8:29 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46DBC605.9040401@gmail.com \
--to=htejun@gmail.com \
--cc=brandon@ifup.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=postfail@hushmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.