All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Travis <travis@sgi.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-mm@kvack.org, Andi Kleen <ak@suse.de>,
	linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
	sparclinux@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Christoph Lameter <clameter@sgi.com>
Subject: Re: [PATCH 09/10] ppc64: Convert cpu_sibling_map to a per_cpu data array (v3)
Date: Mon, 17 Sep 2007 08:22:55 -0700	[thread overview]
Message-ID: <46EE9BCF.3040303@sgi.com> (raw)
In-Reply-To: <20070917162831.b2a9d675.sfr@canb.auug.org.au>

Stephen Rothwell wrote:
> On Tue, 11 Sep 2007 18:56:53 -0700 travis@sgi.com wrote:
>> Convert cpu_sibling_map to a per_cpu cpumask_t array for the ppc64
>> architecture.  This fixes build errors in block/blktrace.c and
>> kernel/sched.c when CONFIG_SCHED_SMT is defined.
>>
>> Note: these changes have not been built nor tested.
> 
> After applying all 10 patches, the ppc64_defconfig builds but:
> 
> 	vmlinux is larger:
> 
>    text    data     bss     dec     hex filename
> 7705776 1756984  504624 9967384  981718 ppc64/vmlinux
> 7706228 1757120  504624 9967972  981964 trav.bld/vmlinux
> 
> 	the topology (on my POWERPC5+ box) is not correct:
> 
> cpu0/topology/thread_siblings:0000000f
> cpu1/topology/thread_siblings:0000000f
> cpu2/topology/thread_siblings:0000000f
> cpu3/topology/thread_siblings:0000000f
> 
> it used to be:
> 
> cpu0/topology/thread_siblings:00000003
> cpu1/topology/thread_siblings:00000003
> cpu2/topology/thread_siblings:0000000c
> cpu3/topology/thread_siblings:0000000c
> 
> Similarly on my iSeries box, the topology is displayed as above
> while it used to be:
> 
> cpu0/topology/thread_siblings:00000001
> cpu1/topology/thread_siblings:00000002
> cpu2/topology/thread_siblings:00000004
> cpu3/topology/thread_siblings:00000008
> 

Thanks Stephen for the feedback.  It may be the same situation
that some of the other arch's encounter in that the per_cpu
area is being accessed before it's setup.  I'll investigate
that a bit more.

Mike

WARNING: multiple messages have this Message-ID (diff)
From: Mike Travis <travis@sgi.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Andi Kleen <ak@suse.de>, Christoph Lameter <clameter@sgi.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	linuxppc-dev@ozlabs.org, sparclinux@vger.kernel.org
Subject: Re: [PATCH 09/10] ppc64: Convert cpu_sibling_map to a per_cpu data
Date: Mon, 17 Sep 2007 15:22:55 +0000	[thread overview]
Message-ID: <46EE9BCF.3040303@sgi.com> (raw)
In-Reply-To: <20070917162831.b2a9d675.sfr@canb.auug.org.au>

Stephen Rothwell wrote:
> On Tue, 11 Sep 2007 18:56:53 -0700 travis@sgi.com wrote:
>> Convert cpu_sibling_map to a per_cpu cpumask_t array for the ppc64
>> architecture.  This fixes build errors in block/blktrace.c and
>> kernel/sched.c when CONFIG_SCHED_SMT is defined.
>>
>> Note: these changes have not been built nor tested.
> 
> After applying all 10 patches, the ppc64_defconfig builds but:
> 
> 	vmlinux is larger:
> 
>    text    data     bss     dec     hex filename
> 7705776 1756984  504624 9967384  981718 ppc64/vmlinux
> 7706228 1757120  504624 9967972  981964 trav.bld/vmlinux
> 
> 	the topology (on my POWERPC5+ box) is not correct:
> 
> cpu0/topology/thread_siblings:0000000f
> cpu1/topology/thread_siblings:0000000f
> cpu2/topology/thread_siblings:0000000f
> cpu3/topology/thread_siblings:0000000f
> 
> it used to be:
> 
> cpu0/topology/thread_siblings:00000003
> cpu1/topology/thread_siblings:00000003
> cpu2/topology/thread_siblings:0000000c
> cpu3/topology/thread_siblings:0000000c
> 
> Similarly on my iSeries box, the topology is displayed as above
> while it used to be:
> 
> cpu0/topology/thread_siblings:00000001
> cpu1/topology/thread_siblings:00000002
> cpu2/topology/thread_siblings:00000004
> cpu3/topology/thread_siblings:00000008
> 

Thanks Stephen for the feedback.  It may be the same situation
that some of the other arch's encounter in that the per_cpu
area is being accessed before it's setup.  I'll investigate
that a bit more.

Mike

WARNING: multiple messages have this Message-ID (diff)
From: Mike Travis <travis@sgi.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Andi Kleen <ak@suse.de>, Christoph Lameter <clameter@sgi.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	linuxppc-dev@ozlabs.org, sparclinux@vger.kernel.org
Subject: Re: [PATCH 09/10] ppc64: Convert cpu_sibling_map to a per_cpu data array (v3)
Date: Mon, 17 Sep 2007 08:22:55 -0700	[thread overview]
Message-ID: <46EE9BCF.3040303@sgi.com> (raw)
In-Reply-To: <20070917162831.b2a9d675.sfr@canb.auug.org.au>

Stephen Rothwell wrote:
> On Tue, 11 Sep 2007 18:56:53 -0700 travis@sgi.com wrote:
>> Convert cpu_sibling_map to a per_cpu cpumask_t array for the ppc64
>> architecture.  This fixes build errors in block/blktrace.c and
>> kernel/sched.c when CONFIG_SCHED_SMT is defined.
>>
>> Note: these changes have not been built nor tested.
> 
> After applying all 10 patches, the ppc64_defconfig builds but:
> 
> 	vmlinux is larger:
> 
>    text    data     bss     dec     hex filename
> 7705776 1756984  504624 9967384  981718 ppc64/vmlinux
> 7706228 1757120  504624 9967972  981964 trav.bld/vmlinux
> 
> 	the topology (on my POWERPC5+ box) is not correct:
> 
> cpu0/topology/thread_siblings:0000000f
> cpu1/topology/thread_siblings:0000000f
> cpu2/topology/thread_siblings:0000000f
> cpu3/topology/thread_siblings:0000000f
> 
> it used to be:
> 
> cpu0/topology/thread_siblings:00000003
> cpu1/topology/thread_siblings:00000003
> cpu2/topology/thread_siblings:0000000c
> cpu3/topology/thread_siblings:0000000c
> 
> Similarly on my iSeries box, the topology is displayed as above
> while it used to be:
> 
> cpu0/topology/thread_siblings:00000001
> cpu1/topology/thread_siblings:00000002
> cpu2/topology/thread_siblings:00000004
> cpu3/topology/thread_siblings:00000008
> 

Thanks Stephen for the feedback.  It may be the same situation
that some of the other arch's encounter in that the per_cpu
area is being accessed before it's setup.  I'll investigate
that a bit more.

Mike

WARNING: multiple messages have this Message-ID (diff)
From: Mike Travis <travis@sgi.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Andi Kleen <ak@suse.de>, Christoph Lameter <clameter@sgi.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	linuxppc-dev@ozlabs.org, sparclinux@vger.kernel.org
Subject: Re: [PATCH 09/10] ppc64: Convert cpu_sibling_map to a per_cpu data array (v3)
Date: Mon, 17 Sep 2007 08:22:55 -0700	[thread overview]
Message-ID: <46EE9BCF.3040303@sgi.com> (raw)
In-Reply-To: <20070917162831.b2a9d675.sfr@canb.auug.org.au>

Stephen Rothwell wrote:
> On Tue, 11 Sep 2007 18:56:53 -0700 travis@sgi.com wrote:
>> Convert cpu_sibling_map to a per_cpu cpumask_t array for the ppc64
>> architecture.  This fixes build errors in block/blktrace.c and
>> kernel/sched.c when CONFIG_SCHED_SMT is defined.
>>
>> Note: these changes have not been built nor tested.
> 
> After applying all 10 patches, the ppc64_defconfig builds but:
> 
> 	vmlinux is larger:
> 
>    text    data     bss     dec     hex filename
> 7705776 1756984  504624 9967384  981718 ppc64/vmlinux
> 7706228 1757120  504624 9967972  981964 trav.bld/vmlinux
> 
> 	the topology (on my POWERPC5+ box) is not correct:
> 
> cpu0/topology/thread_siblings:0000000f
> cpu1/topology/thread_siblings:0000000f
> cpu2/topology/thread_siblings:0000000f
> cpu3/topology/thread_siblings:0000000f
> 
> it used to be:
> 
> cpu0/topology/thread_siblings:00000003
> cpu1/topology/thread_siblings:00000003
> cpu2/topology/thread_siblings:0000000c
> cpu3/topology/thread_siblings:0000000c
> 
> Similarly on my iSeries box, the topology is displayed as above
> while it used to be:
> 
> cpu0/topology/thread_siblings:00000001
> cpu1/topology/thread_siblings:00000002
> cpu2/topology/thread_siblings:00000004
> cpu3/topology/thread_siblings:00000008
> 

Thanks Stephen for the feedback.  It may be the same situation
that some of the other arch's encounter in that the per_cpu
area is being accessed before it's setup.  I'll investigate
that a bit more.

Mike

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2007-09-17 15:31 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-12  1:56 [PATCH 00/10] x86: Reduce Memory Usage and Inter-Node message traffic (v3) travis
2007-09-12  1:56 ` travis
2007-09-12  1:56 ` travis
2007-09-12  1:56 ` travis
2007-09-12  1:56 ` [PATCH 01/10] x86: remove x86_cpu_to_log_apicid array (v3) travis
2007-09-12  1:56   ` travis
2007-09-12  1:56   ` travis
2007-09-12  1:56   ` travis
2007-09-12  1:56 ` [PATCH 02/10] x86: fix cpu_to_node references (v3) travis
2007-09-12  1:56   ` travis
2007-09-12  1:56   ` travis
2007-09-12  1:56   ` travis
2007-09-12  1:56 ` [PATCH 03/10] x86: Convert cpu_core_map to be a per cpu variable (v3) travis
2007-09-12  1:56   ` travis
2007-09-12  1:56   ` travis
2007-09-12  1:56   ` travis
2007-09-12  1:56 ` [PATCH 04/10] x86: Convert cpu_sibling_map " travis
2007-09-12  1:56   ` travis
2007-09-12  1:56   ` travis
2007-09-12  1:56   ` travis
2007-09-12  1:56 ` [PATCH 05/10] x86: Convert x86_cpu_to_apicid " travis
2007-09-12  1:56   ` travis
2007-09-12  1:56   ` travis
2007-09-12  1:56   ` travis
2007-09-12  1:56 ` [PATCH 06/10] x86: Convert cpu_llc_id " travis
2007-09-12  1:56   ` travis
2007-09-12  1:56   ` travis
2007-09-12  1:56   ` travis
2007-09-12  1:56 ` [PATCH 07/10] x86: acpi-use-cpu_physical_id (v3) travis
2007-09-12  1:56   ` travis
2007-09-12  1:56   ` travis
2007-09-12  1:56   ` travis
2007-09-12  1:56 ` [PATCH 08/10] ia64: Convert cpu_sibling_map to a per_cpu data array (v3) travis
2007-09-12  1:56   ` travis
2007-09-12  1:56   ` travis
2007-09-12  1:56   ` travis
2007-09-28  9:49   ` Paul Jackson
2007-09-28  9:49     ` Paul Jackson
2007-09-28  9:49     ` Paul Jackson
2007-09-28  9:49     ` [PATCH 08/10] ia64: Convert cpu_sibling_map to a per_cpu data Paul Jackson
2007-10-03 19:22     ` [PATCH 08/10] ia64: Convert cpu_sibling_map to a per_cpu data array (v3) Mike Travis
2007-10-03 19:22       ` Mike Travis
2007-10-03 19:22       ` Mike Travis
2007-10-03 19:22       ` [PATCH 08/10] ia64: Convert cpu_sibling_map to a per_cpu data Mike Travis
2007-09-12  1:56 ` [PATCH 09/10] ppc64: Convert cpu_sibling_map to a per_cpu data array (v3) travis
2007-09-12  1:56   ` travis
2007-09-12  1:56   ` travis
2007-09-12  1:56   ` travis
2007-09-17  6:28   ` Stephen Rothwell
2007-09-17  6:28     ` Stephen Rothwell
2007-09-17  6:28     ` [PATCH 09/10] ppc64: Convert cpu_sibling_map to a per_cpu data Stephen Rothwell
2007-09-17  6:39     ` [PATCH 09/10] ppc64: Convert cpu_sibling_map to a per_cpu data array (v3) Stephen Rothwell
2007-09-17  6:39       ` Stephen Rothwell
2007-09-17  6:39       ` [PATCH 09/10] ppc64: Convert cpu_sibling_map to a per_cpu data Stephen Rothwell
2007-09-17 15:22     ` Mike Travis [this message]
2007-09-17 15:22       ` [PATCH 09/10] ppc64: Convert cpu_sibling_map to a per_cpu data array (v3) Mike Travis
2007-09-17 15:22       ` Mike Travis
2007-09-17 15:22       ` [PATCH 09/10] ppc64: Convert cpu_sibling_map to a per_cpu data Mike Travis
2007-09-12  1:56 ` [PATCH 10/10] sparc64: Convert cpu_sibling_map to a per_cpu data array (v3) travis
2007-09-12  1:56   ` travis
2007-09-12  1:56   ` travis
2007-09-12  1:56   ` travis
2007-09-13  9:53 ` [PATCH 00/10] x86: Reduce Memory Usage and Inter-Node message traffic (v3) Andi Kleen
2007-09-13  9:53   ` Andi Kleen
2007-09-13  9:53   ` Andi Kleen
2007-09-13  9:53   ` Andi Kleen
2007-09-14 23:32 ` Andrew Morton
2007-09-14 23:32   ` Andrew Morton
2007-09-14 23:32   ` Andrew Morton
2007-09-14 23:32   ` [PATCH 00/10] x86: Reduce Memory Usage and Inter-Node message Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46EE9BCF.3040303@sgi.com \
    --to=travis@sgi.com \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=clameter@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=sfr@canb.auug.org.au \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.