alsa-driver-1.0.15rc2 build issues on RHEL4/CentOS4

alsa-driver-1.0.15rc2 build issues on RHEL4/CentOS4

[James Pearson]

alsa-driver-1.0.15rc2 won't build cleanly on RHEL4/CentOS4 (2.6.9 based 
kernel).

I've included the relevant errors below after running:

configure --with-redhat
make -i

The problem with misc/ac97_bus.c, I've already reported at:

<http://mailman.alsa-project.org/pipermail/alsa-devel/2007-September/003119.html>

James Pearson


Build errors:

   CC [M]  /tmp/alsa-driver-1.0.15rc2/misc/ac97_bus.o
In file included from /tmp/alsa-driver-1.0.15rc2/misc/ac97_bus.c:3:
/tmp/alsa-driver-1.0.15rc2/misc/../alsa-kernel/ac97_bus.c: In function 
`ac97_bus_suspend':
/tmp/alsa-driver-1.0.15rc2/misc/../alsa-kernel/ac97_bus.c:35: error: too 
few arguments to function
/tmp/alsa-driver-1.0.15rc2/misc/../alsa-kernel/ac97_bus.c: In function 
`ac97_bus_resume':
/tmp/alsa-driver-1.0.15rc2/misc/../alsa-kernel/ac97_bus.c:45: error: too 
few arguments to function
make[4]: [/tmp/alsa-driver-1.0.15rc2/misc/ac97_bus.o] Error 1 (ignored)


   CC [M]  /tmp/alsa-driver-1.0.15rc2/pci/cs5535audio/cs5535audio_pm.o
In file included from 
/tmp/alsa-driver-1.0.15rc2/pci/cs5535audio/cs5535audio_pm.c:2:
/tmp/alsa-driver-1.0.15rc2/pci/cs5535audio/../../alsa-kernel/pci/cs5535audio/cs5535audio_pm.c: 
In function `snd_cs5535audio_suspend':
/tmp/alsa-driver-1.0.15rc2/pci/cs5535audio/../../alsa-kernel/pci/cs5535audio/cs5535audio_pm.c:77: 
error: void value not ignored as it ought to be
/tmp/alsa-driver-1.0.15rc2/pci/cs5535audio/../../alsa-kernel/pci/cs5535audio/cs5535audio_pm.c: 
In function `snd_cs5535audio_resume':
/tmp/alsa-driver-1.0.15rc2/pci/cs5535audio/../../alsa-kernel/pci/cs5535audio/cs5535audio_pm.c:95: 
error: void value not ignored as it ought to be
make[5]: [/tmp/alsa-driver-1.0.15rc2/pci/cs5535audio/cs5535audio_pm.o] 
Error 1 (ignored)
   LD [M]  /tmp/alsa-driver-1.0.15rc2/pci/cs5535audio/snd-cs5535audio.o
ld: /tmp/alsa-driver-1.0.15rc2/pci/cs5535audio/cs5535audio_pm.o: No such 
file: No such file or directory
make[5]: [/tmp/alsa-driver-1.0.15rc2/pci/cs5535audio/snd-cs5535audio.o] 
Error 1 (ignored)


   Building modules, stage 2.
   MODPOST
*** Warning: "class_device_destroy" 
[/tmp/alsa-driver-1.0.15rc2/pci/asihpi/snd-asihpi.ko] undefined!
*** Warning: "ac97_bus_type" 
[/tmp/alsa-driver-1.0.15rc2/pci/ac97/snd-ac97-codec.ko] undefined!
*** Warning: "platform_device_alloc" 
[/tmp/alsa-driver-1.0.15rc2/drivers/snd-portman2x4.ko] undefined!
*** Warning: "platform_device_add" 
[/tmp/alsa-driver-1.0.15rc2/drivers/snd-portman2x4.ko] undefined!
*** Warning: "platform_device_put" 
[/tmp/alsa-driver-1.0.15rc2/drivers/snd-portman2x4.ko] undefined!
*** Warning: "platform_device_alloc" 
[/tmp/alsa-driver-1.0.15rc2/drivers/snd-mts64.ko] undefined!
*** Warning: "platform_device_add" 
[/tmp/alsa-driver-1.0.15rc2/drivers/snd-mts64.ko] undefined!
*** Warning: "platform_device_put" 
[/tmp/alsa-driver-1.0.15rc2/drivers/snd-mts64.ko] undefined!

Re: alsa-driver-1.0.15rc2 build issues on RHEL4/CentOS4

[Takashi Iwai]

At Fri, 14 Sep 2007 11:15:12 +0100,
James Pearson wrote:
> 
> alsa-driver-1.0.15rc2 won't build cleanly on RHEL4/CentOS4 (2.6.9 based 
> kernel).
> 
> I've included the relevant errors below after running:
> 
> configure --with-redhat
> make -i
> 
> The problem with misc/ac97_bus.c, I've already reported at:
> 
> <http://mailman.alsa-project.org/pipermail/alsa-devel/2007-September/003119.html>
> 
> James Pearson

The fix is pending on my local tree.  Shall be fixed in rc3.


Takashi

Re: alsa-driver-1.0.15rc2 build issues on RHEL4/CentOS4

[James Pearson]

Takashi Iwai wrote:
> At Fri, 14 Sep 2007 11:15:12 +0100,
> James Pearson wrote:
> 
>>alsa-driver-1.0.15rc2 won't build cleanly on RHEL4/CentOS4 (2.6.9 based 
>>kernel).
>>
>>I've included the relevant errors below after running:
>>
>>configure --with-redhat
>>make -i
>>
>>The problem with misc/ac97_bus.c, I've already reported at:
>>
>><http://mailman.alsa-project.org/pipermail/alsa-devel/2007-September/003119.html>
>>
>>James Pearson
> 
> 
> The fix is pending on my local tree.  Shall be fixed in rc3.

I've just discovered that I can't load snd-ioctl32 from 1.0.15rc2 on 
RHEL4/CentOS4 - dmesg reports:

snd_ioctl32: Unknown symbol snd_ctl_elem_read
snd_ioctl32: Unknown symbol snd_ctl_elem_write

snd-ioctl32 with 1.0.15rc1 loads fine ...

James Pearson

Re: alsa-driver-1.0.15rc2 build issues on RHEL4/CentOS4

[James Pearson]

[-- Attachment #1: Type: text/plain, Size: 796 bytes --]

James Pearson wrote:

> 
> I've just discovered that I can't load snd-ioctl32 from 1.0.15rc2 on 
> RHEL4/CentOS4 - dmesg reports:
> 
> snd_ioctl32: Unknown symbol snd_ctl_elem_read
> snd_ioctl32: Unknown symbol snd_ctl_elem_write
> 
> snd-ioctl32 with 1.0.15rc1 loads fine ...

The problem is still there with 1.0.15rc3 - however, I've found the 
cause of the issue:

EXPORT_SYMBOL(snd_ctl_elem_read) and EXPORT_SYMBOL(snd_ctl_elem_write) 
have been removed from alsa-kernel/core/control.c - see:

<http://hg.alsa-project.org/alsa-kernel/rev/efd5ab99655e>

I guess this is OK for more recent kernels, but still needed for 
RHEL4/CentOS4 2.6.9 kernels

I can work round the problem by putting these back into acore/control.c

I've attached a patch which patches acore/control.patch

James Pearson

[-- Attachment #2: alsa-1.0.15rc3-control_patch.patch --]
[-- Type: text/plain, Size: 1147 bytes --]

--- ./acore/control.patch.dist	2007-09-21 09:41:25.000000000 +0100
+++ ./acore/control.patch	2007-09-26 12:07:14.809107031 +0100
@@ -1,5 +1,5 @@
---- ../alsa-kernel/core/control.c	2007-05-17 08:15:24.000000000 +0200
-+++ control.c	2007-05-24 21:25:20.000000000 +0200
+--- ../alsa-kernel/core/control.c	2007-09-21 09:41:26.000000000 +0100
++++ control.c	2007-09-26 12:06:00.936446240 +0100
 @@ -1,3 +1,4 @@
 +#define __NO_VERSION__
  /*
@@ -13,7 +13,25 @@
  #include <linux/slab.h>
  #include <linux/vmalloc.h>
  #include <linux/time.h>
-@@ -1387,25 +1389,44 @@
+@@ -716,6 +718,8 @@ int snd_ctl_elem_read(struct snd_card *c
+ 	return result;
+ }
+ 
++EXPORT_SYMBOL(snd_ctl_elem_read);
++
+ static int snd_ctl_elem_read_user(struct snd_card *card,
+ 				  struct snd_ctl_elem_value __user *_control)
+ {
+@@ -779,6 +783,8 @@ int snd_ctl_elem_write(struct snd_card *
+ 	return result;
+ }
+ 
++EXPORT_SYMBOL(snd_ctl_elem_write);
++
+ static int snd_ctl_elem_write_user(struct snd_ctl_file *file,
+ 				   struct snd_ctl_elem_value __user *_control)
+ {
+@@ -1383,25 +1389,44 @@ static int snd_ctl_fasync(int fd, struct
  /*
   * ioctl32 compat
   */

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: alsa-driver-1.0.15rc2 build issues on RHEL4/CentOS4

[James Pearson]

James Pearson wrote:
> alsa-driver-1.0.15rc2 won't build cleanly on RHEL4/CentOS4 (2.6.9 based 
> kernel).
> 
> I've included the relevant errors below after running:
> 
> configure --with-redhat
> make -i
>  
>    Building modules, stage 2.
>    MODPOST
> *** Warning: "class_device_destroy" 
> [/tmp/alsa-driver-1.0.15rc2/pci/asihpi/snd-asihpi.ko] undefined!
> *** Warning: "ac97_bus_type" 
> [/tmp/alsa-driver-1.0.15rc2/pci/ac97/snd-ac97-codec.ko] undefined!
> *** Warning: "platform_device_alloc" 
> [/tmp/alsa-driver-1.0.15rc2/drivers/snd-portman2x4.ko] undefined!
> *** Warning: "platform_device_add" 
> [/tmp/alsa-driver-1.0.15rc2/drivers/snd-portman2x4.ko] undefined!
> *** Warning: "platform_device_put" 
> [/tmp/alsa-driver-1.0.15rc2/drivers/snd-portman2x4.ko] undefined!
> *** Warning: "platform_device_alloc" 
> [/tmp/alsa-driver-1.0.15rc2/drivers/snd-mts64.ko] undefined!
> *** Warning: "platform_device_add" 
> [/tmp/alsa-driver-1.0.15rc2/drivers/snd-mts64.ko] undefined!
> *** Warning: "platform_device_put" 
> [/tmp/alsa-driver-1.0.15rc2/drivers/snd-mts64.ko] undefined!

Setting/changing the following in kconfig-vers 'fixes' the above:

SND_MTS64       2.6.10
SND_ASIHPI      2.6.10
SND_PORTMAN2X4  2.6.10
SND_CS5535AUDIO 2.6.10

(AC97_BUS is already set to 2.6.14 in rc3)

I don't know if all these build OK with 2.6.10 and above, but as 
RHEL4/CentOS4 is a 2.6.9 based kernel, then this works ...

James Pearson

Re: alsa-driver-1.0.15rc2 build issues on RHEL4/CentOS4

[Takashi Iwai]

At Wed, 26 Sep 2007 12:50:58 +0100,
James Pearson wrote:
> 
> James Pearson wrote:
> 
> > 
> > I've just discovered that I can't load snd-ioctl32 from 1.0.15rc2 on 
> > RHEL4/CentOS4 - dmesg reports:
> > 
> > snd_ioctl32: Unknown symbol snd_ctl_elem_read
> > snd_ioctl32: Unknown symbol snd_ctl_elem_write
> > 
> > snd-ioctl32 with 1.0.15rc1 loads fine ...
> 
> The problem is still there with 1.0.15rc3 - however, I've found the 
> cause of the issue:
> 
> EXPORT_SYMBOL(snd_ctl_elem_read) and EXPORT_SYMBOL(snd_ctl_elem_write) 
> have been removed from alsa-kernel/core/control.c - see:
> 
> <http://hg.alsa-project.org/alsa-kernel/rev/efd5ab99655e>
> 
> I guess this is OK for more recent kernels, but still needed for 
> RHEL4/CentOS4 2.6.9 kernels
> 
> I can work round the problem by putting these back into acore/control.c
> 
> I've attached a patch which patches acore/control.patch

Thanks, I fixed it with #ifdef CONFIG_SND_BIT32_EMUL_MODULE.
These shouldn't be exported unconditionally.

Also, some entries in kconfig_vers are changed as you suggested on HG
tree.

Hope now it works...


Takashi

Re: alsa-driver-1.0.15rc2 build issues on RHEL4/CentOS4

[James Pearson]

Takashi Iwai wrote:
> 
> Thanks, I fixed it with #ifdef CONFIG_SND_BIT32_EMUL_MODULE.
> These shouldn't be exported unconditionally.
> 
> Also, some entries in kconfig_vers are changed as you suggested on HG
> tree.
> 
> Hope now it works...

Not quite - the patch at:

<http://hg.alsa-project.org/alsa-driver/raw-diff/4dd14b787ef1/acore/control.patch>

adds EXPORT_SYMBOL(snd_ctl_elem_read) twice - but doesn't add 
EXPORT_SYMBOL(snd_ctl_elem_write) ...

Thanks

James Pearson

Re: alsa-driver-1.0.15rc2 build issues on RHEL4/CentOS4

[Takashi Iwai]

At Tue, 09 Oct 2007 12:58:09 +0100,
James Pearson wrote:
> 
> Takashi Iwai wrote:
> > 
> > Thanks, I fixed it with #ifdef CONFIG_SND_BIT32_EMUL_MODULE.
> > These shouldn't be exported unconditionally.
> > 
> > Also, some entries in kconfig_vers are changed as you suggested on HG
> > tree.
> > 
> > Hope now it works...
> 
> Not quite - the patch at:
> 
> <http://hg.alsa-project.org/alsa-driver/raw-diff/4dd14b787ef1/acore/control.patch>
> 
> adds EXPORT_SYMBOL(snd_ctl_elem_read) twice - but doesn't add 
> EXPORT_SYMBOL(snd_ctl_elem_write) ...

Argh.  Fixed now.

Thanks,

Takashi

Re: alsa-driver-1.0.15rc2 build issues on RHEL4/CentOS4

[James Pearson]

James Pearson wrote:
> James Pearson wrote:
> 
> Setting/changing the following in kconfig-vers 'fixes' the above:
> 
> SND_MTS64       2.6.10
> SND_ASIHPI      2.6.10
> SND_PORTMAN2X4  2.6.10
> SND_CS5535AUDIO 2.6.10

Unfortunately 'SND_CS5535AUDIO 2.6.10' above was missed out of 
kconfig-vers in 1.0.15 final, so alsa-driver 1.0.15 doesn't quite build 
on RHEL4/CentOS4 ...

I missed this as I tested it on x86_64 - where SND_CS5535AUDIO isn't set 
- but it is on i386 ...

James Pearson

Re: alsa-driver-1.0.15rc2 build issues on RHEL4/CentOS4

[Takashi Iwai]

At Wed, 17 Oct 2007 17:41:22 +0100,
James Pearson wrote:
> 
> James Pearson wrote:
> > James Pearson wrote:
> > 
> > Setting/changing the following in kconfig-vers 'fixes' the above:
> > 
> > SND_MTS64       2.6.10
> > SND_ASIHPI      2.6.10
> > SND_PORTMAN2X4  2.6.10
> > SND_CS5535AUDIO 2.6.10
> 
> Unfortunately 'SND_CS5535AUDIO 2.6.10' above was missed out of 
> kconfig-vers in 1.0.15 final, so alsa-driver 1.0.15 doesn't quite build 
> on RHEL4/CentOS4 ...
> 
> I missed this as I tested it on x86_64 - where SND_CS5535AUDIO isn't set 
> - but it is on i386 ...

Thanks, added now to HG tree.


Takashi