From: Scott Wood <scottwood@freescale.com>
To: Jon Smirl <jonsmirl@gmail.com>
Cc: linuxppc-embedded@ozlabs.org
Subject: Re: [RFC PATCH v0.1] net driver: mpc52xx fec
Date: Thu, 27 Sep 2007 13:43:03 -0500 [thread overview]
Message-ID: <46FBF9B7.9010007@freescale.com> (raw)
In-Reply-To: <9e4733910709271112y100e55e8q100336ce95acaf3f@mail.gmail.com>
Jon Smirl wrote:
> The call to msleep() is inside a block protected with
> :#define in_interrupt() (irq_count())
> if (!in_interrupt)
>
> The stack trace looks like it is in a timer interrupt so shouldn't
> irq_count be non-zero?
> Could there be some lack of coordination on irq_count and the timer
> tick with the preempt patch applied? Or does irq_count() not count
> soft irqs?
>
> (!in_interrupt) may be the wrong way to protect this code.
I think in_atomic() is what you want.
-Scott
next prev parent reply other threads:[~2007-09-27 18:43 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-10 9:51 [RFC PATCH v0.1] net driver: mpc52xx fec Domen Puncer
2007-08-10 13:02 ` Arnaldo Carvalho de Melo
2007-08-10 13:02 ` Arnaldo Carvalho de Melo
2007-08-13 7:21 ` Domen Puncer
2007-08-18 10:06 ` Domen Puncer
2007-08-19 15:39 ` Matt Sealey
2007-08-20 8:31 ` Domen Puncer
2007-08-20 13:13 ` Domen Puncer
2007-08-20 19:02 ` Matt Sealey
2007-08-21 5:49 ` Domen Puncer
2007-09-02 7:41 ` [RFC PATCH v0.2] " Domen Puncer
2007-09-03 15:57 ` Grant Likely
2007-09-03 16:09 ` Jon Smirl
2007-09-03 16:09 ` Jon Smirl
2007-09-03 16:41 ` Grant Likely
2007-09-03 16:41 ` Grant Likely
2007-09-15 12:14 ` Domen Puncer
2007-09-17 9:53 ` Sven Luther
2007-09-17 9:53 ` Sven Luther
2007-09-17 20:21 ` [PATCH] phy: export phy_mii_ioctl Domen Puncer
2007-09-17 22:08 ` Jon Smirl
2007-09-17 22:08 ` Jon Smirl
2007-09-18 15:16 ` Domen Puncer
2007-09-18 15:16 ` Domen Puncer
2007-09-18 19:17 ` Jon Smirl
2007-09-18 19:17 ` Jon Smirl
2007-09-19 11:56 ` Domen Puncer
2007-09-19 11:56 ` Domen Puncer
2007-09-19 18:44 ` Jon Smirl
2007-09-19 18:44 ` Jon Smirl
2007-09-19 21:18 ` Jon Smirl
2007-09-19 21:18 ` Jon Smirl
2007-09-18 19:29 ` Jon Smirl
2007-09-18 19:29 ` Jon Smirl
2007-09-19 8:54 ` Pedro Luis D. L.
2007-09-19 8:54 ` Pedro Luis D. L.
2007-09-19 10:37 ` Juergen Beisert
2007-09-19 10:37 ` Juergen Beisert
2007-09-19 11:38 ` Pedro Luis D. L.
2007-09-19 14:51 ` Juergen Beisert
2007-09-19 15:11 ` Pedro Luis D. L.
2007-09-19 13:56 ` Jon Smirl
2007-09-19 13:56 ` Jon Smirl
2007-09-19 14:31 ` Pedro Luis D. L.
2007-09-19 8:54 ` Pedro Luis D. L.
2007-09-19 8:54 ` Pedro Luis D. L.
2007-09-20 6:36 ` Jeff Garzik
2007-09-20 6:36 ` Jeff Garzik
2007-10-02 12:49 ` [RFC PATCH v0.2] net driver: mpc52xx fec Sascha Hauer
2007-10-02 12:49 ` Sascha Hauer
2007-10-02 14:32 ` Domen Puncer
2007-10-02 14:32 ` Domen Puncer
2007-10-02 15:46 ` Robert Schwebel
2007-10-02 15:46 ` Robert Schwebel
2007-09-27 17:07 ` [RFC PATCH v0.1] " Juergen Beisert
2007-09-27 18:12 ` Jon Smirl
2007-09-27 18:43 ` Scott Wood [this message]
2007-09-28 9:12 ` Juergen Beisert
2007-09-28 15:40 ` Scott Wood
2007-10-08 8:48 ` Sascha Hauer
2007-10-08 9:01 ` Sascha Hauer
2007-10-08 16:46 ` Jon Smirl
2007-09-28 15:07 ` Juergen Beisert
2007-09-28 15:38 ` Jon Smirl
2007-10-01 8:35 ` Juergen Beisert
2007-10-01 16:24 ` Juergen Beisert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46FBF9B7.9010007@freescale.com \
--to=scottwood@freescale.com \
--cc=jonsmirl@gmail.com \
--cc=linuxppc-embedded@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.