From: Matthieu Baerts <matttbe@kernel.org>
To: Geliang Tang <geliang@kernel.org>, mptcp@lists.linux.dev
Cc: Geliang Tang <tanggeliang@kylinos.cn>
Subject: Re: [PATCH mptcp-next v13 0/9] add helpers and vars in mptcp_lib.sh, part 3
Date: Wed, 6 Mar 2024 13:01:32 +0100 [thread overview]
Message-ID: <46b9be01-3fce-49a2-b9f9-e936405712c1@kernel.org> (raw)
In-Reply-To: <cover.1709688778.git.tanggeliang@kylinos.cn>
Hi Geliang,
On 06/03/2024 02:40, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
>
> v13:
> - fix the shellcheck error reported by CI in patch 8
> - rebased
>
> v12:
> - patch 1 Drop one more 1>&2, and update commit log
> - patch 2 use port_base=10000 instead of PORT=0
> - patch 4 fix the TAP output
> - patch 8 a new patch
> - patch 9 drop _printf in userspace_pm.sh
Thank you for the new version and the changelog. This v13 looks good to me.
Before applying the series, I have 3 suggestions (see my comments on
patches 2, 3, 9), and one important question (from v11):
Did you check the output when you force failure (e.g. by modifying the
code to force and issue, e.g. changing counters, set ret values, etc.)?
Just to make sure they are still presented correctly, and if we still
catch them!
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2024-03-06 12:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 1:40 [PATCH mptcp-next v13 0/9] add helpers and vars in mptcp_lib.sh, part 3 Geliang Tang
2024-03-06 1:40 ` [PATCH mptcp-next v13 1/9] selftests: mptcp: print all error messages to stdout Geliang Tang
2024-03-06 1:40 ` [PATCH mptcp-next v13 2/9] selftests: mptcp: connect: add dedicated port counter Geliang Tang
2024-03-06 12:02 ` Matthieu Baerts
2024-03-06 1:40 ` [PATCH mptcp-next v13 3/9] selftests: mptcp: connect: fix misaligned output Geliang Tang
2024-03-06 1:40 ` [PATCH mptcp-next v13 4/9] selftests: mptcp: sockopt: print every test result Geliang Tang
2024-03-06 1:40 ` [PATCH mptcp-next v13 5/9] selftests: mptcp: export TEST_COUNTER variable Geliang Tang
2024-03-06 1:40 ` [PATCH mptcp-next v13 6/9] selftests: mptcp: add print_title in mptcp_lib Geliang Tang
2024-03-06 1:40 ` [PATCH mptcp-next v13 7/9] selftests: mptcp: print test results with counters Geliang Tang
2024-03-06 12:04 ` Matthieu Baerts
2024-03-06 1:40 ` [PATCH mptcp-next v13 8/9] selftests: mptcp: connect: use += operator to append strings Geliang Tang
2024-03-06 1:40 ` [PATCH mptcp-next v13 9/9] selftests: mptcp: print test results with colors Geliang Tang
2024-03-06 2:33 ` selftests: mptcp: print test results with colors: Tests Results MPTCP CI
2024-03-06 2:49 ` MPTCP CI
2024-03-06 12:04 ` [PATCH mptcp-next v13 9/9] selftests: mptcp: print test results with colors Matthieu Baerts
2024-03-06 12:01 ` Matthieu Baerts [this message]
2024-03-06 15:28 ` [PATCH mptcp-next v13 0/9] add helpers and vars in mptcp_lib.sh, part 3 Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46b9be01-3fce-49a2-b9f9-e936405712c1@kernel.org \
--to=matttbe@kernel.org \
--cc=geliang@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=tanggeliang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.