Re: [PATCH mptcp-next v13 9/9] selftests: mptcp: print test results with colors

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang,

On 06/03/2024 02:40, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> To unify the output formats of all test scripts, this patch adds
> four more helpers:
> 
> 	mptcp_lib_pr_ok()
> 	mptcp_lib_pr_skip()
> 	mptcp_lib_pr_fail()
> 	mptcp_lib_pr_info()
> 
> to print out [ OK ], [SKIP], [FAIL] and 'INFO: ' with colors. Use them
> in all scripts to print the "ok/skip/fail/info' using the same 'format'.
> 
> Having colors helps to quickly identify issues when looking at a long
> list of output logs and results.
> 
> Note that now all print the same keywords, which was not the case
> before, but it is good to uniform that.

(...)

> diff --git a/tools/testing/selftests/net/mptcp/mptcp_lib.sh b/tools/testing/selftests/net/mptcp/mptcp_lib.sh
> index eb740a2f7898..d623c3c418be 100644
> --- a/tools/testing/selftests/net/mptcp/mptcp_lib.sh
> +++ b/tools/testing/selftests/net/mptcp/mptcp_lib.sh

(...)

> @@ -352,29 +369,30 @@ mptcp_lib_check_tools() {

I think you missed "mptcp_lib_check_output()" just above. Is it OK if I
replace the two 'mptcp_lib_print_err "[FAIL] "' by 'mptcp_lib_pr_fail'
when applying the series?

(...)

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.