Re: [PATCH mptcp-next v13 7/9] selftests: mptcp: print test results with counters

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang,

On 06/03/2024 02:40, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> This patch adds a new helper mptcp_lib_print_title(), a wrapper of
> mptcp_lib_inc_test_counter() and mptcp_lib_pr_title_counter(), to
> print out test counter in each test result and increase the counter.
> Use this helper to print out test counters for every tests in diag.sh,
> mptcp_connect.sh, mptcp_sockopt.sh, pm_netlink.sh, simult_flows.sh,
> and userspace_pm.sh.

(...)

> diff --git a/tools/testing/selftests/net/mptcp/mptcp_sockopt.sh b/tools/testing/selftests/net/mptcp/mptcp_sockopt.sh
> index 17b36c1312f4..466800326cbb 100755
> --- a/tools/testing/selftests/net/mptcp/mptcp_sockopt.sh
> +++ b/tools/testing/selftests/net/mptcp/mptcp_sockopt.sh
> @@ -113,11 +113,6 @@ check_mark()
>  	return 0
>  }
>  
> -print_title()
> -{
> -	printf "%-50s" "${@}"
> -}

That's strange to add this helper in patch 4/9, and removing it after.

To reduce the size of this patch, is it OK if I call
mptcp_lib_print_title() from print_title()? So only one line is changed,
only the 'printf' line, similar to what has been done in the other files?

I can do that when applying the series.

> -
>  do_transfer()
>  {
>  	local listener_ns="$1"

(...)

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.