All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Blue Swirl <blauwirbel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: kvm-devel
	<kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
	qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org
Subject: Re: [Qemu-devel] [PATCH] Fix color problems with sdl on	bgr displays
Date: Sun, 14 Oct 2007 16:36:26 +0200	[thread overview]
Message-ID: <4712296A.4030404@qumranet.com> (raw)
In-Reply-To: <f43fc5580710140727r19452244i4ad86cc31b50e7f3-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Blue Swirl wrote:
> On 10/14/07, Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org> wrote:
>   
>> Some kvm users complained that the blue and red channels are flipped on
>> their displays.  Reverting sdl.c rev 1.40 fixed that problem, so
>> apparently that commit made the problem larger than it was previously.
>>
>> Attached a patch the removes the commit and fixes the problem.  Please
>> apply.
>>     
>
> But this commit was previously reported as the best solution for OSX
> (Intel, PPC) and Linux/PPC:
> http://article.gmane.org/gmane.comp.emulators.qemu/18071
>
> What kind of machines are the users using?
>   

No idea, but I got two xdpyinfo logs and both indicated a bgr display.

Perhaps we see here a difference between how SDL behaves on different 
platforms.  Or maybe the test needs to be more subtle.

I haven't had any reports of wrong colors before; of course kvm users 
don't run Linux/PPC os OSX/anything.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@qumranet.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: kvm-devel <kvm-devel@lists.sourceforge.net>, qemu-devel@nongnu.org
Subject: Re: [kvm-devel] [Qemu-devel] [PATCH] Fix color problems with sdl on	bgr displays
Date: Sun, 14 Oct 2007 16:36:26 +0200	[thread overview]
Message-ID: <4712296A.4030404@qumranet.com> (raw)
In-Reply-To: <f43fc5580710140727r19452244i4ad86cc31b50e7f3@mail.gmail.com>

Blue Swirl wrote:
> On 10/14/07, Avi Kivity <avi@qumranet.com> wrote:
>   
>> Some kvm users complained that the blue and red channels are flipped on
>> their displays.  Reverting sdl.c rev 1.40 fixed that problem, so
>> apparently that commit made the problem larger than it was previously.
>>
>> Attached a patch the removes the commit and fixes the problem.  Please
>> apply.
>>     
>
> But this commit was previously reported as the best solution for OSX
> (Intel, PPC) and Linux/PPC:
> http://article.gmane.org/gmane.comp.emulators.qemu/18071
>
> What kind of machines are the users using?
>   

No idea, but I got two xdpyinfo logs and both indicated a bgr display.

Perhaps we see here a difference between how SDL behaves on different 
platforms.  Or maybe the test needs to be more subtle.

I haven't had any reports of wrong colors before; of course kvm users 
don't run Linux/PPC os OSX/anything.

-- 
error compiling committee.c: too many arguments to function

  parent reply	other threads:[~2007-10-14 14:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-14 13:52 [PATCH] Fix color problems with sdl on bgr displays Avi Kivity
2007-10-14 13:52 ` [Qemu-devel] " Avi Kivity
     [not found] ` <47121F0F.9020804-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-10-14 14:27   ` Blue Swirl
2007-10-14 14:27     ` Blue Swirl
     [not found]     ` <f43fc5580710140727r19452244i4ad86cc31b50e7f3-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-10-14 14:36       ` Avi Kivity [this message]
2007-10-14 14:36         ` [kvm-devel] " Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4712296A.4030404@qumranet.com \
    --to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
    --cc=blauwirbel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.